Hi,
I think you may want to use "self" for SpiceGtkSession variables
inside the .c. It would make it more obvious that this is not a gtk
symbol and it's also slightly easier to refactor (no clash with
function name, no need to rename). This way you avoid the conflict
session vs gtk_session. It's q
hi
On Tue, Oct 4, 2011 at 4:20 PM, Hans de Goede wrote:
> This initial commit of the SpiceGtkSession Class only adds the empty
> class and the 1:1 linkage to SpiceSession through 2 new private methods
> added to SpiceSession: spice_session_{get|set}_gtk_session.
>
> The following commits will mov
This fixes copy and paste with multi-monitor guests. There still is
one small issue left with this patch, changing the setting for auto-clipboard
in one spicy window, does not get reflected in the Options menu of the
other spicy windows.
This can be fixed by listening to the notify signal, this al
This initial commit of the SpiceGtkSession Class only adds the empty
class and the 1:1 linkage to SpiceSession through 2 new private methods
added to SpiceSession: spice_session_{get|set}_gtk_session.
The following commits will move things which are currently per SpiceDisplay,
but which really sho
Otherwise they cannot be included unless other headers are included
first (and in the right order).
Signed-off-by: Hans de Goede
---
gtk/spice-channel-cache.h |2 ++
gtk/spice-session-priv.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-channel-cache.h b
On 10/04/2011 01:25 PM, Yonit Halperin wrote:
On 10/04/2011 01:20 PM, Alon Levy wrote:
On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote:
On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote:
Unless I'm misreading the code (which may very well be), the
function looks like:
if (m
On 10/04/2011 01:20 PM, Alon Levy wrote:
On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote:
On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote:
Unless I'm misreading the code (which may very well be), the
function looks like:
if (mask_bitmap&& m) {
if (this or that) {
On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote:
> On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote:
> > Unless I'm misreading the code (which may very well be), the
> > function looks like:
> >
> > if (mask_bitmap && m) {
> > if (this or that) {
> > do X
> >
On 10/04/2011 01:00 PM, Alon Levy wrote:
On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote:
Unless I'm misreading the code (which may very well be), the
function looks like:
if (mask_bitmap&& m) {
if (this or that) {
do X
fill_bits(...)
} else {
fi
On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote:
> Unless I'm misreading the code (which may very well be), the
> function looks like:
>
> if (mask_bitmap && m) {
> if (this or that) {
> do X
> fill_bits(...)
> } else {
> fill_bits(...)
> }
> }
>
> S
Unless I'm misreading the code (which may very well be), the function
looks like:
if (mask_bitmap && m) {
if (this or that) {
do X
fill_bits(...)
} else {
fill_bits(...)
}
}
So essentially, if the condition (mask_bitmap && m) is NOT met, we do
not fill the b
11 matches
Mail list logo
