Re: [Spice-devel] [PATCH 2/2] spice: support the new migration interface (spice 0.8.3)

2011-09-25 Thread Alon Levy
On Wed, Sep 21, 2011 at 06:50:44PM +0300, Yonit Halperin wrote: > - call spice_server_migrate_(start|end|connect). > - register spice_migrate_connect completion callback > Reviewed-by: Alon Levy Will just fix the one place below in the pull request. > Signed-off-by: Yonit Halperin > --- > ui

Re: [Spice-devel] [PATCH v3 00/22] semi-seamless migration client & server v3

2011-09-25 Thread Alon Levy
On Sun, Sep 25, 2011 at 03:36:38PM +0300, Yonit Halperin wrote: > Changes from previous versions: > * fix "server: fall back to switch host scheme in case semi-seamless": send > switch-host msg only >if migration completed successfully > * client: initialize DisplayChannel::_mig_wait_primary

Re: [Spice-devel] [PATCH v3 16/22] client: handle SPICE_MSG_MAIN_MIGRATE_END

2011-09-25 Thread Alon Levy
On Sun, Sep 25, 2011 at 03:36:54PM +0300, Yonit Halperin wrote: > (1) disconnect all channels from the migration src > (2) after all channels are disconnected, clean global resources > (3) send SPICE_MSGC_MAIN_MIGRATE_END to migration target > (4) wait for SPICE_MSG_MAIN_INIT > (4) switch all chann

Re: [Spice-devel] [PATCH v3 13/22] client: rewrite surfaces cache

2011-09-25 Thread Alon Levy
On Sun, Sep 25, 2011 at 03:36:51PM +0300, Yonit Halperin wrote: > use std::map instead of a specific template (CHash). > There is no need for special template. Moreover, using > std::map will allow easy iteration over the surfaces. > This doesn't apply cleanly, in a trivial to fix way. > Signed-

Re: [Spice-devel] Help with TLS and SPICE client

2011-09-25 Thread Marian Krcmarik
I cannot see any obvious mistake in configuration (except for those commas in first post). Maybe It would be worthy to check the problem and possible fix which Thomas reported a while ago - http://lists.freedesktop.org/archives/spice-devel/2011-June/004156.html and filed a bz https://bugs.freed

Re: [Spice-devel] vdagent\vdservice W 2008R2 guest under Fedora 15

2011-09-25 Thread sean darcy
On 09/25/2011 07:25 AM, Arnon Gilboa wrote: Hi Sean, Remember to run cmd as Administrator. Is Z a network drive? put vdservice & vdagent on local drive. If it still fails, please send %windir\temp\vdservice.log & vdagent.log. Regarding the qxl driver, refer to the installing section in http://spi

[Spice-devel] [PATCH v3 22/22] Release 0.8.3

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- NEWS |8 configure.ac |2 +- server/spice-server.syms |4 server/spice.h |2 +- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ee6ceec..e9ed92e 100644 ---

[Spice-devel] [PATCH v3 21/22] client: support semi-seamless migration between spice servers with different protocols.

2011-09-25 Thread Yonit Halperin
It can't actually happen right now, since switch-host migration scheme will take place if the src/target server has protocol 1. Signed-off-by: Yonit Halperin --- client/red_channel.cpp | 20 client/red_channel.h |2 ++ client/red_client.cpp | 21 --

[Spice-devel] [PATCH v3 20/22] client: display channel - destroy all surfaces on disconnect

2011-09-25 Thread Yonit Halperin
Fix not destroying surfaces and other data (e.g., streams) upon disconnection. Signed-off-by: Yonit Halperin --- client/display_channel.cpp | 18 -- client/display_channel.h |1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/client/display_channel.cpp b

[Spice-devel] [PATCH v3 19/22] client: display channel migration

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- client/display_channel.cpp | 157 client/display_channel.h | 10 +++- 2 files changed, 153 insertions(+), 14 deletions(-) diff --git a/client/display_channel.cpp b/client/display_channel.cpp index 6127a96..e6b1a

[Spice-devel] [PATCH v3 18/22] client: playback/record channels: implement on_disconnect

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- client/audio_channels.h | 12 ++-- client/playback_channel.cpp | 22 -- client/record_channel.cpp | 39 --- 3 files changed, 54 insertions(+), 19 deletions(-) diff --git a/client/audio_

[Spice-devel] [PATCH v3 17/22] client: main channel migration: do partial cleanup when switching hosts

2011-09-25 Thread Yonit Halperin
Implement on_disconnect_mig_src and on_connect_mig_target in order to avoid unnecessary cleanups done in on_(disconnet|connect). In addition, do not request guest display settings changes after migration. Signed-off-by: Yonit Halperin --- client/red_client.cpp |9 + client/red_client

[Spice-devel] [PATCH v3 16/22] client: handle SPICE_MSG_MAIN_MIGRATE_END

2011-09-25 Thread Yonit Halperin
(1) disconnect all channels from the migration src (2) after all channels are disconnected, clean global resources (3) send SPICE_MSGC_MAIN_MIGRATE_END to migration target (4) wait for SPICE_MSG_MAIN_INIT (4) switch all channels to migration target Signed-off-by: Yonit Halperin --- client/red_ch

[Spice-devel] [PATCH v3 15/22] client: handle SpiceMsgMainMigrationBegin for 0.8.2

2011-09-25 Thread Yonit Halperin
RHBZ 725009, 738270 Signed-off-by: Yonit Halperin --- client/red_client.cpp | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/client/red_client.cpp b/client/red_client.cpp index d7a3e6a..f09e3c9 100644 --- a/client/red_client.cpp +++ b/client/red_clien

[Spice-devel] [PATCH v3 14/22] client: RedPeer::HostAuthOptions::set_cert_subject

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- client/application.cpp | 57 ++-- client/red_peer.cpp| 51 ++ client/red_peer.h |2 +- 3 files changed, 59 insertions(+), 51 deletions(-) diff --git a/client/ap

[Spice-devel] [PATCH v3 13/22] client: rewrite surfaces cache

2011-09-25 Thread Yonit Halperin
use std::map instead of a specific template (CHash). There is no need for special template. Moreover, using std::map will allow easy iteration over the surfaces. Signed-off-by: Yonit Halperin --- client/canvas.cpp | 25 +++- client/canvas.h| 152 --

[Spice-devel] [PATCH v3 12/22] server: fall back to switch host scheme in case semi-seamless connection to target fails

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/reds.c | 26 +- 1 files changed, 17 insertions(+), 9 deletions(-) diff --git a/server/reds.c b/server/reds.c index 8ee002f..10d2ffc 100644 --- a/server/reds.c +++ b/server/reds.c @@ -283,6 +283,7 @@ typedef struct RedsState {

[Spice-devel] [PATCH v3 11/22] server: turn spice_server_migrate_start into a valid call

2011-09-25 Thread Yonit Halperin
We will add a qemu call to spice_server_migrate_start when migration starts. For now, it does nothing, but we may need this notification in the future. Signed-off-by: Yonit Halperin --- server/reds.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/server/reds.c b/

[Spice-devel] [PATCH v3 10/22] server: call migrate_connect_complete callback when no client is connected

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/reds.c | 72 ++--- 1 files changed, 43 insertions(+), 29 deletions(-) diff --git a/server/reds.c b/server/reds.c index 0f67a95..e61751d 100644 --- a/server/reds.c +++ b/server/reds.c @@ -761,6 +761,7

[Spice-devel] [PATCH v3 09/22] server: handling semi-seamless migration in the target side

2011-09-25 Thread Yonit Halperin
(1) not sending anything to the client till we recieve SPICE_MSGC_MIGRATE_END (2) start a new migration (handle client_migrate_info) only after SPICE_MSGC_MIGRATE_END from the previous migration has been received (3) use the correct ticket Note: we assume the same channles are linked before a

[Spice-devel] [PATCH v3 08/22] server: move the linking of channels to a separate routine

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/reds.c | 67 ++-- 1 files changed, 41 insertions(+), 26 deletions(-) diff --git a/server/reds.c b/server/reds.c index 8ed84a8..6e7b891 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2612,12 +2612,

[Spice-devel] [PATCH v3 07/22] server: move SPICE_MSG_MAIN_INIT sending code to a separate routine

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/reds.c | 56 +--- 1 files changed, 33 insertions(+), 23 deletions(-) diff --git a/server/reds.c b/server/reds.c index 4ffdfb2..8ed84a8 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2078,6 +2078,3

[Spice-devel] [PATCH v3 06/22] server: send SPICE_MSG_MAIN_MIGRATE_END on spice_server_migrate_end

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/reds.c | 85 + 1 files changed, 67 insertions(+), 18 deletions(-) diff --git a/server/reds.c b/server/reds.c index 845b0ee..4ffdfb2 100644 --- a/server/reds.c +++ b/server/reds.c @@ -275,6 +275,7

[Spice-devel] [PATCH v3 05/22] spice.proto: add SPICE_MSG_MAIN_MIGRATE_END & SPICE_MSGC_MAIN_MIGRATE_END

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- spice.proto |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/spice.proto b/spice.proto index d5b954e..235ec95 100644 --- a/spice.proto +++ b/spice.proto @@ -219,6 +219,8 @@ channel MainChannel : BaseChannel { uint8 *cert_subject

[Spice-devel] [PATCH v3 04/22] server, proto: tell the client to connect to the migration target before migraton starts

2011-09-25 Thread Yonit Halperin
(1) send SPICE_MSG_MAIN_MIGRATE_BEGIN upon spice_server_migrate_connect (2) wait for SPICE_MSGC_MAIN_MIGRATE_(CONNECTED|CONNECT_ERROR), or a timeout, in order to complete client_migrate_info monitor command Signed-off-by: Yonit Halperin --- common/messages.h |2 + server/reds.c | 1

[Spice-devel] [PATCH v3 03/22] configure: spice-protocol >= 0.8.2 (semi-seamless migration protocol)

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 3a86515..e169f36 100644 --- a/configure.ac +++ b/configure.ac @@ -126,7 +126,7 @@ fi dnl ===

[Spice-devel] [PATCH v3 02/22] server: handle migration interface addition

2011-09-25 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/reds.c | 29 + server/reds.h |4 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/server/reds.c b/server/reds.c index 9a983f8..99d52f9 100644 --- a/server/reds.c +++ b/server/reds.c @@ -73,6 +73,7 @@ s

[Spice-devel] [PATCH v3 01/22] server/spice.h: semi-seamless migration interface, RHBZ #738266

2011-09-25 Thread Yonit Halperin
semi-seamless migration details: migration source side - (1) spice_server_migrate_connect (*): tell client to link to the target side - send SPICE_MSG_MAIN_MIGRATE_BEGIN. This should be called upon client_migrate_info cmd. client_migrate_info is asynchronous. (2) Co

[Spice-devel] [PATCH v3 00/22] semi-seamless migration client & server v3

2011-09-25 Thread Yonit Halperin
Changes from previous versions: * fix "server: fall back to switch host scheme in case semi-seamless": send switch-host msg only if migration completed successfully * client: initialize DisplayChannel::_mig_wait_primary * client: red_client: s/on_channel_disconnect_mig_src/on_channel_disconne

Re: [Spice-devel] vdagent\vdservice W 2008R2 guest under Fedora 15

2011-09-25 Thread Arnon Gilboa
Hi Sean, Remember to run cmd as Administrator. Is Z a network drive? put vdservice & vdagent on local drive. If it still fails, please send %windir\temp\vdservice.log & vdagent.log. Regarding the qxl driver, refer to the installing section in http://spice-space.org/page/WinQXL. Thanks, Arnon se

Re: [Spice-devel] [PATCH spice-server 08/13] server: move the linking of channels to a separate routine

2011-09-25 Thread Yonit Halperin
On 09/22/2011 05:01 PM, Alon Levy wrote: On Wed, Sep 21, 2011 at 06:51:18PM +0300, Yonit Halperin wrote: Signed-off-by: Yonit Halperin --- server/reds.c | 68 +++- 1 files changed, 42 insertions(+), 26 deletions(-) diff --git a/server/re