Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-09-05 Thread Ayal Baron
David / Yonit, Any update on this bug? - Original Message - > Hi, > > > One pretty fundamental issue here is that qemu doesn't accept any > > new > > connections while the migration is running. IIRC this applies only > > to > > the final stage where all device state is migrated. > > Wro

Re: [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote: > Hi, > > >I verified it still calls reds_stream_free from the worker thread, only > >now the call itself is done in red_channel.c (via red_channel_disconnect > >or something like that), which is called from red_worker.c > > Where t

Re: [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote: > Hi, > > >I verified it still calls reds_stream_free from the worker thread, only > >now the call itself is done in red_channel.c (via red_channel_disconnect > >or something like that), which is called from red_worker.c > > Where t

Re: [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Gerd Hoffmann
Hi, I verified it still calls reds_stream_free from the worker thread, only now the call itself is done in red_channel.c (via red_channel_disconnect or something like that), which is called from red_worker.c Where the code in red_channel.c is now shared for all channel types? Hmm. That mak

Re: [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 11:02:43AM +0200, Gerd Hoffmann wrote: > Hi, > > >Hi, > >RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that > >triggers red_disconnect_channel (and as a result, > >reds_stream_free(dispatcher->stream)). red_disconnect_channel is called > >also when there is

Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-09-05 Thread Yonit Halperin
On 08/26/2011 10:56 AM, Alon Levy wrote: On Thu, Aug 25, 2011 at 02:20:13PM +0300, Yonit Halperin wrote: On 08/25/2011 02:15 PM, Daniel P. Berrange wrote: On Thu, Aug 25, 2011 at 02:13:01PM +0300, Yonit Halperin wrote: On 08/25/2011 01:53 PM, Gerd Hoffmann wrote: I've played with a approach s

Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-09-05 Thread Gerd Hoffmann
Hi, race 2: target starts before it manages to restore the source pre-migration state (which was sent to it from the src server, via the client). solution: the target won't attach any spice device interface till it restores its state (with timeout). i.e., it will queue any request from the que

Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-09-05 Thread Yonit Halperin
On 08/26/2011 10:56 AM, Alon Levy wrote: On Thu, Aug 25, 2011 at 02:20:13PM +0300, Yonit Halperin wrote: On 08/25/2011 02:15 PM, Daniel P. Berrange wrote: On Thu, Aug 25, 2011 at 02:13:01PM +0300, Yonit Halperin wrote: On 08/25/2011 01:53 PM, Gerd Hoffmann wrote: I've played with a approach s

Re: [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Gerd Hoffmann
Hi, Hi, RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that triggers red_disconnect_channel (and as a result, reds_stream_free(dispatcher->stream)). red_disconnect_channel is called also when there is an error upon receive/send and also when timeouts related to the client occur (e

Re: [Spice-devel] [PATCH] monitor: Protect outbuf from concurrent access

2011-09-05 Thread Gerd Hoffmann
On 09/02/11 17:31, Paolo Bonzini wrote: On 09/02/2011 05:18 PM, Gerd Hoffmann wrote: Can you just use a bottom half to defer this work to the I/O thread? Bottom half scheduling has to be signal safe which means it will also be thread safe. Not that straight forward as I would have to pass ar

Re: [Spice-devel] spice-gtk segfault

2011-09-05 Thread Christophe Fergeau
Hey, On Mon, Sep 05, 2011 at 09:03:35AM +0200, nicolas prochazka wrote: > Hi, > I find it's due to my X configuration. > I'm using tiny X server with xvesa driver on thin client. > I think it is is not compatible with Randr extension => segfault. Ok, imo it should fail more gracefully if the ran

Re: [Spice-devel] [PATCH] server: fix function prototypes

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 07:54:04AM +0200, Christophe Fergeau wrote: > On Mon, Sep 05, 2011 at 08:20:55AM +0300, Alon Levy wrote: > > On Mon, Sep 05, 2011 at 03:19:50AM +0200, Christophe Fergeau wrote: > > > Several functions in server/ were not specifying an argument list, > > > ie they were declar

Re: [Spice-devel] Announcing spice 0.9.1 & spice-protocol 0.9.0

2011-09-05 Thread nicolas prochazka
Hi I'm sorry , I didn't read spice wiki compilation. It's ok for client . for 0.8.x it's just compilation time. Regards, NP 2011/9/5 Christophe Fergeau > Hey, > > On Fri, Sep 02, 2011 at 02:12:38PM +0200, nicolas prochazka wrote: > > spice 0.9.1 seems to be not compile on i686 architecture (

Re: [Spice-devel] spice-gtk / spice-0.9.1

2011-09-05 Thread nicolas prochazka
gcc --version gcc (SUSE Linux) 4.5.1 20101208 [gcc-4_5-branch revision 167585] Opensuse 11.4 I can compile on gentoo linux without problem. Regards, NP 2011/9/5 Christophe Fergeau > Hey, > > On Wed, Aug 31, 2011 at 10:30:46AM +0200, nicolas prochazka wrote: > > + When i'm trying to compile s

Re: [Spice-devel] spice-gtk segfault

2011-09-05 Thread nicolas prochazka
Hi, I find it's due to my X configuration. I'm using tiny X server with xvesa driver on thin client. I think it is is not compatible with Randr extension => segfault. ( same binary is ok on an other plateforme ) Regards, NP. 2011/9/5 Christophe Fergeau > Hey, > > On Wed, Aug 31, 2011 at 10: