On Fri, Sep 02, 2011 at 05:12:21PM +0200, Hans de Goede wrote:
> Hi,
>
> On 09/02/2011 03:41 PM, John A. Sullivan III wrote:
> >On Fri, 2011-09-02 at 13:49 +0300, Alon Levy wrote:
> >>On Thu, Sep 01, 2011 at 01:30:41PM -0400, John A. Sullivan III wrote:
> >>>On Thu, 2011-09-01 at 11:52 +0300, Alon
On Fri, Sep 02, 2011 at 05:19:54PM +0200, Gerd Hoffmann wrote:
> reds_stream_free() may call the channel_event callback which is not
> supposed to be callsed from worker thread context. This patch moves
> the reds_stream_free call for the display channel from the worker to
> the dispatcher to fix
On Fri, 02 Sep 2011 15:39:03 +0200
Gerd Hoffmann wrote:
>Hi,
>
> >> After some investigation, I found out that the problem is that different
> >> SPICE threads are calling monitor functions (such as
> >> monitor_protocol_event()) in parallel which causes concurrent access
> >> to the monitor
Hi
Can't we use BUILT_SOURCES:
http://sources.redhat.com/automake/automake.html#Sources
BUILT_SOURCES = spice-glib-enums.h spice-widget-enums.h spice-marshal.h
it works for me,
regards
--
Marc-André Lureau
- Original Message -
> Auto-generated files need explicit deps on them to ensur
ack
--
Marc-André Lureau
- Original Message -
> This is needed for usbredir support.
>
> Signed-off-by: Hans de Goede
> ---
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 98b91de..4550c8d 100644
> --- a/con
Auto-generated files need explicit deps on them to ensure things
are build in the right order when doing things like make -j200:
1) We had an explicit deps on spice-marshal.h, but only for spice-channel.c,
but others need it to
2) autogen.c files need autogen.h, note this is done in a separate m
This is needed for usbredir support.
Signed-off-by: Hans de Goede
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 98b91de..4550c8d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,7 +61,7 @@ AC_CHECK_HEADERS([sys/soc
On 09/02/2011 10:31 AM, Paolo Bonzini wrote:
On 09/02/2011 05:18 PM, Gerd Hoffmann wrote:
Can you just use a bottom half to defer this work to the I/O thread?
Bottom half scheduling has to be signal safe which means it will also be
thread safe.
Not that straight forward as I would have to pa
On 09/02/2011 05:18 PM, Gerd Hoffmann wrote:
Can you just use a bottom half to defer this work to the I/O thread?
Bottom half scheduling has to be signal safe which means it will also be
thread safe.
Not that straight forward as I would have to pass arguments to the
bottom half.
Can you add
On 09/02/2011 10:18 AM, Gerd Hoffmann wrote:
Hi,
A patch like the attached (warning: untested) should do as quick&dirty
fix for stable. But IMO we really should fix spice instead.
I agree. I'm not sure I like the idea of still calling QEMU code without
holding the mutex (even the QObject code
reds_stream_free() may call the channel_event callback which is not
supposed to be callsed from worker thread context. This patch moves
the reds_stream_free call for the display channel from the worker to
the dispatcher to fix this issue.
[ Note: not tested yet, against 0.8 branch, sending out fo
Hi,
A patch like the attached (warning: untested) should do as quick&dirty
fix for stable. But IMO we really should fix spice instead.
I agree. I'm not sure I like the idea of still calling QEMU code without
holding the mutex (even the QObject code).
I though just creating the objects isn'
Hi,
On 09/02/2011 03:41 PM, John A. Sullivan III wrote:
On Fri, 2011-09-02 at 13:49 +0300, Alon Levy wrote:
On Thu, Sep 01, 2011 at 01:30:41PM -0400, John A. Sullivan III wrote:
On Thu, 2011-09-01 at 11:52 +0300, Alon Levy wrote:
On Thu, Sep 01, 2011 at 09:59:14AM +0200, Christophe Fergeau wr
On 09/02/2011 08:39 AM, Gerd Hoffmann wrote:
Hi,
After some investigation, I found out that the problem is that different
SPICE threads are calling monitor functions (such as
monitor_protocol_event()) in parallel which causes concurrent access
to the monitor's internal buffer outbuf[].
[ addi
On 09/02/2011 08:39 AM, Gerd Hoffmann wrote:
Hi,
After some investigation, I found out that the problem is that different
SPICE threads are calling monitor functions (such as
monitor_protocol_event()) in parallel which causes concurrent access
to the monitor's internal buffer outbuf[].
[ addi
We need to undef _FORTIFY_SOURCE before our first include, so as to
avoid the extra checks it does on longjmp which don't play well with
our coroutine stuff.
Signed-off-by: Hans de Goede
---
gtk/continuation.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gtk/continua
On Fri, 2011-09-02 at 13:49 +0300, Alon Levy wrote:
> On Thu, Sep 01, 2011 at 01:30:41PM -0400, John A. Sullivan III wrote:
> > On Thu, 2011-09-01 at 11:52 +0300, Alon Levy wrote:
> > > On Thu, Sep 01, 2011 at 09:59:14AM +0200, Christophe Fergeau wrote:
> > > > Hi,
> > > >
> > > > On Thu, Aug 25,
Hi,
After some investigation, I found out that the problem is that different
SPICE threads are calling monitor functions (such as
monitor_protocol_event()) in parallel which causes concurrent access
to the monitor's internal buffer outbuf[].
[ adding spice-list to Cc, see qemu-devel for the
spice 0.9.1 seems to be not compile on i686 architecture ( 32 bits )
spice 0.8.x is ok for this architecture
cc1: warnings being treated as errors
main_channel.c: In function 'main_tokens_item_new':
main_channel.c:233:20: error: cast from pointer to integer of different size
main_channel.c: In fu
On Thu, Sep 01, 2011 at 01:30:41PM -0400, John A. Sullivan III wrote:
> On Thu, 2011-09-01 at 11:52 +0300, Alon Levy wrote:
> > On Thu, Sep 01, 2011 at 09:59:14AM +0200, Christophe Fergeau wrote:
> > > Hi,
> > >
> > > On Thu, Aug 25, 2011 at 03:44:58PM +0200, Hans de Goede wrote:
> > > > * Multi-c
On Fri, Sep 02, 2011 at 03:16:18PM +0800, Wang Zhi wrote:
> Hi,
>
>I tried kvm-spice on Ubuntu 11.04 x64, windows qxl driver (version
> 1.3.0.0) worked fine in xp guest, but cannot be installed in win7 32bit
> guest. I've git cloned the newest driver ( sys version 1.4.1.1) source from
Tha
On Wed, Aug 31, 2011 at 03:37:33PM +0300, Yonit Halperin wrote:
> if qxl_send_events was called from spice server context, and then
> migration had completed before a call to pipe_read, the target
> guest qxl driver didn't get the interrupt.
This is a general issue with interrupt migration, and PC
The autogenerated files are part of make dist, without these explicit
rules doing "./autogen.sh && make dist" on a clean git checkout
will fail because it wants them but does not know how to build them.
Signed-off-by: Hans de Goede
---
gtk/controller/Makefile.am |4
1 files changed, 4 i
automake is smart enough to add _SOURCES files to make dist's result even
if there compilation is depending on an AM conditional, and we are already
depending on this for the smartcard / usb files, so lets depend on it for
the other ones too.
Signed-off-by: Hans de Goede
---
gtk/Makefile.am |
We have various files which are auto-generated which currently get included
into the tarbal, yet they are part of CLEANFILES, so the first make clean
removes them, which is rather weird. Use nodist_foo_SOURCES to make them
not end up in the tarbal.
Except for generated_[de]marshallers[1].c, as aut
Hi,
I tried kvm-spice on Ubuntu 11.04 x64, windows qxl driver (version
1.3.0.0) worked fine in xp guest, but cannot be installed in win7 32bit
guest. I've git cloned the newest driver ( sys version 1.4.1.1) source from
freedesktop.org and compiled it, but it's just the same as older version
26 matches
Mail list logo