Re: [Spice-devel] Announcing spice 0.9.1 & spice-protocol 0.9.0

2011-09-01 Thread John A. Sullivan III
On Thu, 2011-09-01 at 11:52 +0300, Alon Levy wrote: > On Thu, Sep 01, 2011 at 09:59:14AM +0200, Christophe Fergeau wrote: > > Hi, > > > > On Thu, Aug 25, 2011 at 03:44:58PM +0200, Hans de Goede wrote: > > > * Multi-client support, disabled by default (experimental!) set the > > > environment var

[Spice-devel] Question about Video and multi media time

2011-09-01 Thread Andrea Celestino
Hi, On the client side spice handles stream data using multi media time. How is calculated this multi media time??There is spice_session_get_mm_time() that calculates this time but I don't understand how is calculated. Each stream data have a member called multi_media_time, this member is initializ

Re: [Spice-devel] [PATCH spice-gtk] spice_usb_device_get_description fixups

2011-09-01 Thread Marc-André Lureau
ack On Thu, Sep 1, 2011 at 4:42 PM, Hans de Goede wrote: > 1) Fix spice_usb_device_get_description compilation when building without >   usb support > 2) Don't return "Unknown" when the device param is NULL, the caller should >   g_free the returned string, so we cannot return a const string > 3)

[Spice-devel] [PATCH spice-gtk] spice_usb_device_get_description fixups

2011-09-01 Thread Hans de Goede
1) Fix spice_usb_device_get_description compilation when building without usb support 2) Don't return "Unknown" when the device param is NULL, the caller should g_free the returned string, so we cannot return a const string 3) Fix the existing callers to actually g_free the result of spice

Re: [Spice-devel] WinQXL: PREfast analysis errors and warnings

2011-09-01 Thread Yaniv Kaul
On 09/01/2011 03:07 PM, nicolas prochazka wrote: Hello, I just compile winqxl from git tree without error or warning I use 7600.16385.1 winDDK Regards, Nicolas It's from the Auto Code Review, which is part of the DDK. I'm not getting errors as part of the compilation. It's in a balloon in th

Re: [Spice-devel] WinQXL: PREfast analysis errors and warnings

2011-09-01 Thread nicolas prochazka
Hello, I just compile winqxl from git tree without error or warning I use 7600.16385.1 winDDK Regards, Nicolas 2011/9/1 Yaniv Kaul > Has anyone looked at the warning and errors PREfast (from MS DDK) produces? > > - driver.c(111): usage of _snprintf banned API > - driver.c(112): usage of _vsnpri

[Spice-devel] [PATCH spice-gtk 3/3] usbredir: provide out own libusb_strerror for now

2011-09-01 Thread Hans de Goede
libusb_strerror is not going upstream because of i18n worries, provide our own for now. Signed-off-by: Hans de Goede --- gtk/Makefile.am |4 ++- gtk/channel-usbredir.c |6 +--- gtk/gusb/gusb-context.c |6 +--- gtk/gusb/gusb-source.c |6 +--- gtk/gusb/gusb-util.c|

[Spice-devel] [PATCH spice-gtk 2/3] usb-device-manager: Add a auto-connect-failed signal

2011-09-01 Thread Hans de Goede
And use it in spicy to inform users of auto redirect failures (usually due to insufficient rights on the /dev/bus/usb device nodes). Signed-off-by: Hans de Goede --- gtk/spice-marshal.txt|1 + gtk/spicy.c | 24 gtk/usb-device-manager.c | 24 +

[Spice-devel] [PATCH spice-gtk 1/3] usb-device-manager: Add a spice_usb_device_get_description() method

2011-09-01 Thread Hans de Goede
This is just a place holder for now. A better implementation requires gusb changes, and I hope there will be an official gusb release by the time I get around to fixing this up. Signed-off-by: Hans de Goede --- doc/reference/spice-gtk-sections.txt |1 + gtk/map-file |

[Spice-devel] WinQXL: PREfast analysis errors and warnings

2011-09-01 Thread Yaniv Kaul
Has anyone looked at the warning and errors PREfast (from MS DDK) produces? - driver.c(111): usage of _snprintf banned API - driver.c(112): usage of _vsnprintf banned API - driver.c(387): 'video_buff' could be '0' and is a copy of the value found in 'selected_mode'. See line 358 for an earlier l

Re: [Spice-devel] [PATCH spice-gtk 4/4] usbredir: provide out own libusb_strerror for now

2011-09-01 Thread Hans de Goede
Hi, On 08/31/2011 03:57 PM, Marc-André Lureau wrote: Hi - This function needs to be protected by #ifdef USE_USBREDIR - Could the string made translatable? if not why? Currently we don't do any translations in spice-gtk at all, try adding a _() around any string, last time I tried it failed wi

Re: [Spice-devel] Announcing spice 0.9.1 & spice-protocol 0.9.0

2011-09-01 Thread Alon Levy
On Thu, Sep 01, 2011 at 09:59:14AM +0200, Christophe Fergeau wrote: > Hi, > > On Thu, Aug 25, 2011 at 03:44:58PM +0200, Hans de Goede wrote: > > * Multi-client support, disabled by default (experimental!) set the > > environment variable SPICE_DEBUG_ALLOW_MC before starting qemu to enable > > D

Re: [Spice-devel] [PATCH spice 2/5] usbredir: Ensure that our msg_rcv_buf is not used re-entrantly

2011-09-01 Thread Hans de Goede
Hi, On 09/01/2011 10:01 AM, Christophe Fergeau wrote: On Thu, Aug 25, 2011 at 12:19:54PM +0200, Hans de Goede wrote: +assert(!state->rcv_buf_in_use); + There's an ASSERT macro defined in common/spice_common.h Right, and that only actually asserts when doing debug builds, iow almost neve

Re: [Spice-devel] [PATCH spice 2/5] usbredir: Ensure that our msg_rcv_buf is not used re-entrantly

2011-09-01 Thread Christophe Fergeau
On Thu, Aug 25, 2011 at 12:19:54PM +0200, Hans de Goede wrote: > +assert(!state->rcv_buf_in_use); > + There's an ASSERT macro defined in common/spice_common.h Christophe pgp3Ien7khMDv.pgp Description: PGP signature ___ Spice-devel mailing list Spi

Re: [Spice-devel] Announcing spice 0.9.1 & spice-protocol 0.9.0

2011-09-01 Thread Christophe Fergeau
Hi, On Thu, Aug 25, 2011 at 03:44:58PM +0200, Hans de Goede wrote: > * Multi-client support, disabled by default (experimental!) set the > environment variable SPICE_DEBUG_ALLOW_MC before starting qemu to enable Do we have documentation explaining what multiclient is, and how to use it? I think