All 3 Look good to me.
ACK series.
Regards,
Hans
On 08/12/2011 06:03 PM, Christophe Fergeau wrote:
Even if VDAgentDisplayConfig::depth will be unused if the
VD_AGENT_DISPLAY_CONFIG_FLAG_SET_COLOR_DEPTH isn't set, it's
better to initialize it anyway to avoid warnings from valgrind.
---
clie
On Thu, Aug 11, 2011 at 09:45:40AM +0200, Hans de Goede wrote:
> Hi,
>
> On 08/11/2011 08:33 AM, Alon Levy wrote:
>
>
>
> >>+static void usbredir_chardev_wakeup(SpiceCharDeviceInstance *sin)
> >>+{
> >>+UsbRedirState *state;
> >>+SpiceCharDeviceInterface *sif;
> >>+int n;
> >>+
> >>
---
client/x11/platform.cpp |1 +
client/x11/red_window.cpp | 11 +++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp
index 609898a..2b2dfa8 100644
--- a/client/x11/platform.cpp
+++ b/client/x11/platform.cpp
@@ -2967,
---
client/red_channel.cpp | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/client/red_channel.cpp b/client/red_channel.cpp
index 5f8bd25..8632600 100644
--- a/client/red_channel.cpp
+++ b/client/red_channel.cpp
@@ -71,10 +71,7 @@ void RedChannelBase::link(uint32_t
Even if VDAgentDisplayConfig::depth will be unused if the
VD_AGENT_DISPLAY_CONFIG_FLAG_SET_COLOR_DEPTH isn't set, it's
better to initialize it anyway to avoid warnings from valgrind.
---
client/red_client.cpp |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/client/red_clien
This fixes alt getting stuck in the guest when the user alt-tabs away from the
spice-widget (thus making it see the alt press but not the release) and then
closing it without giving it the focus back (by using the windows close button
for example).
Note that doing this on focus out (when we know w
With the filtering of focus in / out events caused by grabs we should no
longer need this.
Signed-off-by: Hans de Goede
---
gtk/spice-widget-priv.h |2 --
gtk/spice-widget.c | 17 -
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/gtk/spice-widget-priv.h
As documented in XGrabKeyboard(3): "The XGrabKeyboard function actively grabs
control of the keyboard and generates FocusIn and FocusOut events."
Note that for some reason this only happens when we call XGrabKeyboard
from our enter_event / leave_event callbacks and not from our focus_in /
focus_ou
---
gtk/spice-widget-priv.h |1 +
gtk/spice-widget.c | 36
gtk/spicy.c |8 +++-
3 files changed, 44 insertions(+), 1 deletions(-)
diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h
index 3711aaa..5527ebc 100644
--- a/
Signed-off-by: Hans de Goede
---
gtk/Makefile.am |3 +
gtk/map-file |8 +
gtk/spice-client-gtk.defs | 79
gtk/spice-client.h|1 +
gtk/spice-widget.c| 21 ++
gtk/usb-device-manager.c | 459 +++
Signed-off-by: Hans de Goede
---
configure.ac|1 +
gtk/Makefile.am |6 +
gtk/channel-usbredir-priv.h | 43 ++
gtk/channel-usbredir.c | 353 +++
gtk/channel-usbredir.h | 60
gtk/map-file
While working on usb redirection support for spice-gtk I needed some
code to integrate libusb into glib's mainloop amongst other things. I ended
up borrowing code from colord for this. Richard (the colord author) and I
quickly agreed that doing generic glib bindings for libusb is a good idea,
akin
Signed-off-by: Hans de Goede
---
spice.proto |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/spice.proto b/spice.proto
index 4c072ed..748ae95 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1173,6 +1173,13 @@ channel SmartcardChannel : BaseChannel {
} @ctype(VS
Our disconnect handler clears the common_caps array so that a new
connection starts with a clean slate. But in our constructor we set
the SPICE_COMMON_CAP_PROTOCOL_AUTH_SELECTION in common_caps as starting
cap. Do the same on disconnect, so the behavior of a re-using a channel
after disconnect is t
Fix a race between spice_channel_buffered_write and
spice_channel_iterate_write.
Signed-off-by: Hans de Goede
---
gtk/spice-channel.c | 17 +++--
1 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index 8834143..f367b4d 100644
On 12 August 2011 14:53, Alon Levy wrote:
> On Fri, Aug 12, 2011 at 11:17:49AM +0100, Damien Churchill wrote:
>> Hi,
>>
>> Is there anyway to stop libvirt from adding multifunction=on to a
>> second qxl device? Is this a libvirt or qxl bug?
>
> qxl drivers (*) do not handle multifunction=on correc
On Fri, Aug 12, 2011 at 04:53:04PM +0300, Alon Levy wrote:
> I don't know when libvirt started adding mf=on.
For what it's worth, this was added in
commit 9f8baf646ea44aa2de47cba5002af39a7ab1ac08
Author: Wen Congyang
Date: Mon May 23 14:42:21 2011 +0800
support multifunction PCI device
On Fri, Aug 12, 2011 at 11:17:49AM +0100, Damien Churchill wrote:
> Hi,
>
> Is there anyway to stop libvirt from adding multifunction=on to a
> second qxl device? Is this a libvirt or qxl bug?
qxl drivers (*) do not handle multifunction=on correctly. I believe they never
have.
I don't know when
Hi,
Is there anyway to stop libvirt from adding multifunction=on to a
second qxl device? Is this a libvirt or qxl bug?
Thanks,
Damien
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-deve
19 matches
Mail list logo
