[Spice-devel] patch (RFC) - remove redundant calls to EngAcquireSemaphore/EngReleaseSemaphore in Windows' QXL display/res.c

2011-07-31 Thread Yaniv Kaul
As correctly documented before the function, it is only called when the semaphore is held, therefore no need to acquire nor release it: diff --git a/display/res.c b/display/res.c index 5d28184..df0ddba 100644 --- a/display/res.c +++ b/display/res.c @@ -1510,12 +1510,10 @@ static void ImageCache

Re: [Spice-devel] [PATCH v2] server/red_dispatcher: fix wrong resolution set for tablet

2011-07-31 Thread Alon Levy
On Sun, Jul 31, 2011 at 04:52:43PM +0300, Arnon Gilboa wrote: > ack, although I did not really get why the ref got broken. > Me neither :/ But it does fix the problem. > Alon Levy wrote: > >when changing resolutions due to the new async code paths the surface > >creation command was kept by refe

[Spice-devel] Failure to ./configure QXL (under F15/x64 VM, already running QXL driver)

2011-07-31 Thread Yaniv Kaul
I'm trying to move QXL driver to compile under the VM it will run on. ./configure fails with: /./configure: line 11867: syntax error near unexpected token `RANDR,' //./configure: line 11867: `XORG_DRIVER_CHECK_EXT(RANDR, randrproto)' / Sounds like http://nouveau.freedesktop.org/wiki/TroubleSh

Re: [Spice-devel] [PATCH v2] server/red_dispatcher: fix wrong resolution set for tablet

2011-07-31 Thread Arnon Gilboa
ack, although I did not really get why the ref got broken. Alon Levy wrote: when changing resolutions due to the new async code paths the surface creation command was kept by reference, and later, when the red_worker signaled completion by calling async_complete the mouse mode was updated using

[Spice-devel] [PATCH v2] server/red_dispatcher: fix wrong resolution set for tablet

2011-07-31 Thread Alon Levy
when changing resolutions due to the new async code paths the surface creation command was kept by reference, and later, when the red_worker signaled completion by calling async_complete the mouse mode was updated using the reference. This caused the wrong values to be read resulting in wrong resol

[Spice-devel] [PATCH] server/red_dispatcher: fix wrong resolution set for tablet

2011-07-31 Thread Alon Levy
when changing resolutions due to the new async code paths the surface creation command was kept by reference, and later, when the red_worker signaled completion by calling async_complete the mouse mode was updated using the reference. This caused the wrong values to be read resulting in wrong resol

Re: [Spice-devel] [PATCH] common/backtrace.h: disable for WIN32

2011-07-31 Thread Arnon Gilboa
ack Alon Levy wrote: This also catches mingw32 which is probably fine, but at least it fixes the build on visual studio. --- common/backtrace.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/common/backtrace.h b/common/backtrace.h index 3b0c132..21b6b67 100644 --- a