Re: [Spice-devel] Win7 Guest system hangs while doing shutdown...

2011-07-21 Thread Yaniv Kaul
On 22/07/2011 03:41, Naga Mohan Pothula wrote: Hi, Launched windows7 Guest image with Spice v0.8 in fullscreen mode with auto-config from windows client. Spice window hangs frequently while doing shutdown or restart. if it doesn't hang then shutdown process is slow. This issue doesn't happen

[Spice-devel] Win7 Guest system hangs while doing shutdown...

2011-07-21 Thread Naga Mohan Pothula
Hi, Launched windows7 Guest image with Spice v0.8 in fullscreen mode with auto-config from windows client. Spice window hangs frequently while doing shutdown or restart.  if it doesn't hang then shutdown process is slow. This issue doesn't happen if we don't launch in full-screen mode.  I thou

Re: [Spice-devel] [PATCH 2/2] client: don't die if initial agent timeout triggers

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 05:43:17PM +0200, Christophe Fergeau wrote: > When the client connects to a spice VM, if an agent is detected, > there will be a few messages exchanged to exchange capabilities, > display resolutions, ... This exchange has a timeout in case > something goes wrong. However, w

Re: [Spice-devel] [PATCH 1/4] add SASL and smartcard to distcheck flags

2011-07-21 Thread Hans de Goede
Ack series. On 07/21/2011 06:49 PM, Christophe Fergeau wrote: --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 853ffea..f8cfe25 100644 --- a/Makefile.am +++ b/Makefile.am @@ -12,4 +12,4 @@ DISTCLEANFILES =

Re: [Spice-devel] agent channel behavior in case of unexpected client / agent close

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 07:15:41PM +0200, Gerd Hoffmann wrote: > Hi, > > >>So all in all enabling open / close event for the agent channel > >>is a BAD (tm) idea. However as stated in the start for usbredir > >>actually getting client connect / disconnect events is desirable, > >>so that usbredi

[Spice-devel] [PATCH 3/4] fix make distcheck

2011-07-21 Thread Christophe Fergeau
--- client/smartcard_channel.cpp |2 +- common/backtrace.c |2 +- server/Makefile.am |9 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/client/smartcard_channel.cpp b/client/smartcard_channel.cpp index e0e9b88..11a6be0 100644 --- a/client/s

[Spice-devel] [PATCH 2/4] configure.ac: fix pyparsing check

2011-07-21 Thread Christophe Fergeau
2>&1 was typo'ed 2&>1 which caused an empty '1' file to be created when running this test. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index cb0ca99..feed8a1 100644 --- a/configure.ac +++ b/configure.ac @@ -217,7 +217,7 @@

[Spice-devel] [PATCH 4/4] set version number to 0.9.0

2011-07-21 Thread Christophe Fergeau
--- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index feed8a1..486e323 100644 --- a/configure.ac +++ b/configure.ac @@ -1,8 +1,8 @@ AC_PREREQ([2.57]) m4_define([SPICE_MAJOR], 0) -m4_define([SPICE_MINOR], 6) -m4_define([SP

[Spice-devel] [PATCH 1/4] add SASL and smartcard to distcheck flags

2011-07-21 Thread Christophe Fergeau
--- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 853ffea..f8cfe25 100644 --- a/Makefile.am +++ b/Makefile.am @@ -12,4 +12,4 @@ DISTCLEANFILES =\ EXTRA_DIST = spice.proto spice1.proto spice_c

Re: [Spice-devel] agent channel behavior in case of unexpected client / agent close

2011-07-21 Thread Gerd Hoffmann
Hi, So all in all enabling open / close event for the agent channel is a BAD (tm) idea. However as stated in the start for usbredir actually getting client connect / disconnect events is desirable, so that usbredir can reset its parser to start fresh with the new client. And so that ic can "un

Re: [Spice-devel] [PATCH 1/2] client: only send one SPICE_MSGC_MAIN_ATTACH_CHANNELS messages

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 05:43:16PM +0200, Christophe Fergeau wrote: > 492f7a9b fixed unwanted timeouts during initial client startup, > but it also caused a bad regression when connecting to > RHEL6+agent guests: the SPICE_MSGS_MAIN_ATTACH_CHANNELS message > was sent multiple times, once in RedClie

[Spice-devel] [PATCH 1/2] client: only send one SPICE_MSGC_MAIN_ATTACH_CHANNELS messages

2011-07-21 Thread Christophe Fergeau
492f7a9b fixed unwanted timeouts during initial client startup, but it also caused a bad regression when connecting to RHEL6+agent guests: the SPICE_MSGS_MAIN_ATTACH_CHANNELS message was sent multiple times, once in RedClient::handle_init, then once again in RedClient::on_agent_announce_capabilitie

[Spice-devel] [PATCH 2/2] client: don't die if initial agent timeout triggers

2011-07-21 Thread Christophe Fergeau
When the client connects to a spice VM, if an agent is detected, there will be a few messages exchanged to exchange capabilities, display resolutions, ... This exchange has a timeout in case something goes wrong. However, when it fires, the client dies. This commit changes this and lets the client

Re: [Spice-devel] agent channel behavior in case of unexpected client / agent close

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 02:16:06PM +0200, Hans de Goede wrote: > Hi All, > > I would like to add support for the state callback of SpiceCharDeviceInterface > to spice-qemu-char.c, because I need it for ubsredir support. > > There already is code in spice-server which will call this if defined, an

[Spice-devel] agent channel behavior in case of unexpected client / agent close

2011-07-21 Thread Hans de Goede
Hi All, I would like to add support for the state callback of SpiceCharDeviceInterface to spice-qemu-char.c, because I need it for ubsredir support. There already is code in spice-server which will call this if defined, and this code lives in reds.c and has to do with the agent channel. This ha

Re: [Spice-devel] 0.10.x status / plans for spice for Fedora 16

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 07:06:50AM -0400, John A. Sullivan III wrote: > On Thu, 2011-07-21 at 12:50 +0300, Alon Levy wrote: > > On Thu, Jul 21, 2011 at 11:36:39AM +0200, Hans de Goede wrote: > > > Hi All, > > > > > > *bump* > > > > > > I think it is still not sure what the plan is. AFAIK we're a

Re: [Spice-devel] 0.10.x status / plans for spice for Fedora 16

2011-07-21 Thread John A. Sullivan III
On Thu, 2011-07-21 at 12:50 +0300, Alon Levy wrote: > On Thu, Jul 21, 2011 at 11:36:39AM +0200, Hans de Goede wrote: > > Hi All, > > > > *bump* > > > > I think it is still not sure what the plan is. AFAIK we're almost > > done with getting a 0.8.2 which has the async + s3 patches in out the door

Re: [Spice-devel] 0.10.x status / plans for spice for Fedora 16

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 11:36:39AM +0200, Hans de Goede wrote: > Hi All, > > *bump* > > I think it is still not sure what the plan is. AFAIK we're almost > done with getting a 0.8.2 which has the async + s3 patches in out the door. > > I assume the async + s3 patches will go to master too at the

Re: [Spice-devel] 0.10.x status / plans for spice for Fedora 16

2011-07-21 Thread Hans de Goede
Hi All, *bump* I think it is still not sure what the plan is. AFAIK we're almost done with getting a 0.8.2 which has the async + s3 patches in out the door. I assume the async + s3 patches will go to master too at the same time as they go to the 0.8 branch. I think after that it would be good t

Re: [Spice-devel] [PATCH] client: fix endless recursion in rearrange_monitors, RHBZ #692976

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 10:07:57AM +0300, Yonit Halperin wrote: > I changed RedScreen::resize not to call rearrange_monitors. Instead, > the monitor should be configured correctly from Application, before > calling resize. > In addition, I made some cleanups to allow reusing rearrange_monitors code

Re: [Spice-devel] [PATCH] client: fix endless recursion in rearrange_monitors, RHBZ #692976

2011-07-21 Thread Yonit Halperin
Hi, forgot to mention that the endless recursion happened due to Application::prepare_monitors calling RedScreen::resize calling Application::rearrange_monitors calling Application::prepare_monitors I will change the commit message. On 07/21/2011 10:07 AM, Yonit Halperin wrote: I changed Red

[Spice-devel] [PATCH] client: fix endless recursion in rearrange_monitors, RHBZ #692976

2011-07-21 Thread Yonit Halperin
I changed RedScreen::resize not to call rearrange_monitors. Instead, the monitor should be configured correctly from Application, before calling resize. In addition, I made some cleanups to allow reusing rearrange_monitors code. --- client/application.cpp | 94 +--