Re: [Spice-devel] Our current open issues

2011-07-20 Thread John A. Sullivan III
On Tue, 2011-07-19 at 22:31 -0400, John A. Sullivan III wrote: > Hello, all. I know I've raised a large number of issues over the last > few weeks most of which are still open. I'd like to summarize them here > and ask for your direction on how we can further troubleshoot and > resolve them, in

Re: [Spice-devel] Unfair comparisons with RDP

2011-07-20 Thread John A. Sullivan III
On Tue, 2011-07-19 at 22:05 -0400, John A. Sullivan III wrote: > On Mon, 2011-07-04 at 21:07 +0300, Yaniv Kaul wrote: > > On 07/04/2011 07:33 PM, John A. Sullivan III wrote: > > > On Mon, 2011-07-04 at 17:48 +0300, Yonit Halperin wrote: > > >> On 07/04/2011 05:21 PM, John A. Sullivan III wrote: >

Re: [Spice-devel] Spice QXL Driver does not work for Windows 7

2011-07-20 Thread John A. Sullivan III
On Wed, 2011-07-20 at 12:04 +0200, Mario wrote: > > I was finally able to get them to work. Here is what I did under > > both > > W7 and W2K8: > > Download and install the WinQual toolkit: > > > > https://winqual.microsoft.com/member/SubmissionWizard/controls/WinqualSubmissionTool.msi > > This i

[Spice-devel] [PATCH] common/backtrace.h: disable for WIN32

2011-07-20 Thread Alon Levy
This also catches mingw32 which is probably fine, but at least it fixes the build on visual studio. --- common/backtrace.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/common/backtrace.h b/common/backtrace.h index 3b0c132..21b6b67 100644 --- a/common/backtrace.h +++

Re: [Spice-devel] Our current open issues

2011-07-20 Thread John A. Sullivan III
On Wed, 2011-07-20 at 10:13 +0300, Yaniv Kaul wrote: > On 07/20/2011 05:31 AM, John A. Sullivan III wrote: > > Hello, all. I know I've raised a large number of issues over the last > > few weeks most of which are still open. I'd like to summarize them here > > and ask for your direction on how we

Re: [Spice-devel] About libcacard and spice-gtk license.

2011-07-20 Thread Liang Guo
> > The next libcacard that will be released will be based on qemu/libcacard, > which > is what's being worked on. I think it has copyright headers on each file. > Yes, They have -- Liang GUO http://bluestone.cublog.cn ___ Spice-devel mailing list Spi

Re: [Spice-devel] About libcacard and spice-gtk license.

2011-07-20 Thread Alon Levy
On Wed, Jul 20, 2011 at 08:16:34PM +0800, Liang Guo wrote: > Hi, Christophe > > On Wed, Jul 20, 2011 at 5:06 PM, Christophe Fergeau > wrote: > > Hi Liang, > > > > On Wed, Jul 20, 2011 at 04:45:33PM +0800, Liang Guo wrote: > >> Libcacard is licensed under GPL3, spice-gtk is licensed under LGPL2.1

Re: [Spice-devel] About libcacard and spice-gtk license.

2011-07-20 Thread Christophe Fergeau
On Wed, Jul 20, 2011 at 08:16:34PM +0800, Liang Guo wrote: > Thank you for your reply, will these two licacard be merged ? it is not > nessary > to have two library do the same thing and have the same name. The standalone libcacard is to be considered as deprecated, qemu git can now install libca

Re: [Spice-devel] About libcacard and spice-gtk license.

2011-07-20 Thread Liang Guo
Hi, Christophe On Wed, Jul 20, 2011 at 5:06 PM, Christophe Fergeau wrote: > Hi Liang, > > On Wed, Jul 20, 2011 at 04:45:33PM +0800, Liang Guo wrote: >> Libcacard is licensed under GPL3, spice-gtk is licensed under LGPL2.1, >> but spice-gtk may call libcacard, Should this cause any legal problem >

Re: [Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Christophe Fergeau
On Wed, Jul 20, 2011 at 12:53:14PM +0300, Alon Levy wrote: > > But maybe that's something kraxel wanted to avoid. > > > > I dunno, both would work. None look particularily pretty. Do you mind > if I don't do another rewrite? I'm just worried about things going bad down the road. Ie some of the p

Re: [Spice-devel] [PATCH 0.8] spicec: Make loglevel configurable through the environment

2011-07-20 Thread Alon Levy
On Wed, Jul 20, 2011 at 01:43:42PM +0200, Hans de Goede wrote: > Having a loglevel variable is much more useful if we can actually change > its value without a recompile. Use a SPICEC_LOG_LEVEL environment variable so > we can do this from the spice xpi / activex too (by setting the environment > v

[Spice-devel] [PATCH 0.8] spicec: Make loglevel configurable through the environment

2011-07-20 Thread Hans de Goede
Having a loglevel variable is much more useful if we can actually change its value without a recompile. Use a SPICEC_LOG_LEVEL environment variable so we can do this from the spice xpi / activex too (by setting the environment variable before starting the browser). --- client/application.cpp |

Re: [Spice-devel] RFC: spice plans for usb-redir + needed spice-server API extensions

2011-07-20 Thread Hans de Goede
Hi, On 07/19/2011 05:46 PM, Gerd Hoffmann wrote: Hi, 3) spice server asks qemu to dynamically create a new spicevmc chardev + usb-redir device couple (this is the part that needs the API extension). That isn't going to fly. Then you'll have magic usb devices on the usb bus libvirt doesn't k

Re: [Spice-devel] Spice QXL Driver does not work for Windows 7

2011-07-20 Thread Mario
I was finally able to get them to work. Here is what I did under both W7 and W2K8: Download and install the WinQual toolkit: https://winqual.microsoft.com/member/SubmissionWizard/controls/WinqualSubmissionTool.msi This is to obtain Inf2Cat.exe Download and install the MS SDK: http://www.micros

[Spice-devel] [PATCH V2] client: log formatted time (#674013)

2011-07-20 Thread Uri Lublin
V2 changes: moved get_timestamp into the if() condition. initialize ts[0]='\0' before calling get_timestamp. --- client/application.cpp | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 606f7e2..f628

Re: [Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Alon Levy
On Wed, Jul 20, 2011 at 11:33:39AM +0200, Christophe Fergeau wrote: > On Wed, Jul 20, 2011 at 12:10:07PM +0300, Alon Levy wrote: > > On Wed, Jul 20, 2011 at 10:53:49AM +0200, Christophe Fergeau wrote: > > > On Wed, Jul 20, 2011 at 11:19:52AM +0300, Alon Levy wrote: > > > > -static void qxl_worker_u

Re: [Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Gerd Hoffmann
Ok, I'd have gone with using these to implement spice_qxl_wakeup et al: void spice_qxl_wakeup(QXLInstance *instance) { QXLWorker *worker = (QXLWorker *)instance->st->dispatcher; QXLWorker *worker = &instance->st->dispatcher->base; avoids the cast. ASSERT(worker->wakeup != NULL)

Re: [Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Gerd Hoffmann
diff --git a/server/spice.h b/server/spice.h index f64ff41..86d9ffe 100644 --- a/server/spice.h +++ b/server/spice.h @@ -124,6 +124,25 @@ struct QXLWorker { void (*loadvm_commands)(QXLWorker *worker, struct QXLCommandExt *ext, uint32_t count); }; Will the function pointer above go away?

Re: [Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Christophe Fergeau
On Wed, Jul 20, 2011 at 12:10:07PM +0300, Alon Levy wrote: > On Wed, Jul 20, 2011 at 10:53:49AM +0200, Christophe Fergeau wrote: > > On Wed, Jul 20, 2011 at 11:19:52AM +0300, Alon Levy wrote: > > > -static void qxl_worker_update_area(QXLWorker *qxl_worker, uint32_t > > > surface_id, > > > +static

Re: [Spice-devel] [PATCH v6 0/9] async and s3 support

2011-07-20 Thread Gerd Hoffmann
On 07/20/11 10:19, Alon Levy wrote: v6 changes: * fixed missing free(rects) * added surface on demand patch * new api is only available as new spice_qxl_ calls, no new callbacks in QXLWorker Looks good to me. cheers, Gerd ___ Spice-devel ma

Re: [Spice-devel] [PATCH v6 1/9] server: spice-server.syms: move sasl symbols to 0.8.2

2011-07-20 Thread Alon Levy
On Wed, Jul 20, 2011 at 10:54:56AM +0200, Christophe Fergeau wrote: > Let's wait until we know what goes in 0.8.2 for that one :) I thought you already cherry-picked it into the 0.8 branch upstream? > > Christophe > > On Wed, Jul 20, 2011 at 11:19:51AM +0300, Alon Levy wrote: > > --- > > serve

Re: [Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Alon Levy
On Wed, Jul 20, 2011 at 10:53:49AM +0200, Christophe Fergeau wrote: > On Wed, Jul 20, 2011 at 11:19:52AM +0300, Alon Levy wrote: > > -static void qxl_worker_update_area(QXLWorker *qxl_worker, uint32_t > > surface_id, > > +static void red_dispatcher_update_area(RedDispatcher *dispatcher, uint32_t

Re: [Spice-devel] About libcacard and spice-gtk license.

2011-07-20 Thread Christophe Fergeau
Hi Liang, On Wed, Jul 20, 2011 at 04:45:33PM +0800, Liang Guo wrote: > Libcacard is licensed under GPL3, spice-gtk is licensed under LGPL2.1, > but spice-gtk may call libcacard, Should this cause any legal problem > ? Actually, there are 2 differently licensed libcacard code bases, there is the s

Re: [Spice-devel] [PATCH v6 1/9] server: spice-server.syms: move sasl symbols to 0.8.2

2011-07-20 Thread Christophe Fergeau
Let's wait until we know what goes in 0.8.2 for that one :) Christophe On Wed, Jul 20, 2011 at 11:19:51AM +0300, Alon Levy wrote: > --- > server/spice-server.syms | 10 +++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/server/spice-server.syms b/server/spice-serve

Re: [Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Christophe Fergeau
On Wed, Jul 20, 2011 at 11:19:52AM +0300, Alon Levy wrote: > -static void qxl_worker_update_area(QXLWorker *qxl_worker, uint32_t > surface_id, > +static void red_dispatcher_update_area(RedDispatcher *dispatcher, uint32_t > surface_id, > QXLRect *qxl_area, QXLRe

[Spice-devel] About libcacard and spice-gtk license.

2011-07-20 Thread Liang Guo
Hi, List, Libcacard is licensed under GPL3, spice-gtk is licensed under LGPL2.1, but spice-gtk may call libcacard, Should this cause any legal problem ? Thanks, -- Liang GUO http://bluestone.cublog.cn ___ Spice-devel mailing list Spice-devel@lists.fre

[Spice-devel] [PATCH v6 9/9] server/red_worker: send surface images to client on-demand after S3/4 wakeup

2011-07-20 Thread Alon Levy
From: Yonit Halperin When surfaces are being reloaded to the worker, we will send them to the client only if and when it needs them. --- server/red_worker.c | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_wor

[Spice-devel] [PATCH v6 8/9] server/spice.h: bump QXL_MINOR because of QXLWorker and QXLInterface changes

2011-07-20 Thread Alon Levy
--- server/spice.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/spice.h b/server/spice.h index 1191e2c..10e5e77 100644 --- a/server/spice.h +++ b/server/spice.h @@ -90,7 +90,7 @@ struct SpiceCoreInterface { #define SPICE_INTERFACE_QXL "qxl" #define SPICE_INT

[Spice-devel] [PATCH v6 7/9] server: add QXLWorker.flush_surfaces_async for S3/S4 support

2011-07-20 Thread Alon Levy
This does the following, all to remove any referenced memory on the pci bars: flush_all_qxl_commands(worker); flush_all_surfaces(worker); red_wait_outgoing_item((RedChannel *)worker->display_channel); red_wait_outgoing_item((RedChannel *)worker->cursor_channel); The added api is sp

[Spice-devel] [PATCH v6 6/9] server: add QXLInterface::update_area_complete callback

2011-07-20 Thread Alon Levy
when update_area_async is called update_area_complete will be called with the surfaces dirty rectangle list. --- server/red_worker.c | 60 +- server/spice.h |3 ++ 2 files changed, 47 insertions(+), 16 deletions(-) diff --git a/server/red

[Spice-devel] [PATCH v6 5/9] server/red_worker: handle_dev_input: reuse write_ready introduced for async

2011-07-20 Thread Alon Levy
--- server/red_worker.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index f29a420..ec895ec 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9708,6 +9708,10 @@ static void handle_dev_input(EventListener

[Spice-devel] [PATCH v6 4/9] server: add async io support

2011-07-20 Thread Alon Levy
The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function "async_complete". When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is written or expected by the dispatcher. update

[Spice-devel] [PATCH v6 3/9] bump required spice-protocol to 0.8.1 for qxl_dev async and s3 updates

2011-07-20 Thread Alon Levy
--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 3268df6..cb0ca99 100644 --- a/configure.ac +++ b/configure.ac @@ -132,7 +132,7 @@ AM_CONDITIONAL(SUPPORT_CLIENT, test "x$enable_client" = "xyes") dnl =

[Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

2011-07-20 Thread Alon Levy
For each callback in QXLWorker, for example QXLWorker::update_area, add a direct call named spice_qxl_update_area. This will (a) remove the pointless indirection and (b) make shared library versioning alot easier as we'll get new linker symbols which we can tag with the version they appeared in th

[Spice-devel] [PATCH v6 1/9] server: spice-server.syms: move sasl symbols to 0.8.2

2011-07-20 Thread Alon Levy
--- server/spice-server.syms | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/server/spice-server.syms b/server/spice-server.syms index 7f3c5d4..da7a483 100644 --- a/server/spice-server.syms +++ b/server/spice-server.syms @@ -54,13 +54,17 @@ global: spice_serv

[Spice-devel] [PATCH v6 0/9] async and s3 support

2011-07-20 Thread Alon Levy
v6 changes: * fixed missing free(rects) * added surface on demand patch * new api is only available as new spice_qxl_ calls, no new callbacks in QXLWorker git tree: git://anongit.freedesktop.org/~alon/spice async_and_s3.v6 additional requirements for testing: git://anongit.freedesk