red_handle_drawable_surfaces_client_synced was called only from
red_pipe_add_drawable, while it
should also be called from red_pipe_add_drawable_after. Otherwise, the client
might receive a command with a reference to a surface it doesn't hold and crash.
---
server/red_worker.c |2 ++
1 files
red_pipe_add_drawable can lead to removal of drawables from current tree
(since it calls red_handle_drawable_surfaces_client_synced), which can
also lead to releasing these drawables.
Before the fix, red_current_add_equal, called red_pipe_add_drawable,
without assuring afterwards that the drawables
Hi,
This version is more efficient since it removes the other_drawable
from the tree before red_handle_drawable_surfaces_client_synced is called.
In this manner, other_drawable won't be unnecessarily rendered if
update_area is called.
Yonit Halperin (2):
server: fix access to a released drawable
On Mon, 2011-07-04 at 21:07 +0300, Yaniv Kaul wrote:
> On 07/04/2011 07:33 PM, John A. Sullivan III wrote:
> > On Mon, 2011-07-04 at 17:48 +0300, Yonit Halperin wrote:
> >> On 07/04/2011 05:21 PM, John A. Sullivan III wrote:
> >>> Very helpful and interesting. I'll respond in-line - John
> >>>
> >
On Wed, 2011-07-06 at 07:43 -0400, John A. Sullivan III wrote:
> On Wed, 2011-07-06 at 13:23 +0300, Arnon Gilboa wrote:
> > John A. Sullivan III wrote:
> > >
> > > We've made considerable progress. We do not have VS2008 as we are not a
> > > Windows shop and I assume in my Windows ignorance that
Yonit Halperin writes:
> Hi,
> It looks like Render overlaps QXL_DRAW_ROP3. Maybe QXLRop3 can be
> exploited?
I'm not sure it's possible to wedge the Render semantics into
QXLRop3. Here are some differences between the two commands:
- Render supports full affine transformations, not just scalin
On Mon, Jul 11, 2011 at 01:48:38PM +0300, Alon Levy wrote:
> On Sun, Jul 10, 2011 at 09:55:21AM +0300, Yonit Halperin wrote:
> > On 07/07/2011 07:33 PM, Alon Levy wrote:
> > >used to move dirty rectangle notification from update_area to
> > >surface_updated.
> > >
> > >This is RfC quality. Specifi
On Sun, Jul 10, 2011 at 09:55:21AM +0300, Yonit Halperin wrote:
> On 07/07/2011 07:33 PM, Alon Levy wrote:
> >used to move dirty rectangle notification from update_area to
> >surface_updated.
> >
> >This is RfC quality. Specifically where to call surface_updated. Currently I
> >only call it from s
