Re: [Spice-devel] bad primary surface and server crash after migration

2011-07-10 Thread Gerd Hoffmann
Hi, I pushed this fix. But, as Alon discovered, after shutdown of the vm and then calling system_reset, it causes another problem: before starting the vm, qxl_hard_reset is called. It calls destroy_all_surfaces, which attempts to flush the command rings, but since the worker is not running, it doe

Re: [Spice-devel] RFC: Render support in the protocol

2011-07-10 Thread Yonit Halperin
On 07/06/2011 04:38 PM, Soeren Sandmann wrote: RENDER is a very commonly used X extension that currently is not supported very well in SPICE. This leads to the QXL X driver having to read back pixels from the device, render in software, then transmit an image. This is currently the biggest perfor

Re: [Spice-devel] bad primary surface and server crash after migration

2011-07-10 Thread Yonit Halperin
On 07/04/2011 12:23 PM, Gerd Hoffmann wrote: On 07/04/11 10:51, Yonit Halperin wrote: Hi Gerd, I encountered several problems after migration, maybe you can help: 1) on qxl_pre_load, sometimes the command ring is not empty and when handle_dev_destroy_surface (on hard reset), flush_all_qxl_comma

Re: [Spice-devel] [PATCH v3] server: add QXLWorker.flush_surfaces_async for S3/S4 support

2011-07-10 Thread Alon Levy
On Sun, Jul 10, 2011 at 09:26:35AM +0300, Yonit Halperin wrote: > On 07/07/2011 07:33 PM, Alon Levy wrote: > >This does three things: > > flush both command rings > > stop (rendering everything) > > start > > > > Hi, > just need to update the message :) > Thanks, updated. > >Pulled out start

Re: [Spice-devel] [PATCH qxl-win v3] display: add FlushRelease and FlushSurfaces for alternative V06 (2) revision implementation

2011-07-10 Thread Alon Levy
On Sun, Jul 10, 2011 at 08:39:55AM +0300, Yonit Halperin wrote: > On 07/07/2011 12:43 PM, Alon Levy wrote: > >--- > > display/driver.c | 44 ++-- > > 1 files changed, 42 insertions(+), 2 deletions(-) > > > >diff --git a/display/driver.c b/display/driver.c