[Spice-devel] Unfair comparisons with RDP

2011-06-24 Thread John A. Sullivan III
Hello, all. Another question to be answered only if there is time. As we put SPICE head to head with the TSPlus implementation of RDP, SPICE seems to be coming up a bit short and I expect it is somewhat unfairly so. It appears that RDP starts painting the screen sooner that SPICE does and so it a

Re: [Spice-devel] Questions about multimonitor Xinerama configuration

2011-06-24 Thread Leonardo E. Reiter
On Fri, Jun 24, 2011 at 11:46 AM, Leonardo E. Reiter wrote: > On Fri, Jun 24, 2011 at 4:33 AM, Gerd Hoffmann wrote: > >> Hi, >> >> >> you can see the 2nd QXL device at 00:06.0. I don't know why the first >>> one says "VGA compatible" and the second one doesn't, but hopefully that >>> is not an

Re: [Spice-devel] Questions about multimonitor Xinerama configuration

2011-06-24 Thread Leonardo E. Reiter
On Fri, Jun 24, 2011 at 4:33 AM, Gerd Hoffmann wrote: > Hi, > > > you can see the 2nd QXL device at 00:06.0. I don't know why the first >> one says "VGA compatible" and the second one doesn't, but hopefully that >> is not an issue. >> > > The second simply isn't matched by the qxl driver due t

[Spice-devel] [RFC 4/4] use new @ifdef directive for smartcard messages

2011-06-24 Thread Christophe Fergeau
We don't want to conditionally compile the smartcard messages depending on whether USE_SMARTCARD is set or not, we can now use the @ifdef attribute for that. --- spice.proto |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spice.proto b/spice.proto index cb4c9cd..4c072ed 1

[Spice-devel] [RFC 3/4] handle @ifdef on messages and channels

2011-06-24 Thread Christophe Fergeau
--- python_modules/demarshal.py | 22 ++ python_modules/marshal.py | 28 +--- 2 files changed, 43 insertions(+), 7 deletions(-) diff --git a/python_modules/demarshal.py b/python_modules/demarshal.py index 9d3b1e4..5a5a744 100644 --- a/python_modul

[Spice-devel] [RFC 2/4] allow attributes on channel elements in .proto files

2011-06-24 Thread Christophe Fergeau
We want to be able to add an @ifdef annotation to optional messages For example, we want to compile in the smartcard messages only if libcacard is available --- python_modules/ptypes.py |4 +++- python_modules/spice_parser.py |2 +- 2 files changed, 4 insertions(+), 2 deletions(-) d

[Spice-devel] [RFC 1/4] add ifdef/endif methods to spice code generator

2011-06-24 Thread Christophe Fergeau
These methods will be needed to be able to make some fields optional in spice.proto --- python_modules/codegen.py | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/python_modules/codegen.py b/python_modules/codegen.py index 75033dc..e438e4d 100644 --- a/python_mo

[Spice-devel] [RFC 0/4] add @ifdef to python code generator

2011-06-24 Thread Christophe Fergeau
Hi, As part of my changes to add smartcard support to spice-gtk, I needed to make the compilation of the generated smartcard messages optional because it relies on structures defined in libcacard, which might not be available. In order to achieve that, I added a @ifdef attribute to message and cha

Re: [Spice-devel] [RfC spice-protocol PATCH] Add async I/O commands.

2011-06-24 Thread Alon Levy
On Fri, Jun 24, 2011 at 12:47:09PM +0200, Gerd Hoffmann wrote: > Hi, > > >>What is the status of the S3 bits? > > > >I've updated to not require new spicelib api, using your suggestion, and it > >seems to work > >fine. > > Great. > > >I just wanted to do some further testing before sending it

[Spice-devel] [RfC fix] async thread fix - handle EAGAIN/EINTR, remove fprintf

2011-06-24 Thread Alon Levy
--- hw/qxl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index dd42a40..51a5270 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1012,13 +1012,15 @@ static void *ioport_write_async(void *arg) while (true) { ret = read(d->aio_pipe[0], &io,

[Spice-devel] [spice-protocol PATCH v2 2/2] qxl_dev: add third revision V10

2011-06-24 Thread Alon Levy
--- spice/qxl_dev.h |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 1c39a0f..761e4a2 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -43,8 +43,12 @@ /* 0x100-0x11f reserved for spice, 0x1ff used for unstable work */

[Spice-devel] [spice-protocol PATCH v2 1/2] add QXL_IO_FLUSH_{SURFACES, RELEASE} for sleep (S3) support

2011-06-24 Thread Alon Levy
Adds a new revision to notify of this new IO to the driver. This new revision (QXL_REVISION_STABLE_V10) will also include other IO updates for async IO. related RHBZ: 63 Guest initiated sleep looks like this: Guest: (0) stop putting new commands into the rings (1) QXL_IO_NOTIFY_CMD (2

Re: [Spice-devel] [RfC spice-protocol PATCH] Add async I/O commands.

2011-06-24 Thread Gerd Hoffmann
Hi, What is the status of the S3 bits? I've updated to not require new spicelib api, using your suggestion, and it seems to work fine. Great. I just wanted to do some further testing before sending it, but I can send the spice-protocol patches and the qemu patches already if you like,

Re: [Spice-devel] [RfC spice-protocol PATCH] Add async I/O commands.

2011-06-24 Thread Alon Levy
On Fri, Jun 24, 2011 at 10:07:19AM +0200, Gerd Hoffmann wrote: > On 06/23/11 20:01, Alon Levy wrote: > >On Wed, Jun 22, 2011 at 10:46:18AM +0200, Gerd Hoffmann wrote: > >>Add async versions of the I/O commands which do not block and instead > >>raise the new QXL_INTERRUPT_IO_CMD when done. > >> > >

Re: [Spice-devel] Questions about multimonitor Xinerama configuration

2011-06-24 Thread Gerd Hoffmann
Hi, you can see the 2nd QXL device at 00:06.0. I don't know why the first one says "VGA compatible" and the second one doesn't, but hopefully that is not an issue. The second simply isn't matched by the qxl driver due to the different PCI class. Fixable (see attachent). That alone doesn

Re: [Spice-devel] spice-gtk build error - no debug symbols in executable

2011-06-24 Thread Attila Sukosd
Hi Cliff, I've hit the same problem, it seems like its the problem with introspection in MacPorts. Adding --enable-introspection=no seemed to have solved this issue. I'm hitting another with vala though: make all-recursive Making all in common Making all in win Making all in my_getopt-1.5 make[

Re: [Spice-devel] [RfC spice-protocol PATCH] Add async I/O commands.

2011-06-24 Thread Gerd Hoffmann
On 06/23/11 20:01, Alon Levy wrote: On Wed, Jun 22, 2011 at 10:46:18AM +0200, Gerd Hoffmann wrote: Add async versions of the I/O commands which do not block and instead raise the new QXL_INTERRUPT_IO_CMD when done. I would also add V10 defined to 3, and replace 2,3 references with V06 and V10

Re: [Spice-devel] [RfC PATCH 7/7] async qxl I/O

2011-06-24 Thread Gerd Hoffmann
Hi, +/* old spice-protocol */ +#ifndef QXL_INTERRUPT_IO_CMD +#define QXL_INTERRUPT_IO_CMD (1<< 2) +#define QXL_IO_UPDATE_AREA_ASYNC (QXL_IO_DESTROY_ALL_SURFACES +1) +#define QXL_IO_NOTIFY_OOM_ASYNC(QXL_IO_DESTROY_ALL_SURFACES +2) +#define QXL_IO_MEMSLOT_ADD