Re: [Spice-devel] Questions about image cache (in server/red_worker.c)

2011-05-18 Thread Yaniv Kaul
On 05/19/2011 09:18 AM, Yonit Halperin wrote: Hi, you are not looking at the right cache. THe right cache is red_client_shared_cache.h (shared among multiple monitors; doesn't store images, only ids). The cached you looked at is the cache of the canvas. Cheers, Yonit. That still doesn't ma

Re: [Spice-devel] Questions about image cache (in server/red_worker.c)

2011-05-18 Thread Yonit Halperin
Hi, you are not looking at the right cache. THe right cache is red_client_shared_cache.h (shared among multiple monitors; doesn't store images, only ids). The cached you looked at is the cache of the canvas. Cheers, Yonit. On 05/18/2011 10:54 AM, Yaniv Kaul wrote: I suspect the image cachin

Re: [Spice-devel] [PATCH] Prefer malloc() over calloc()

2011-05-18 Thread Zeeshan Ali (Khattak)
On Wed, May 18, 2011 at 11:38 PM, Zeeshan Ali (Khattak) wrote: > When only 1 element needs to be allocated, calloc() only makes the code > *slightly* less readable. Please ignore this patch. I forgot that calloc also zero's out the memory. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 __

[Spice-devel] [PATCH] Prefer malloc() over calloc()

2011-05-18 Thread Zeeshan Ali (Khattak)
When only 1 element needs to be allocated, calloc() only makes the code *slightly* less readable. --- src/console-kit.c |2 +- src/udscs.c |6 +++--- src/vdagent-virtio-port.c |2 +- src/vdagent-x11.c |2 +- src/vdagentd-uinput.c |2 +- src/vda

Re: [Spice-devel] Multi-monitor support...

2011-05-18 Thread Naga Mohan Pothula
Thanks Alon, I'm testing with 64-bit RHEL 6.1 Beta and Win7 x64 Guests. Dual head functionality is not working with 64-bit RHEL 6.1 Beta and  it is working with Win7 x64 but have noticed that it displays two Spice connection windows when window is in Restore mode. It would be good idea if we set

[Spice-devel] Questions about image cache (in server/red_worker.c)

2011-05-18 Thread Yaniv Kaul
I suspect the image caching in the server is not the greatest: 1. Using latest Fedora 15 and QXL driver, I don't see any image being cached - at all. 2. Using XP with latest QXL driver, I do see some caching activity, but I suspect: - the cache is limited to 2(!) items only (as IMAGE_CACHE_MAX_