Re: [Spice-devel] [RFC v4 06/62] server/main_channel.c: set NET_TEST_STAGE_INVALID=0 explicitly

2011-05-04 Thread Alon Levy
On Tue, May 03, 2011 at 01:56:51AM +0200, Marc-André Lureau wrote: > Agreed, but one patch over all spice code base instead of individual > patches would be even better. > ok, the moment I figure out how to grep over end of lines. > On Tue, Apr 26, 2011 at 12:54 PM, Alon Levy wrote: > > --- > >

Re: [Spice-devel] [RFC v4 04/62] server/red_worker: introduce {display, cursor}_connected

2011-05-04 Thread Alon Levy
On Tue, May 03, 2011 at 01:53:34AM +0200, Marc-André Lureau wrote: > perhaps rename xxx_connected() -> xxx_is_connected() for consistency > done. > On Tue, Apr 26, 2011 at 12:54 PM, Alon Levy wrote: > > Instead of checking for worker->{display,cursor}_channel directly. > > --- > >  server/red_w

Re: [Spice-devel] [RFC v4 01/62] server/red_channel: renames to use _proc postfix consistently

2011-05-04 Thread Alon Levy
On Tue, May 03, 2011 at 01:53:40AM +0200, Marc-André Lureau wrote: > It looks like it is later reverted in the patch: > > server/red_worker: split display and cursor channels > > The current code style tends to reserve _proc for function type name > only. Should we try to keep it that way? Just

Re: [Spice-devel] [libvirt] qemu qxl video memory parameter - windows bsod with spice

2011-05-04 Thread Emre Erenoglu
On Wed, May 4, 2011 at 11:40 PM, Gianluca Cecchi wrote: > On Wed, May 4, 2011 at 6:05 PM, Daniel P. Berrange > wrote: > > On Wed, May 04, 2011 at 07:52:37PM +0400, Emre Erenoglu wrote: > >> Hi, > >> > >> Please see the below discussion with the spice community. > >> > >> libvirt is adding a param

Re: [Spice-devel] [libvirt] qemu qxl video memory parameter - windows bsod with spice

2011-05-04 Thread Gianluca Cecchi
On Wed, May 4, 2011 at 6:05 PM, Daniel P. Berrange wrote: > On Wed, May 04, 2011 at 07:52:37PM +0400, Emre Erenoglu wrote: >> Hi, >> >> Please see the below discussion with the spice community. >> >> libvirt is adding a parameter about video ram to qemu process and this >> parameter might be respo

Re: [Spice-devel] [PATCH] server: Unset executable bit of red_tunnel_worker.h

2011-05-04 Thread Hans de Goede
Ack. On 05/04/2011 07:39 PM, Zeeshan Ali (Khattak) wrote: --- 0 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 server/red_tunnel_worker.h diff --git a/server/red_tunnel_worker.h b/server/red_tunnel_worker.h old mode 100755 new mode 100644 _

[Spice-devel] [PATCH] server: Unset executable bit of red_tunnel_worker.h

2011-05-04 Thread Zeeshan Ali (Khattak)
--- 0 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 server/red_tunnel_worker.h diff --git a/server/red_tunnel_worker.h b/server/red_tunnel_worker.h old mode 100755 new mode 100644 -- 1.7.5 ___ Spice-devel mailing list Sp

Re: [Spice-devel] [libvirt] qemu qxl video memory parameter - windows bsod with spice

2011-05-04 Thread Daniel P. Berrange
On Wed, May 04, 2011 at 07:52:37PM +0400, Emre Erenoglu wrote: > Hi, > > Please see the below discussion with the spice community. > > libvirt is adding a parameter about video ram to qemu process and this > parameter might be responsible of a crash in the qxl at higher resolutions. > Spice peopl

[Spice-devel] qemu qxl video memory parameter - windows bsod with spice

2011-05-04 Thread Emre Erenoglu
Hi, Please see the below discussion with the spice community. libvirt is adding a parameter about video ram to qemu process and this parameter might be responsible of a crash in the qxl at higher resolutions. Spice people tell me that their default ram should be 64 Mbytes. I'm using libvirt 0.9.

[Spice-devel] [PATCH 3/3] server: inputs_channel: inputs_link: don't assert on existing channel

2011-05-04 Thread Alon Levy
If we do connect/reconnect fast enough a new inputs connection can happen while the old channel has not been shutdown yet. Instead of finding the route cause, it seems better to handle this situation at the channel level: just shutdown the channel on a new connection. Fixes a frequent assert I've e

[Spice-devel] [PATCH 2/3] server/red_worker: display channel: release PIPE_ITEM_TYPE_VERB

2011-05-04 Thread Alon Levy
We didn't expect PIPE_ITEM_TYPE_VERB in display_channel_release_item even thought we send them. fix that. Fixes panic when doing frequent connect/disconnect of client. --- server/red_worker.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/re

[Spice-devel] [PATCH 1/3] server/red_channel: release item on red_channel_reset_send_data

2011-05-04 Thread Alon Levy
This fixes an assertion in red_channel_init_send_data triggered by the cursor channel. Also a result of frequent client connect/disconnects. Since we already zero the type field of the header on red_channel_reset_send_data it foils our check for a pending message (red_channel_send_message_pending).

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-05-04 Thread Emre Erenoglu
On Wed, May 4, 2011 at 6:00 PM, Alon Levy wrote: > On Wed, May 04, 2011 at 05:10:31PM +0400, Emre Erenoglu wrote: > > On Wed, May 4, 2011 at 2:12 PM, Alon Levy wrote: > > > > > On Wed, May 04, 2011 at 01:45:39PM +0400, Emre Erenoglu wrote: > > > > On Wed, Apr 27, 2011 at 1:16 AM, Emre Erenoglu

Re: [Spice-devel] Fwd: OSX spice-gtk and pyparsing

2011-05-04 Thread Christophe Fergeau
On Wed, May 04, 2011 at 09:17:37AM -0500, Cliff Sharp wrote: > OK - this sounds very good. > If you can think of any more or more specifics just let me know. To make things clear, these are things that I'd love to have in spice-gtk (I assume spice-gtk maintainers agree with this, but maybe they do

Re: [Spice-devel] Fwd: OSX spice-gtk and pyparsing

2011-05-04 Thread Cliff Sharp
OK - this sounds very good. If you can think of any more or more specifics just let me know. On May 4, 2011, at 3:41 AM, Christophe Fergeau wrote: > On Tue, May 03, 2011 at 05:32:12PM -0500, Cliff Sharp wrote: >> So, now I use the X11 environment that comes with osx when I actually run >> spiced

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-05-04 Thread Alon Levy
On Wed, May 04, 2011 at 05:10:31PM +0400, Emre Erenoglu wrote: > On Wed, May 4, 2011 at 2:12 PM, Alon Levy wrote: > > > On Wed, May 04, 2011 at 01:45:39PM +0400, Emre Erenoglu wrote: > > > On Wed, Apr 27, 2011 at 1:16 AM, Emre Erenoglu > > wrote: > > > > > > > Hi, > > > > > > > > I started to se

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-05-04 Thread Emre Erenoglu
On Wed, May 4, 2011 at 2:12 PM, Alon Levy wrote: > On Wed, May 04, 2011 at 01:45:39PM +0400, Emre Erenoglu wrote: > > On Wed, Apr 27, 2011 at 1:16 AM, Emre Erenoglu > wrote: > > > > > Hi, > > > > > > I started to see frequent crashes with my guests running windows xp and > > > windows server 200

Re: [Spice-devel] jpeg and jpeg_alpha in spice

2011-05-04 Thread Christophe Fergeau
On Wed, May 04, 2011 at 10:33:08AM +0800, Shuxiang Lim wrote: > Hi,Alon! > Thanks,but now I decide to abandon such drudgery try of forcing use JPEG > in spice-server because it's not a friendly reasonable way to spice. Now all > that I can do currently is just attempting to fasten the image traff

Re: [Spice-devel] jpeg and jpeg_alpha in spice

2011-05-04 Thread Alon Levy
On Wed, May 04, 2011 at 10:33:08AM +0800, Shuxiang Lim wrote: > Hi,Alon! > Thanks,but now I decide to abandon such drudgery try of forcing use JPEG > in spice-server because it's not a friendly reasonable way to spice. Now all > that I can do currently is just attempting to fasten the image traff

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-05-04 Thread Alon Levy
On Wed, May 04, 2011 at 01:45:39PM +0400, Emre Erenoglu wrote: > On Wed, Apr 27, 2011 at 1:16 AM, Emre Erenoglu wrote: > > > Hi, > > > > I started to see frequent crashes with my guests running windows xp and > > windows server 2003 x86. The bsod appears on qxldd.dll. I can give further > > info

Re: [Spice-devel] [PATCH] spice: add SASL support

2011-05-04 Thread Alon Levy
On Tue, May 03, 2011 at 10:31:11PM +0200, Marc-André Lureau wrote: ACK by me, but you should send this to qemu-de...@nongnu.org too. > Turn on SASL support by appending "sasl" to the spice arguments, which > requires that the client use SASL to authenticate with the spice. The > exact choice of

Re: [Spice-devel] [PATCH] server: bump SPICE_SERVER_VERSION to 0.9.0

2011-05-04 Thread Alon Levy
On Tue, May 03, 2011 at 08:41:30PM +0200, Marc-André Lureau wrote: > SASL functions will be released with 0.9.0 > --- > server/spice.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > ACK. > diff --git a/server/spice.h b/server/spice.h > index d22425b..425d586 100644 > --- a/serve

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-05-04 Thread Emre Erenoglu
On Wed, Apr 27, 2011 at 1:16 AM, Emre Erenoglu wrote: > Hi, > > I started to see frequent crashes with my guests running windows xp and > windows server 2003 x86. The bsod appears on qxldd.dll. I can give further > info if needed. > > The host is Linux x86_64, qemu 0.14, spice 0.8.1. Guest has q

Re: [Spice-devel] Fwd: OSX spice-gtk and pyparsing

2011-05-04 Thread Christophe Fergeau
On Tue, May 03, 2011 at 05:32:12PM -0500, Cliff Sharp wrote: > So, now I use the X11 environment that comes with osx when I actually run > spiced and/or spicy. But I feel you are correct in saying that it is > better to use the X11 system that comes with osx. > > I was just attempting to notify ot