Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: > diff --git a/common/ssl_verify.c b/common/ssl_verify.c > new file mode 100644 > index 000..f7d9482 > --- /dev/null > +++ b/common/ssl_verify.c > @@ -0,0 +1,458 @@ > +/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*-

Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: > Code adapter from RedPeer::ssl_verify_callback() and used by > spice-gtk. I looked at this one, and was quickly concerned about the amount of security checks we're trying to do on our own. Basically, we let openssl do the certifi

Re: [Spice-devel] spicec and spice-gtk

This is great - thank you On Apr 29, 2011, at 10:01 AM, Marc-André Lureau wrote: > Hi, > > - Original Message - >> There are a number of companies that interface to spicec >> programmatically. >> >> These companies right now do a fork exec or whatever to run spicec >> from within their

Re: [Spice-devel] spicec and spice-gtk

Hi, - Original Message - > There are a number of companies that interface to spicec > programmatically. > > These companies right now do a fork exec or whatever to run spicec > from within their software products. > There are a number of reasons why they do not implement the spice > proto

Re: [Spice-devel] spicec and spice-gtk

Good question... Here are some recommendations -- There are a number of companies that interface to spicec programmatically. These companies right now do a fork exec or whatever to run spicec from within their software products. There are a number of reasons why they do not implement the spice

Re: [Spice-devel] spicec and spice-gtk

On Fri, Apr 29, 2011 at 07:22:12AM -0500, Cliff Sharp wrote: > I never said that spice-gtk is bad for me. > There are companies that need and use spicec. Once again, why do they *need* it as opposed to "they need a spice client, they don't really care if it's C, python, raw X, Qt, ..." Saying thes

Re: [Spice-devel] spicec and spice-gtk

I never said that spice-gtk is bad for me. There are companies that need and use spicec. On Fri, 2011-04-29 at 14:06 +0200, Christophe Fergeau wrote: > On Fri, Apr 29, 2011 at 07:49:14AM -0400, Cliff Sharp wrote: > > There are companies that only use spicec that don't want to make changes > > righ

Re: [Spice-devel] spicec and spice-gtk

On Fri, Apr 29, 2011 at 07:49:14AM -0400, Cliff Sharp wrote: > There are companies that only use spicec that don't want to make changes > right now. Not on OSX, do they? I'm really not understanding why using spice-gtk seems to be so bad for you :( Christophe pgpByFrLpGmPB.pgp Description: PGP

Re: [Spice-devel] OSX spice-gtk and pyparsing

I would be happy to as soon as I get a server running. Right now I am working on getting qemu running with a guest image for testing. I have been waiting 2 hours for an guest image to be build from and iso. It is not working too well on OSX. On Fri, 2011-04-29 at 10:46 +0200, Kai Mosebach wrote

Re: [Spice-devel] spicec and spice-gtk

There are companies that only use spicec that don't want to make changes right now. On Fri, 2011-04-29 at 10:54 +0200, Christophe Fergeau wrote: > On Thu, Apr 28, 2011 at 03:57:50PM -0500, Cliff Sharp wrote: > > I have spice-gtk built and running on OSX. It has some issues but it does > > connect

[Spice-devel] [RFCv2 21/21] xspice/qxl_ring: yield when ring is full

--- src/qxl_ring.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/qxl_ring.c b/src/qxl_ring.c index 0870ef1..02c4c35 100644 --- a/src/qxl_ring.c +++ b/src/qxl_ring.c @@ -75,7 +75,11 @@ qxl_ring_push (struct qxl_ring *ring, while (header->prod - header->cons

[Spice-devel] [RFCv2 20/21] xspice: README, config, launcher script

--- README.xspice | 109 TODO.xspice| 27 + spiceqxl.xorg.conf | 15 +++ xspice | 21 ++ 4 files changed, 172 insertions(+), 0 deletions(-) create mode 100644 README.xspice create mode 10

[Spice-devel] [RFCv2 19/21] xspice: add inputs (mouse and keyboard)

--- src/Makefile.am |1 + src/qxl_driver.c |2 + src/spiceqxl_inputs.c | 353 + src/spiceqxl_inputs.h |9 ++ 4 files changed, 365 insertions(+), 0 deletions(-) create mode 100644 src/spiceqxl_inputs.c create mode 100644 src/

[Spice-devel] [RFCv2 18/21] xspice: implement ioport_write

--- src/spiceqxl_io_port.c | 181 1 files changed, 181 insertions(+), 0 deletions(-) diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c index ba6ac4a..89a9657 100644 --- a/src/spiceqxl_io_port.c +++ b/src/spiceqxl_io_port.c @@ -54,8 +54,

[Spice-devel] [RFCv2 16/21] xspice: add display interface

--- src/Makefile.am|1 + src/qxl.h | 24 src/qxl_driver.c |3 + src/spiceqxl_display.c | 319 src/spiceqxl_display.h | 11 ++ 5 files changed, 358 insertions(+), 0 deletions(-) create mode 100644 src/spi

[Spice-devel] [RFCv2 17/21] xspice: add init_qxl_ram

--- src/qxl_driver.c |2 + src/spiceqxl_io_port.c | 49 src/spiceqxl_io_port.h |4 +++ 3 files changed, 55 insertions(+), 0 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index fe2f532..ef3139b 100644 --- a/src/qxl_dr

[Spice-devel] [RFCv2 15/21] xspice: init spice server, add main loop

Initialize a SpiceServer instance, and implement SpiceCoreInterface, that is fd read, write notification and watchs (timers). The fd implementation is off because Xserver doesn't allow us to be notified on write unblock, only read. Workaround is to poll. --- src/Makefile.am |1 + src

[Spice-devel] [RFCv2 14/21] xspice: add SpicePort config option

--- src/qxl.h|3 +++ src/qxl_driver.c |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 6a0138e..fdd2afd 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -96,6 +96,9 @@ typedef struct qxl_surface_t qxl_surface_t; */ enum { +#ifdef XSPI

[Spice-devel] [RFCv2 13/21] xspice: implement map_helper, unmap_helper, add init_qxl_rom

Memory is taken from malloc instead of from the pci bar. Adds shadow_rom to qxl_screen_t. Introduces init_qxl_rom, which is directly taken from the qxl device in qemu. Plenty of TODO's added in this commit about various constants and about factoring out the code to not do this copy paste from qem

[Spice-devel] [RFCv2 12/21] xspice: use spiceqxlModuleData as entry point

--- src/qxl_driver.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 3834d3a..c77a5f1 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1584,7 +1584,13 @@ static XF86ModuleVersionInfo qxl_module_info = { { 0, 0,

[Spice-devel] [RFCv2 11/21] xspice: don't load ramdac and vgahw sub modules

--- src/qxl_driver.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 548bc15..3834d3a 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1341,9 +1341,12 @@ qxl_pre_init(ScrnInfoPtr pScrn, int flags) xf86PrintMode

[Spice-devel] [RFCv2 10/21] xspice: allocate a single slot

--- src/qxl_driver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 198af00..548bc15 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -424,6 +424,9 @@ qxl_reset (qxl_screen_t *qxl) qxl->mem_slots = xnfalloc (qxl->

[Spice-devel] [RFCv2 09/21] xspice: stop using pci and vga

This ifdefs out all the parts in qxl_driver.c that are pci device specific and are not required by xspice. No functional change. The resulting spiceqxl_drv.so doesn't run. --- src/qxl.h|9 - src/qxl_driver.c | 89 +- 2 files ch

[Spice-devel] [RFCv2 08/21] xspice: add spiceqxl_io_port, empty implementation

--- src/Makefile.am|1 + src/qxl.h |8 src/spiceqxl_io_port.c | 12 src/spiceqxl_io_port.h |6 ++ 4 files changed, 27 insertions(+), 0 deletions(-) create mode 100644 src/spiceqxl_io_port.c create mode 100644 src/spiceqxl_io_port.h di

[Spice-devel] [RFCv2 07/21] xspice: use spiceqxl as name of xspice driver

Fixes a few places that have hardcoded "qxl" to use the already defined QXL_DRIVER_NAME. --- src/qxl.h|5 + src/qxl_driver.c |6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 8f16261..35afc5c 100644 --- a/src/qxl.h +++ b/src/q

[Spice-devel] [RFCv2 06/21] xspice: add configure option and make target

adds --enable-xspice, which builds an spiceqxl_drv.so target, and defines SUPPORT_XSPICE. Fails build if spice-server not found. --- configure.ac| 13 + src/Makefile.am | 23 +++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/configure.ac b/

[Spice-devel] [RFCv2 05/21] qxl_driver: introduce helpers for memory map and unmap

qxl_map_memory_helper and qxl_unmap_memory_helper introduced, here as a simple split, later different implementation if XSPICE defined will be added. Nicer then putting an ifdef inside the map/unmap functions. --- src/qxl_driver.c | 52 1 file

[Spice-devel] [RFCv2 04/21] qxl_driver: add setup_slot helper

used in qxl_reset. Later ifdefed with XSPICE, which only uses a single slot covering all memory (really it should just avoid calling the translation mechanism, but for now this is simple enough). --- src/qxl_driver.c | 87 ++ 1 files changed, 4

[Spice-devel] [RFCv2 03/21] add config options (empty for now)

--- src/qxl.h| 10 ++ src/qxl_driver.c |6 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index de3bed7..8f16261 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -83,6 +83,14 @@ typedef struct typedef struct qxl_surface_t qxl_surface_

[Spice-devel] [RFCv2 02/21] partially replace outb with ioport_write

replace everywhere it is needed for xspice - places left out are ifdefed out later based on the same define mentioned in qxl.h, XSPICE. note: leave spaces between function name and open paren? --- src/qxl.h |2 ++ src/qxl_driver.c | 10 +- src/qxl_ring.c|5 +++-- sr

[Spice-devel] [RFCv2 01/21] qxl_ring: keep qxl pointer

Add a qxl_screen_t* member to qxl_ring to make generelizing outb to ioport_write easier in the next patch. This means we do an extra deref and addition for every outb, but it means the code becomes simpler for doing outb in qxl_drv.so and a function call for spiceqxl_drv.so --- src/qxl.h|

[Spice-devel] [RFCv2 00/21] xspice using a shortcircuited driver

This patchset introduces a second target namely spiceqxl_drv.so that contains a display driver, a keyboard and mouse driver, and they all use a single spice server instance. Effectively this allows a spice server using a config file such as: Section "Device" Identifier "XSPICE" Driver "spiceqxl"

Re: [Spice-devel] [PATCH 0/9] cleanup and warning fixes

On Fri, Apr 29, 2011 at 12:36:53PM +0300, Alon Levy wrote: > Split from the xspice rfc patches. ACK from me Christophe pgp5b17wdjoKQ.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop

[Spice-devel] [PATCH 9/9] cleanup (add eol between system and non system includes)

--- src/qxl.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index d086ac7..a2daa8b 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -28,6 +28,7 @@ #include #include + #include "compiler.h" #include "xf86.h" #if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION)

[Spice-devel] [PATCH 8/9] qxl_driver: whitespace fixes

removing whitespace in lines consisting only of it. most of those areas are touched later, but not all. --- src/qxl_driver.c | 52 ++-- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 83617

[Spice-devel] [PATCH 5/9] use spice-protocol defines for ring sizes

--- src/qxl_driver.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index b8f2812..5c25f72 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -908,13 +908,13 @@ qxl_screen_init(int scrnIndex, ScreenPtr pScreen, int argc, char

[Spice-devel] [PATCH 7/9] qxl_driver: fix three incompatible pointer passed warnings

--- src/qxl_driver.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 03da906..8361726 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -905,14 +905,14 @@ qxl_screen_init(int scrnIndex, ScreenPtr pScreen, int argc, ch

[Spice-devel] [PATCH 6/9] qxl_driver: fix initialization from wrong pointer warning

--- src/qxl_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 5c25f72..03da906 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -60,7 +60,7 @@ qxl_garbage_collect (qxl_screen_t *qxl) union QX

[Spice-devel] [PATCH 2/9] qxl_mem.c: fix pointer arithmatic warning (-Wpointer-arith)

--- src/qxl_mem.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qxl_mem.c b/src/qxl_mem.c index bce80ad..705eb83 100644 --- a/src/qxl_mem.c +++ b/src/qxl_mem.c @@ -18,7 +18,7 @@ qxl_mem_create (void *base, if (!mem) goto out; -

[Spice-devel] [PATCH 4/9] qxl.h: move spice include right after system includes

--- src/qxl.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 9451d05..d086ac7 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -27,6 +27,7 @@ #include +#include #include "compiler.h" #include "xf86.h" #if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION

[Spice-devel] [PATCH 3/9] qxl_image.c: fix defined but unused warning

--- src/qxl_image.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/qxl_image.c b/src/qxl_image.c index 04074d0..af83bd6 100644 --- a/src/qxl_image.c +++ b/src/qxl_image.c @@ -93,6 +93,7 @@ lookup_image_info (unsigned int hash, return NULL; } +#if 0 static im

[Spice-devel] [PATCH 1/9] qxl.h: double include protection

--- src/qxl.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 60a1046..9451d05 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -20,6 +20,9 @@ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ +#ifndef QXL_H +#de

[Spice-devel] [PATCH 0/9] cleanup and warning fixes

Split from the xspice rfc patches. Alon Levy (9): qxl.h: double include protection qxl_mem.c: fix pointer arithmatic warning (-Wpointer-arith) qxl_image.c: fix defined but unused warning qxl.h: move spice include right after system includes use spice-protocol defines for ring sizes qxl

Re: [Spice-devel] spicec and spice-gtk

On Fri, Apr 29, 2011 at 11:10:02AM +0200, Kai Mosebach wrote: > The slim barebone one :) Without all the gtk overhead... What overhead? > I think if the audio-interface was more portable it would make a pretty > good starting point for porting. > "it"? Something requiring X11 osx support isn't

Re: [Spice-devel] spicec and spice-gtk

The slim barebone one :) Without all the gtk overhead... I think if the audio-interface was more portable it would make a pretty good starting point for porting. On 4/29/11 11:05 AM, "Christophe Fergeau" wrote: >On Fri, Apr 29, 2011 at 10:56:11AM +0200, Kai Mosebach wrote: >> I personally would

Re: [Spice-devel] spicec and spice-gtk

On Fri, Apr 29, 2011 at 10:56:11AM +0200, Kai Mosebach wrote: > I personally would also like to see spicec available for (Win,LX and OSX) > since its a pure cmdline client w/o any additional GTK stuff (good for own > development)... spice-gtk is to be seen as a gtk widget which you can embed in an

Re: [Spice-devel] spicec and spice-gtk

I personally would also like to see spicec available for (Win,LX and OSX) since its a pure cmdline client w/o any additional GTK stuff (good for own development)... On 4/29/11 10:54 AM, "Christophe Fergeau" wrote: >On Thu, Apr 28, 2011 at 03:57:50PM -0500, Cliff Sharp wrote: >> I have spice-gtk

Re: [Spice-devel] spicec and spice-gtk

On Thu, Apr 28, 2011 at 03:57:50PM -0500, Cliff Sharp wrote: > I have spice-gtk built and running on OSX. It has some issues but it does > connect. I am in the process of testing this now. > > I am trying to build the spice cient spicec (spice-0.8.1) on OSX. What's missing in spice-gtk that make

Re: [Spice-devel] OSX spice-gtk and pyparsing

Hey, I am running spicy under OSX. If I press the 'a' key, nothing happens (within the guest). Can you please try if this is the same for you? Thanks Kai From: Cliff Sharp Date: Wed, 27 Apr 2011 17:10:33 -0500 To: Kai Mosebach Cc: Kai Mosebach , Alon Levy , Subject: Re: [Spice-devel] OSX

Re: [Spice-devel] spicec and spice-gtk

Do you have patches available for that? From: Attila Sukosd Date: Fri, 29 Apr 2011 07:20:00 +0200 To: Cliff Sharp Cc: Kai Mosebach , Subject: Re: [Spice-devel] spicec and spice-gtk PortAudio ___ Spice-devel mailing list Spice-devel@lists.freede