Re: [Spice-devel] [Qemu-devel] paravirtual mouse/tablet

Hi guys, I apologize for replying this way, I wasn't on the spice-list, jrb pointed out this thread to me. For those who don't know me, I'm the input maintainer for X.Org. I also know very little about spice, so please take the comments below accordingly. Comments regarding a few things that showe

[Spice-devel] usb redirection status report

Hi All, As most of you know I'm working on usb redirection (making client usb devices accessible in guests over the network). I thought it would be a good idea to write a short status report. So fat the following has been done: * written and posted a network protocol for usb redir. over the ne

[Spice-devel] [PATCH 24/24] server/red_channel: style fix in red_channel_init_send_data

--- server/red_channel.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index b621be9..f8d5a0e 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -458,10 +458,10 @@ void red_channel_reset_send_data(RedChannel *ch

[Spice-devel] [PATCH 23/24] server/red_channel: red_channel_pipe_clear: assert on NULL channel

--- server/red_channel.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 0eba73c..b621be9 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -601,10 +601,11 @@ int red_channel_is_connected(RedChannel *channel

[Spice-devel] [PATCH 22/24] server/red_channel: don't set blocked when ack window full

blocked is set only on output block. --- server/red_channel.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 9ad2e5a..0eba73c 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -574,18 +574,20 @@ void

[Spice-devel] [PATCH 21/24] server/red_channel: add TODO

--- server/red_channel.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 7db02ab..9ad2e5a 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -64,6 +64,10 @@ static int red_peer_receive(RedsStreamContext *pee

[Spice-devel] [PATCH 20/24] server/red_channel: export red_channel_send

--- server/red_channel.c |2 +- server/red_channel.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 990b9d9..7db02ab 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -462,7 +462,7 @@ void red_channel_in

[Spice-devel] [PATCH 19/24] server/red_channel: red_channel_pipe_get: enforce ack window

We were not setting blocked flag if too many messages weren't acked (twice the ack window size). >From red_worker. --- server/red_channel.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index bfa6aaf..990b9d9 100644 ---

[Spice-devel] [PATCH 18/24] server/red_channel: protect red_channel_push from NULL

--- server/red_channel.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 3dada93..bfa6aaf 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -481,6 +481,10 @@ void red_channel_push(RedChannel *channel) {

[Spice-devel] [PATCH 17/24] server/red_channel: reset pipe_size on clear (from red_worker)

--- server/red_channel.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 45e4b0a..3dada93 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -598,5 +598,6 @@ void red_channel_pipe_clear(RedChannel *channel)

[Spice-devel] [PATCH 16/24] server/red_channel: red_channel_event: push on blocked

try to push either on signal (write available) or when blocked and read signaled. From red_worker, copied for compatibility when switching later to RedChannel in red_worker. Doesn't make a lot of sense (but works), see comment in patch. --- server/red_channel.c |7 ++- 1 files changed, 6 i

[Spice-devel] [PATCH 15/24] server/red_channel: use red_channel_receive

--- server/red_channel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 19f69b2..be44995 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -422,7 +422,7 @@ static void red_channel_event(int fd, int event, vo

[Spice-devel] [PATCH 14/24] server/red_channel: add empty handle of SPICE_MSGC_DISCONNECTING

Simply ignored in red_channel_handle_message --- server/red_channel.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 0492282..19f69b2 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -408,6 +408,8 @@ int re

[Spice-devel] [PATCH 13/24] server/red_channel: add red_channel_receive (for red_worker)

--- server/red_channel.c |5 + server/red_channel.h |8 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index bda5e81..0492282 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -143,6 +143,11 @@ static v

[Spice-devel] [PATCH 12/24] server/red_channel: unstatic red_channel_pipe_clear (for red_worker)

--- server/red_channel.c |3 +-- server/red_channel.h |4 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 2051228..bda5e81 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -30,7 +30,6 @@ #include "red_cha

[Spice-devel] [PATCH 11/24] server/red_channel: unstatic red_channel_push (for red_worker)

--- server/red_channel.c |3 +-- server/red_channel.h |6 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 92e60fe..2051228 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -29,7 +29,6 @@ #include "stat.

[Spice-devel] [PATCH 10/24] server/red_channel: two 80 column fixes

--- server/red_channel.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 2744fda..92e60fe 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -115,8 +115,9 @@ static void red_peer_handle_incoming(RedsSt

[Spice-devel] [PATCH 09/24] server/red_channel: add public red_channel_default_peer_on_error

for later use in red_worker --- server/red_channel.c |8 +++- server/red_channel.h |2 ++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 68dfe9f..2744fda 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -1

[Spice-devel] [PATCH 08/24] server/red_channel: add red_channel_pipe_add_after (from red_worker)

--- server/red_channel.c |8 server/red_channel.h |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 9b25f0a..68dfe9f 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -520,6 +520,14 @@ void red_chan

[Spice-devel] [PATCH 07/24] server/red_channel: make client ack window configurable

from red_worker --- server/red_channel.c |6 -- server/red_channel.h |1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index c13d972..9b25f0a 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -276,6 +276,7 @@

[Spice-devel] [PATCH 06/24] server/red_channel (tunnel): change sig of red_channel_handle_message

for later usage with red_worker --- server/red_channel.c | 11 ++- server/red_channel.h |4 +++- server/red_tunnel_worker.c |4 ++-- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 5220341..c13d972 1006

[Spice-devel] [PATCH 05/24] server/red_channel: make MAX_SEND_VEC 100

MAX_SEND_VEC was 100 for DisplayChannel's RedChannel implementation which is being replaced with RedChannel in red_channel. So changing from 50 to 100 in red_channel (make this configurble?) - effectively increased memory usage by: (100-50)*sizeof(iovec)*(num_of_channels-2) ==(arch 64bit) 50*16*6

[Spice-devel] [PATCH 04/24] server/red_channel: reflect SpiceDataHeader fields in handle_parsed_proc

--- server/inputs_channel.c |2 +- server/main_channel.c |2 +- server/red_channel.h|4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/inputs_channel.c b/server/inputs_channel.c index 2f3909e..5c7b494 100644 --- a/server/inputs_channel.c +++ b/server/i

[Spice-devel] [PATCH 03/24] server/red_channel: add red_channel_pipe_add_push

--- server/inputs_channel.c |8 server/main_channel.c | 28 ++-- server/red_channel.c|7 +++ server/red_channel.h|1 + server/smartcard.c | 10 +- 5 files changed, 31 insertions(+), 23 deletions(-) diff --git a/server/inp

[Spice-devel] [PATCH 02/24] server/red_channel: add hold_item (from red_worker)

hold_item called on init_send_data, matching release. This is not the behavior of red_worker - we ref++ (==hold_item) when sending the item, and --refs when releasing it, instead of only holding if the send is blocked. main, inputs, tunnel and smartcard channels have empty implementation. --- serv

[Spice-devel] [PATCH 01/24] server/red_channel: add out_bytes_counter (unused)

--- server/red_channel.c |3 +++ server/red_channel.h |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index a13ef0e..584b92e 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -26,6 +26,7 @@ #include #includ

[Spice-devel] [PATCH 00/24] refactor of RedChannel for RedWorker

This patchset contains changes to RedChannel API introduced to make later reuse of RedChannel in RedWorker easier. They are actually a part of a much larger patchset, too large to send to the list (92 - is that too large?). The tree with the complete set of patches is at http://cgit.freedesktop.o

[Spice-devel] Announcing spice 0.7.2

Hi All, Here is the second bugfix release in the 0.7.x development series. Major changes in 0.7.2: === * cmd-line-parser: fix wrong reporting of bad argument in --bla=val case * Server: do not depend on libcacard and CEGUI (when enabled for the client) * Server: send 1 instea

Re: [Spice-devel] [PATCH spice] server: remove dep on CEGUI

On Wed, Jan 19, 2011 at 03:01:04PM +0100, Hans de Goede wrote: > --- > configure.ac |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 8719f32..0c26b92 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -171,14 +171,12 @@ if test

[Spice-devel] [PATCH spice] server: remove dep on CEGUI

--- configure.ac |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 8719f32..0c26b92 100644 --- a/configure.ac +++ b/configure.ac @@ -171,14 +171,12 @@ if test "x$use_gui" = "xyes"; then [ AC_SUBST(CEGUI06_CFLAGS) AC_S

Re: [Spice-devel] [PATCH] spice server tests: Makefile.am: use AM_LDFLAGS (not LDFLAGS)

Ack. On 01/19/2011 11:38 AM, Uri Lublin wrote: This enables configuration using autoreconf. --- server/tests/Makefile.am | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index 11cc5f2..f93a4ad 100644 --- a/se

[Spice-devel] [PATCH] spice server tests: Makefile.am: use AM_LDFLAGS (not LDFLAGS)

This enables configuration using autoreconf. --- server/tests/Makefile.am | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index 11cc5f2..f93a4ad 100644 --- a/server/tests/Makefile.am +++ b/server/tests/Makefile.a