Re: [Spice-devel] [PATCH 1/2] server/inputs_channel: use outgoing marshaller in red_channel/RedChannel

2011-01-15 Thread Alon Levy
On Sat, Jan 15, 2011 at 08:16:49PM +0100, Hans de Goede wrote: > Hi, > > On 01/15/2011 07:57 PM, Alon Levy wrote: > >--- > > server/inputs_channel.c | 135 > > +++ > > 1 files changed, 77 insertions(+), 58 deletions(-) > > > >diff --git a/server/input

Re: [Spice-devel] [PATCH 1/2] server/inputs_channel: use outgoing marshaller in red_channel/RedChannel

2011-01-15 Thread Hans de Goede
Hi, On 01/15/2011 07:57 PM, Alon Levy wrote: --- server/inputs_channel.c | 135 +++ 1 files changed, 77 insertions(+), 58 deletions(-) diff --git a/server/inputs_channel.c b/server/inputs_channel.c index e53a634..b230866 100644 --- a/server/inputs

[Spice-devel] [PATCH 2/2] server/red_channel: fix segfault on red_channel_destroy if peer already removed

2011-01-15 Thread Alon Levy
--- server/red_channel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 40f3a1f..a13ef0e 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -365,7 +365,7 @@ void red_channel_destroy(RedChannel *channel) void

[Spice-devel] [PATCH 1/2] server/inputs_channel: use outgoing marshaller in red_channel/RedChannel

2011-01-15 Thread Alon Levy
--- server/inputs_channel.c | 135 +++ 1 files changed, 77 insertions(+), 58 deletions(-) diff --git a/server/inputs_channel.c b/server/inputs_channel.c index e53a634..b230866 100644 --- a/server/inputs_channel.c +++ b/server/inputs_channel.c @@ -72,10

[Spice-devel] [PATCH 0/2] redo of nacked patch from main channel split + segfault fix

2011-01-15 Thread Alon Levy
Redid the marshaller reuse patch to read kbd state during push, not during marshalling (and in general, like Hans pointed out, marshalling code should be sideeffect free). Also spotted a segfault that happened occasionally when disconnecting a client, including the fix as second patch. Alon Levy

Re: [Spice-devel] [Qemu-devel] paravirtual mouse/tablet

2011-01-15 Thread Peter Maydell
On 14 January 2011 09:37, Anthony Liguori wrote: [multitouch] > Surely, evdev has an interface to support this already.  Let's just do what > it does instead of inventing something that none of us can validate actually > works. > > Or better yet, delay implementing it until someone actually knows

Re: [Spice-devel] [Qemu-devel] paravirtual mouse/tablet

2011-01-15 Thread Alon Levy
On Fri, Jan 14, 2011 at 04:13:29PM +0100, Gerd Hoffmann wrote: > Hi, > > >So it'd end up being (x,y,pressure) N times (I think 16 is fine for > >the foreseeable future). > > I'd tend to extend MOVE to (x,y,pressure,index) and send N events > with the same timestamp. Needs to send only as many