[Spice-devel] [PATCH 5/5] vdservice/vdi_port refactor: cosmetic changes

2011-01-02 Thread Alon Levy
* move comment about ring to the proper file, vdi_port.h * introduce enums for EVENT indices (0,1 for Virtio, 0 for PCI) * move fill_events to cpp (leave the single lines inline). --- vdservice/pci_vdi_port.cpp|4 ++ vdservice/pci_vdi_port.h | 113 +

[Spice-devel] [PATCH 4/5] vdi_port refactor: introduce old pci_vdi_port

2011-01-02 Thread Alon Levy
This patch is a little dirty due to EOL convertion to windows format. + add pci_vdi_port with PCIVDIPort taken from last commit before changing to virtio-serial (a17ccbf323768c3cb977f0f062366ba7cf7f19db) + move handle_error to VDIPort (identical in VIRTIOVDIPort and PCIVDIPort) + make VDServi

[Spice-devel] [PATCH 3/5] vdi_port refactor: move ring handling to VDIPort, split h file, remove some debug prints

2011-01-02 Thread Alon Levy
--- vdservice/vdi_port.cpp| 76 +++ vdservice/vdi_port.h | 57 ++ vdservice/vdservice.cpp |4 +-- vdservice/virtio_vdi_port.cpp | 78 ++-- vdservice/virtio_vdi_port.

[Spice-devel] [PATCH 2/5] vdi_port refactor: introduce interface

2011-01-02 Thread Alon Levy
make VDIPort an abstract class. rename old VDIPort VirtioVDIPort. h file for virtio_vdi_port will be introduced later. --- vdservice/vdi_port.cpp| 242 - vdservice/vdi_port.h | 44 +--- vdservice/vdservice.cpp |4 +- vdservi

[Spice-devel] [PATCH 1/5] start refactoring vdi_port

2011-01-02 Thread Alon Levy
introduce VDIPort::get_num_events and VDIPort::fill_events, change VDService::_events to be dynamically allocated document _events contents: STATIC events, then vdi_port, then agent. --- vdservice/vdi_port.cpp |2 +- vdservice/vdi_port.h| 17 +++-- vdservice/vdservice.cpp | 83 +++

[Spice-devel] [PATCH 0/5] backport PCI vdi_port

2011-01-02 Thread Alon Levy
add back support to the old PCI vdi port while maintaining support for the newer virtio-serial port. VDIPort becomes a base class, with two implementations, and vdservice tries for virtio-serial, then pci. Tested on RHEL55 with PCI port with windows XP and on upstream qemu with virtio-serial with

Re: [Spice-devel] [PATCH 4/4] vdi_port refactor: introduce old pci_vdi_port

2011-01-02 Thread Arnon Gilboa
Alon Levy wrote: This patch is a little dirty due to EOL convertion to windows format. isn't it dos eol in all files of this solution? + add pci_vdi_port with PCIVDIPort taken from last commit before changing to virtio-serial (a17ccbf323768c3cb977f0f062366ba7cf7f19db) + move handle_error

Re: [Spice-devel] [PATCH 1/4] start refactoring vdi_port

2011-01-02 Thread Alon Levy
On Sun, Jan 02, 2011 at 01:33:55PM +0200, Arnon Gilboa wrote: > Alon Levy wrote: > >introduce VDIPort::get_num_events and VDIPort::fill_events, > >change VDService::_events to be dynamically allocated > >document _events contents: STATIC events, then vdi_port, then agent. > >--- > > vdservice/vdi_p

Re: [Spice-devel] [PATCH 3/4] vdi_port refactor: move ring handling to VDIPort, split h file, remove some debug prints

2011-01-02 Thread Arnon Gilboa
ACK Alon Levy wrote: --- vdservice/vdi_port.cpp| 76 +++ vdservice/vdi_port.h | 57 ++ vdservice/vdservice.cpp |4 +-- vdservice/virtio_vdi_port.cpp | 78 ++-- 4

Re: [Spice-devel] [PATCH 2/4] vdi_port refactor: introduce interface

2011-01-02 Thread Arnon Gilboa
Alon Levy wrote: make VDIPort an abstract class. rename old VDIPort VirtioVDIPort. did u use git mv? h file for virtio_vdi_port will be introduced later. haven't seen it on later patches... --- vdservice/vdi_port.cpp| 242 - vdservice/vd

Re: [Spice-devel] [PATCH 1/4] start refactoring vdi_port

2011-01-02 Thread Arnon Gilboa
Alon Levy wrote: introduce VDIPort::get_num_events and VDIPort::fill_events, change VDService::_events to be dynamically allocated document _events contents: STATIC events, then vdi_port, then agent. --- vdservice/vdi_port.cpp |2 +- vdservice/vdi_port.h| 17 +++-- vdservice/vdser