[Spice-devel] [PATCH 4/4] vdi_port refactor: introduce old pci_vdi_port

2010-12-30 Thread Alon Levy
This patch is a little dirty due to EOL convertion to windows format. + add pci_vdi_port with PCIVDIPort taken from last commit before changing to virtio-serial (a17ccbf323768c3cb977f0f062366ba7cf7f19db) + move handle_error to VDIPort (identical in VIRTIOVDIPort and PCIVDIPort) + make VDServi

[Spice-devel] [PATCH 3/4] vdi_port refactor: move ring handling to VDIPort, split h file, remove some debug prints

2010-12-30 Thread Alon Levy
--- vdservice/vdi_port.cpp| 76 +++ vdservice/vdi_port.h | 57 ++ vdservice/vdservice.cpp |4 +-- vdservice/virtio_vdi_port.cpp | 78 ++-- 4 files changed, 92 insert

[Spice-devel] [PATCH 2/4] vdi_port refactor: introduce interface

2010-12-30 Thread Alon Levy
make VDIPort an abstract class. rename old VDIPort VirtioVDIPort. h file for virtio_vdi_port will be introduced later. --- vdservice/vdi_port.cpp| 242 - vdservice/vdi_port.h | 44 +--- vdservice/vdservice.cpp |4 +- vdservi

[Spice-devel] [PATCH 1/4] start refactoring vdi_port

2010-12-30 Thread Alon Levy
introduce VDIPort::get_num_events and VDIPort::fill_events, change VDService::_events to be dynamically allocated document _events contents: STATIC events, then vdi_port, then agent. --- vdservice/vdi_port.cpp |2 +- vdservice/vdi_port.h| 17 +++-- vdservice/vdservice.cpp | 83 +++

[Spice-devel] [PATCH 0/4] backport PCI vdi_port

2010-12-30 Thread Alon Levy
add back support to the old PCI vdi port while maintaining support for the newer virtio-serial port. VDIPort becomes a base class, with two implementations, and vdservice tries for virtio-serial, then pci. Tested on RHEL55 with PCI port with windows XP and on upstream qemu with virtio-serial with

[Spice-devel] [PATCH] Added initial connection url handling using the uriparser library for proper URI parsing and handling. Can handle port, tls-port and password for now.

2010-12-30 Thread Tiziano Müller
Question is whether we want another dependency in spicec or not. On the other hand is URI processing not as trivial as it seems. Maybe making it a configure flag? For spice-gtk glib would provide similar routines to parse URI strings. --- client/application.cpp | 61 +++

Re: [Spice-devel] [PATCH] mingw32 jpeg_boolean breakeage

2010-12-30 Thread Tiziano Müller
Hi Alan Sorry for the breakage. Yes, your fix still works fine here. Cheers, Tiziano Am Donnerstag, den 30.12.2010, 12:13 +0200 schrieb Alon Levy: > The application of Tiziano's fix was hasty of me, it breaks the mingw32 build. > > Tiziano, can you test the provided patch? it works for me on mi

[Spice-devel] [PATCH] mingw32: refix to build on mingw..

2010-12-30 Thread Alon Levy
--- client/jpeg_decoder.cpp |2 +- client/mjpeg_decoder.cpp |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/jpeg_decoder.cpp b/client/jpeg_decoder.cpp index 18be6ae..f7aba76 100644 --- a/client/jpeg_decoder.cpp +++ b/client/jpeg_decoder.cpp @@ -20,7 +20,7 @@

[Spice-devel] [PATCH] mingw32 jpeg_boolean breakeage

2010-12-30 Thread Alon Levy
The application of Tiziano's fix was hasty of me, it breaks the mingw32 build. Tiziano, can you test the provided patch? it works for me on mingw32 and normal (i.e. linux in my case) builds. Alon Levy (1): mingw32: refix to build on mingw.. client/jpeg_decoder.cpp |2 +- client/mjpeg_de

Re: [Spice-devel] [PATCH] mingw32: specify packing alignment to 1 byte, to override -mms-bitfield

2010-12-30 Thread Alon Levy
On Wed, Dec 29, 2010 at 04:14:49PM +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > Ex: G_STRUCT_OFFSET(SpiceLinkReply, num_channel_caps) is 172 bytes > when compiled with -mms-bitfield, and 170 bytes without. > > GLib/Gtk are compiled with -mms-bitfield, and it is necessary to > co

Re: [Spice-devel] About the QXL update_area processing

2010-12-30 Thread Alon Levy
On Wed, Dec 29, 2010 at 10:45:11PM +0800, lin gu wrote: > but these is no called qxl_worker_update_area,except > "dispatcher->base.update_area = qxl_worker_update_area". > You could use systemtap or just add a printf to see who/when it is actually called, and if you just want to find out statica

Re: [Spice-devel] current master doesn't build with libjpeg

2010-12-30 Thread Alon Levy
On Wed, Dec 29, 2010 at 04:08:17PM +0200, Alon Levy wrote: > On Wed, Dec 29, 2010 at 02:38:53PM +0100, Tiziano Müller wrote: > > Hi > > > > The current master doesn't build here on Gentoo Linux with jpeg-8b and I > > guess it doesn't for many others. > > > > Attached patch changes the detection f

Re: [Spice-devel] connection-URL for spice

2010-12-30 Thread Alon Levy
On Wed, Dec 29, 2010 at 04:37:02PM +0100, Tiziano Müller wrote: > Am Sonntag, den 26.12.2010, 20:52 +0100 schrieb Marc-André Lureau: > > Hi > > > > On Fri, Dec 24, 2010 at 1:22 PM, Tiziano Müller > > wrote: > > > Hi everyone > > > > > > What do you think about having a spice URL (scheme)? > > > T

Re: [Spice-devel] connection-URL for spice

2010-12-30 Thread Alon Levy
On Wed, Dec 29, 2010 at 04:51:36PM +0100, Tiziano Müller wrote: > Am Sonntag, den 26.12.2010, 09:55 +0200 schrieb Alon Levy: > > On Fri, Dec 24, 2010 at 01:22:38PM +0100, Tiziano Müller wrote: > > > Hi everyone > > > > > > What do you think about having a spice URL (scheme)? > > > The idea behind