Re: [Spice-devel] [PATCH] build: make it silent

2010-11-12 Thread Hans de Goede
Hi, On 11/12/2010 01:38 PM, Marc-André Lureau wrote: This patch make it easier to spot warnings in compilation. It should work with older versions of automake that don't support silent rules. I personally don't like this as I like seeing what cflags are used when compiling. But maybe others

Re: [Spice-devel] [PATCH] client inputs: stop blinking keyboard when out of focus

2010-11-12 Thread Hans de Goede
Hi, Looks good, ack. Regards, Hans On 11/12/2010 01:37 PM, Marc-André Lureau wrote: We could introduce another boolean to prevent changes, or just reuse _active_modifiers_event = true to prevent further update until the focus comes back. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=62

Re: [Spice-devel] [PATCH] build: require c99 and fix uint64_t format warning on 32bits

2010-11-12 Thread Hans de Goede
Hi, Patch looks good (although I don't understand why you put the 2 of them in 1 patch). Do you already have a freedesktop.org account so that you can push git changes yourself? If not please request one, following this procedure: http://www.freedesktop.org/wiki/AccountRequests Regards, Hans

[Spice-devel] [PATCH] build: require c99 and fix uint64_t format warning on 32bits

2010-11-12 Thread Marc-André Lureau
--- configure.ac |5 + server/reds.c |6 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0ab6dd8..ec0f5f1 100644 --- a/configure.ac +++ b/configure.ac @@ -18,6 +18,11 @@ SPICE_COMMON_SRCDIR='$(top_srcdir)'/common AS_IF([test "

[Spice-devel] [PATCH] build: make it silent

2010-11-12 Thread Marc-André Lureau
This patch make it easier to spot warnings in compilation. It should work with older versions of automake that don't support silent rules. If you want verbose build, make V=1. --- configure.ac |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac i

[Spice-devel] [PATCH] client inputs: stop blinking keyboard when out of focus

2010-11-12 Thread Marc-André Lureau
We could introduce another boolean to prevent changes, or just reuse _active_modifiers_event = true to prevent further update until the focus comes back. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=626975 --- client/inputs_channel.cpp |9 + client/inputs_channel.h |1 + 2

[Spice-devel] [PATCH] build: require c99 and fix uint64_t format warning on 32bits

2010-11-12 Thread Marc-André Lureau
--- configure.ac |5 + server/reds.c |6 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0ab6dd8..ec0f5f1 100644 --- a/configure.ac +++ b/configure.ac @@ -18,6 +18,11 @@ SPICE_COMMON_SRCDIR='$(top_srcdir)'/common AS_IF([test "