Re: [Spice-devel] [PATCH 0/3] usb-linux do not send unnecessary GET_CONFIGURATION

2010-11-09 Thread Gerd Hoffmann
Hi, It failed at the first device I threw at it (a usb keychain picture frame), the problem is that this (el cheapo) device does not seem to grok GET_CONFIGURATION. This patch sets makes this device work (and stops qemu from unnecessary sending a GET_CONFIGURATION ctrl msg in general) by readi

Re: [Spice-devel] [PATCH spice 1/3] spicec: Fix info layer sometimes not showing

2010-11-09 Thread Alon Levy
ACK all three. Good catch on the info layer. On Tue, Nov 09, 2010 at 11:48:01AM +0100, Hans de Goede wrote: > Currently we are calling show_info_layer from hide_gui in application.cpp, but > there are 2 cases where this does not happen: > > 1) When compiled without gui support hide_gui is a compl

[Spice-devel] [PATCH spice 3/3] spicec: Don't show gui when connection info is specified on the cmdline

2010-11-09 Thread Hans de Goede
Currently when compiled with the gui enabled if you specify a host to connect to on the cmdline the gui flashes by (show_gui gets called, then the connect handler calls hide_gui as soon as the connection is made). This patch removes this ugly flashing by of the gui. --- client/application.cpp |

[Spice-devel] [PATCH spice 2/3] spicec: Remove empty show / hide gui functions

2010-11-09 Thread Hans de Goede
When compiling without gui support just don't call show / hide gui, rather then making them stubs, this makes it easier to follow what is going on. --- client/application.cpp |4 client/application.h |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client/appl

[Spice-devel] [PATCH spice 1/3] spicec: Fix info layer sometimes not showing

2010-11-09 Thread Hans de Goede
Currently we are calling show_info_layer from hide_gui in application.cpp, but there are 2 cases where this does not happen: 1) When compiled without gui support hide_gui is a complete nop, so we never show the info layer when compiled without gui support 2) When run with --controller we never