Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Yaniv Kaul
On 9/30/2010 11:00 PM, Alexander Larsson wrote: On Thu, 2010-09-30 at 22:22 +0200, Gerd Hoffmann wrote: Hi, If this is the plan we need to ensure that the APIs and implementations are not tied to tightly to unix. I have some X11 MIT-SHM bits in there for performance reasons, that needs to be

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
On Thu, 2010-09-30 at 22:18 +0200, Gerd Hoffmann wrote: > On 09/30/10 20:41, Alexander Larsson wrote: > > On Thu, 2010-09-30 at 14:48 +0200, Alexander Larsson wrote: > > > >> More later... > > > > Bit more before I disappear: > > > > why do you have a spice_channel_destroy()? Its a gobject, just un

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
On Thu, 2010-09-30 at 22:22 +0200, Gerd Hoffmann wrote: > Hi, > > >> If this is the plan we need to ensure that > >> the APIs and implementations are not tied to tightly to unix. > > > > I have some X11 MIT-SHM bits in there for performance reasons, that > > needs to be #ifdef'ed and have a altern

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
On Thu, 2010-09-30 at 22:08 +0200, Gerd Hoffmann wrote: > > "spice_watch", "spice_msg_out" etc is a pretty uncommon capitalization > > for Gtk+/GObject APIs. Generally all (public) types are CamelCase. > > spice_msg_out I want keep internal. Right now it isn't but I want > figure a way to chang

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Gerd Hoffmann
Hi, If this is the plan we need to ensure that the APIs and implementations are not tied to tightly to unix. I have some X11 MIT-SHM bits in there for performance reasons, that needs to be #ifdef'ed and have a alternative (generic cairo/pixman based?) implementation for !x11 platforms. Other

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Gerd Hoffmann
On 09/30/10 20:41, Alexander Larsson wrote: On Thu, 2010-09-30 at 14:48 +0200, Alexander Larsson wrote: More later... Bit more before I disappear: why do you have a spice_channel_destroy()? Its a gobject, just unref it. spice_channel_destroy actually just does a unref (+ debug printf) now.

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Gerd Hoffmann
Hi, I had a quick look at this. It seems this is a re-write of a client implementation (based on the existing code i guess). Yes, basically all C++ code. I don't necessarily disagree with this (as the current code isn't exactly well suited for librarification), but this is a pretty big chu

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
On Thu, 2010-09-30 at 14:48 +0200, Alexander Larsson wrote: > More later... Bit more before I disappear: why do you have a spice_channel_destroy()? Its a gobject, just unref it. I don't like that you have three libs. We've learned this lesson in gnome by now: It seems that splitting things up i

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
On Wed, 2010-09-29 at 12:07 +0200, Gerd Hoffmann wrote: > Hi folks, > > /me proudly presents some early glib/gtk bits for the client side of the > spice protocol. The code is available in the gtk.v2 branch in my > personal spice repo @ freedesktop.org: > >http://cgit.freedesktop.org/~kraxe

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model (v2)

2010-09-30 Thread Gerd Hoffmann
Hi, The grab command is being changed so that it takes an array of types rather then a single type, Ah, ok, so we will pass a list not a single type. That answers my question already ;) VD_AGENT_CLIPBOARD_UTF8_TEXT VD_AGENT_CLIPBOARD_HTML Good. cheers, Gerd __

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model (v2)

2010-09-30 Thread Hans de Goede
Hi, On 09/30/2010 11:20 AM, Gerd Hoffmann wrote: Hi, not done yet: -clipboards formats are still uint32_t, not mime types stores as strings What is the plan for multiple formats? When copying something in firefox it provides both UTF8_STRING and text/html (and a few others too). When so

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model (v2)

2010-09-30 Thread Gerd Hoffmann
Hi, not done yet: -clipboards formats are still uint32_t, not mime types stores as strings What is the plan for multiple formats? When copying something in firefox it provides both UTF8_STRING and text/html (and a few others too). cheers, Gerd _