Re: [Spice-devel] 0.6.1 release and cut and paste

2010-09-27 Thread Arnon Gilboa
the issue is that currently i'm spending ~70% of my time on non-clipboard stuff... Hans de Goede wrote: Hi, On 09/27/2010 04:45 PM, Arnon Gilboa wrote: +1 to your "0.6.1 now". what's the cons of c&p only in 0.6.2 (in a week or 2!) ? Well we could also just delay 0.6.1 a bit, that means sl

Re: [Spice-devel] 0.6.1 release and cut and paste

2010-09-27 Thread Hans de Goede
Hi, On 09/27/2010 04:45 PM, Arnon Gilboa wrote: +1 to your "0.6.1 now". what's the cons of c&p only in 0.6.2 (in a week or 2!) ? Well we could also just delay 0.6.1 a bit, that means slightly less work and updates churn. Regards, Hans Hans de Goede wrote: Hi All, As discussed before we

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model

2010-09-27 Thread Hans de Goede
Hi, On 09/27/2010 04:51 PM, Arnon Gilboa wrote: Hans de Goede wrote: Hi, On a second review I've found some more issues with the X11 client copy paste code, note some of this were already present before the patch in question. 1) You're using the XA_PRIMARY selection, this is the one which ge

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model

2010-09-27 Thread Arnon Gilboa
Hans de Goede wrote: Hi, On a second review I've found some more issues with the X11 client copy paste code, note some of this were already present before the patch in question. 1) You're using the XA_PRIMARY selection, this is the one which gets set as soon as you select anything with the

Re: [Spice-devel] 0.6.1 release and cut and paste

2010-09-27 Thread Arnon Gilboa
+1 to your "0.6.1 now". what's the cons of c&p only in 0.6.2 (in a week or 2!) ? Hans de Goede wrote: Hi All, As discussed before we are going to do a 0.6.1 release soon, looking at git: http://cgit.freedesktop.org/spice/spice/log/ We have a number of very worthwhile small fixes queued up. A

[Spice-devel] 0.6.1 release and cut and paste

2010-09-27 Thread Hans de Goede
Hi All, As discussed before we are going to do a 0.6.1 release soon, looking at git: http://cgit.freedesktop.org/spice/spice/log/ We have a number of very worthwhile small fixes queued up. And cut and paste support is in the works, the big question is do we wait for cut and paste support to be

Re: [Spice-devel] [PATCH] client: port for Mac OS X

2010-09-27 Thread Hans de Goede
Hi, Can you please split this in 3 patches: 1) General apple port stuff 2) epoll -> select changes 3) copyright header fixes Regards, Hans On 09/26/2010 02:57 PM, Attila Sukosd wrote: Hi All, I finally had a bit of time to gather the changes to the spice client in order to get it working u

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model

2010-09-27 Thread Arnon Gilboa
Hans de Goede wrote: 2) I believe we should not add bitmap support until we've a platform independent way of doing this. Adding features prematurely only leads to troubles down the road later (see the defunct before even really used old clipboard capability flag for example). will be removed u

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model

2010-09-27 Thread Hans de Goede
Hi, On a second review I've found some more issues with the X11 client copy paste code, note some of this were already present before the patch in question. 1) You're using the XA_PRIMARY selection, this is the one which gets set as soon as you select anything with the mouse cursor, no nee

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model

2010-09-27 Thread Hans de Goede
Hi, On 09/26/2010 11:28 AM, Arnon Gilboa wrote: 1) I see no need for platform.h to contain a duplicate enum with vd_agent.h we should simply use the VD_AGENT_CLIPBOARD_* types in the platform code too, this way we can get rid of this enum, the ClipboardType type, the clipboard_types array an

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model

2010-09-27 Thread Hans de Goede
Hi, On 09/26/2010 10:34 AM, Arnon Gilboa wrote: Alexander Larsson wrote: On Wed, 2010-09-22 at 14:16 +0200, Arnon Gilboa wrote: utf8_atom = XInternAtom(x_display, "UTF8_STRING", False); + + Platform::clipboard_formats[0].format = utf8_atom; + Platform::clipboard_formats[0].type = Platform::CLI

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-27 Thread Hans de Goede
Hi, On 09/26/2010 10:15 AM, Arnon Gilboa wrote: So far, the clipboard support was disabled in the agent side, so I see no real need for supporting the two different clipboard flows and complicating the behavior in both sides. I suggest removing the support for the "old clipboard" (VD_AGENT_CAP