[Spice-devel] [PATCH] vdservice: use "com.redhat.spice.0" symbolic link as virtio-serial port path

2010-09-21 Thread Arnon Gilboa
remove get_device_path() by GUID & dependency on setupapi.lib --- vdservice/vdi_port.cpp | 64 +-- vdservice/vdservice.vcproj |8 +++--- 2 files changed, 6 insertions(+), 66 deletions(-) diff --git a/vdservice/vdi_port.cpp b/vdservice/vdi_port.cpp

[Spice-devel] [PATCH 5/5] server: Handle self_image in localize_bitmap

2010-09-21 Thread alexl
From: Alexander Larsson When drawing a drawable with a NULL src bitmap that means we should be using the previously generated self_bitmap. Not doing this causes a segfault due to accessing the NULL. --- server/red_worker.c | 25 - 1 files changed, 16 insertions(+), 9 de

[Spice-devel] [PATCH 4/5] server: Handle NULL image in red_update_streamable

2010-09-21 Thread alexl
From: Alexander Larsson A NULL src bitmap means self_bitmap, which is not a stream, so abort. --- server/red_worker.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5a2477a..f307aef 100644 --- a/server/red_worker.c +++ b

[Spice-devel] [PATCH 3/5] server: Use the right image size for self_bitmap

2010-09-21 Thread alexl
From: Alexander Larsson The self_bitmap is the size of self_bitmap_area, not the bbox. This is especially important since we later copy the self_bitmap_area into the new bitmap, and if that is larger than bbox then we will overwrite random memory. --- server/red_worker.c |4 ++-- 1 files cha

[Spice-devel] [PATCH 2/5] server: Don't leak QUIC image chunks

2010-09-21 Thread alexl
From: Alexander Larsson red_put_image() needs to free the chunks for QUIC images, as we allocate these when creating the image. --- server/red_parse_qxl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index 5b32f6b..ab0

[Spice-devel] [PATCH 1/5] Fix crash when resetting pixman image transform

2010-09-21 Thread alexl
From: Alexander Larsson Resetting the transform is done by setting it to the identity transform, not passing in NULL. Passing in NULL causes a crash. --- common/canvas_base.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c in

[Spice-devel] [PATCH 0/5] Fix bugs found by WHQL

2010-09-21 Thread alexl
From: Alexander Larsson I've been playing with an old WHQL display test running various rendering tests to see how we stack up. During this testing I found a bunch of crashes and leaks, fixed in this series. Alexander Larsson (5): Fix crash when resetting pixman image transform server: Don't

Re: [Spice-devel] RFC: spice vdagent protocol documentation

2010-09-21 Thread Hans de Goede
Hi, Alon, Thanks for the feedback! On 09/01/2010 04:42 PM, Alon Levy wrote: - "Hans de Goede" wrote: Hi All, This is a first draft version / a first attempt to document the spice vdagent protocol. This is meant to eventually go to the wiki. Question where on the wiki should I put this

[Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-21 Thread Arnon Gilboa
-enable the clipboard support -support the GRAB/REQUEST/DATA/RELEASE verbs in both ways. -pasting clipboard data is now "only-by-demand" from both sides (client and agent), whose behavior is symmetric. -client and agent don't read or send the contents of the clipboard unnecessarily (e.g. copy, in

[Spice-devel] [PATCH] vdservice: replace VDAgentDataChunk with VDIChunkHeader

2010-09-21 Thread Arnon Gilboa
--- vdservice/vdi_port.cpp |2 +- vdservice/vdservice.cpp | 12 +++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/vdservice/vdi_port.cpp b/vdservice/vdi_port.cpp index 0d5c0e1..8af95b2 100644 --- a/vdservice/vdi_port.cpp +++ b/vdservice/vdi_port.cpp @@ -91,7 +91,7

[Spice-devel] [PATCH] vdservice: cleanup vcprojs

2010-09-21 Thread Arnon Gilboa
-remove deprecated Detect64BitPortabilityProblems -add setupapi.lib to AdditionalDependencies in x64 --- vdagent/vdagent.vcproj | 157 --- vdservice/vdservice.vcproj | 160 +--- 2 files changed, 2 insertions(+),

Re: [Spice-devel] [PATCH 00/17] Win32 driver thread safety

2010-09-21 Thread Alexander Larsson
On Tue, 2010-09-14 at 21:08 +0200, al...@redhat.com wrote: > From: Alexander Larsson Izik reviewed all of these and found no issues, and i've been running it for a while without issues, so i'm pushing it now. However, if anyone has time please do review this anyway as there is a non-neglible ris

[Spice-devel] Spice roadmap

2010-09-21 Thread Stephen Duse-Anthony
HI, I would like to know if you have a roadmap with an ETA for the following features: Network tunneling: - usb device redirection - CD-ROM redirection - Printer redirection   Thanks and best regards, Stephen ___ Spice-devel mailing list Spice-

Re: [Spice-devel] [PATCH] vd_agent: add protocol messages for clipboard/selection-owner model

2010-09-21 Thread Hans de Goede
Hi, On 09/21/2010 09:31 AM, Arnon Gilboa wrote: pasting clipboard data is now "only-by-demand" from both sides (client and agent), whose behavior is symmetric. -VD_AGENT_CLIPBOARD_GRAB(type) - tell the other side that an application in our side ("we") got ownership of the clipboard. -VD_AGENT

[Spice-devel] [PATCH] vd_agent: add protocol messages for clipboard/selection-owner model

2010-09-21 Thread Arnon Gilboa
pasting clipboard data is now "only-by-demand" from both sides (client and agent), whose behavior is symmetric. -VD_AGENT_CLIPBOARD_GRAB(type) - tell the other side that an application in our side ("we") got ownership of the clipboard. -VD_AGENT_CLIPBOARD_REQUEST(type) - after we know the other