Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 17:28 +0200, Gerd Hoffmann wrote: > Hi, > > > Having a more fine-grained command line feature selection just causes > > complexity and risk that sysadmins get things wrong. I don't see any > > gain in it. > > Point. > > > I'll note that this switch is really only about migr

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
Hi, Having a more fine-grained command line feature selection just causes complexity and risk that sysadmins get things wrong. I don't see any gain in it. Point. I'll note that this switch is really only about migration compatibility. Any reason to add this now? We could delay it until

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 15:08 +0200, Gerd Hoffmann wrote: > >> As you are talking about "set of features" already ... > >> > >> I think we should use a feature bitmask instead of a version number in > >> the API. > > > > How would you use this in qemu though? Say you link to spice 0.10.0, > > which h

[Spice-devel] [PATCH 0/1] Partial fix for office2007 redraw issue (#28084)

2010-08-27 Thread alexl
From: Alexander Larsson I tracked down the power point 2007 scrollbar rendering issue today. Its caused by the scaling in pixman. When drawing the scrollbar ppt renders a 16x1 region of a larger image to the destination rect of the whole scrollbar. I.e. it will be scaling the 16x1 region to somet

[Spice-devel] [PATCH 1/1] canvas: Better coordinate rounding in scaling

2010-08-27 Thread alexl
From: Alexander Larsson When scaling in pixman you give the source coordinates in transformed space rather than in the source coordinates. This is a bit problematic when both source and destination coordinates are at integer positions, but the scaling factor is not an exact 16.16 fixed point valu

[Spice-devel] [PATCH] Add config functions.

2010-08-27 Thread Gerd Hoffmann
A bunch of configuration functions where never ported forward from rhel-6 to upstream. Add them so we can add qemu config options for these settings. --- server/reds.c | 27 +++ server/spice.h | 11 +++ 2 files changed, 38 insertions(+), 0 deletions(-) diff -

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
As you are talking about "set of features" already ... I think we should use a feature bitmask instead of a version number in the API. How would you use this in qemu though? Say you link to spice 0.10.0, which has a set of new features not in 0.8.0. Why would you want to make a spice instance t

Re: [Spice-devel] [PATCH 1/2] server: Don't send stream frames that are identical to the last one

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 10:49 +0300, Yaniv Kaul wrote: > On 2010-08-26 18:33, Yonit Halperin wrote: > > On 08/25/2010 11:49 AM, al...@redhat.com wrote: > >> From: Alexander Larsson > >> > >> This happens e.g. with the vlc player when paused, as it still draws > >> a continuous stream of frames (bug #

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 09:16 +0200, Gerd Hoffmann wrote: > Hi, > > > This API allows qemu to limit the set of features that spice uses to > > those compatible with an older version, in order to do an upgrade like > > this. Right now it doesn't really do much, since we don't keep compat > > with 0.4

[Spice-devel] Virtualization project idea

2010-08-27 Thread Dhananjay Goel
Hi there! First I'd like to say that Spice platform is really cool and awesome. I'm an engineering student and is searching for a feasible project in virtualization. I'd like to know if its possible to share USB devices (flash drive, hard disk, mouse, keyboards etc) across guests and host (VMs).

Re: [Spice-devel] [PATCH 3/5] zap dead qxl chunk code

2010-08-27 Thread Gerd Hoffmann
On 08/27/10 08:56, Alexander Larsson wrote: On Fri, 2010-08-27 at 08:49 +0200, Gerd Hoffmann wrote: On 08/27/10 08:41, Alexander Larsson wrote: On Fri, 2010-08-27 at 00:09 +0200, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- server/red_worker.c | 29 -

Re: [Spice-devel] [PATCH 1/2] server: Don't send stream frames that are identical to the last one

2010-08-27 Thread Yaniv Kaul
On 2010-08-26 18:33, Yonit Halperin wrote: On 08/25/2010 11:49 AM, al...@redhat.com wrote: From: Alexander Larsson This happens e.g. with the vlc player when paused, as it still draws a continuous stream of frames (bug #28817). It may also help slightly if a video contains identical frames in

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
Hi, This API allows qemu to limit the set of features that spice uses to those compatible with an older version, in order to do an upgrade like this. Right now it doesn't really do much, since we don't keep compat with 0.4.0 atm (although that may be added later). As you are talking about "s