Re: [Spice-devel] [PATCH] windows client: add --include "common.h"-- for generated demarshallers

2010-06-23 Thread Alexander Larsson
On Wed, 2010-06-23 at 17:53 +0300, Yonit Halperin wrote: > On 06/23/2010 05:53 PM, Alexander Larsson wrote: > > On Wed, 2010-06-23 at 14:29 +0300, Yonit Halperin wrote: > >> --- > >> client/windows/generate.bat |2 +- > >> client/windows/generate1.bat |2 +- > >> 2 files changed, 2 ins

Re: [Spice-devel] [PATCH] windows client: add --include "common.h"-- for generated demarshallers

2010-06-23 Thread Yonit Halperin
On 06/23/2010 05:53 PM, Alexander Larsson wrote: On Wed, 2010-06-23 at 14:29 +0300, Yonit Halperin wrote: --- client/windows/generate.bat |2 +- client/windows/generate1.bat |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/windows/generate.bat b/client/wi

Re: [Spice-devel] [PATCH] windows client: add --include "common.h"-- for generated demarshallers

2010-06-23 Thread Alexander Larsson
On Wed, 2010-06-23 at 14:29 +0300, Yonit Halperin wrote: > --- > client/windows/generate.bat |2 +- > client/windows/generate1.bat |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/client/windows/generate.bat b/client/windows/generate.bat > index 1bb62b4..6bd06d7

Re: [Spice-devel] [PATCH] fix for not clearing the cursor ring when the primary surface is destroyed

2010-06-23 Thread Yonit Halperin
On 06/23/2010 04:57 PM, Gerd Hoffmann wrote: -static int red_process_cursor(RedWorker *worker, uint32_t max_pipe_size) +static int red_process_cursor(RedWorker *worker, uint32_t max_pipe_size, int *ring_is_empty) { QXLCommandExt ext_cmd; int n = 0; + *ring_is_empty = FALSE; while (!worker->curso

[Spice-devel] network abi changes in master

2010-06-23 Thread Alexander Larsson
I commited the initial round of simple network protocol changes to git master (for the new protocol, not for 0.4 compat): * All pointers/offsets are now 32bit * We don't send any "padding" data for clips and brushes (e.g. we send nothing if these are not used where we used to send the length of th

Re: [Spice-devel] [PATCH] fix for not clearing the cursor ring when the primary surface is destroyed

2010-06-23 Thread Gerd Hoffmann
-static int red_process_cursor(RedWorker *worker, uint32_t max_pipe_size) +static int red_process_cursor(RedWorker *worker, uint32_t max_pipe_size, int *ring_is_empty) { QXLCommandExt ext_cmd; int n = 0; +*ring_is_empty = FALSE; while (!worker->cursor_channel || worker->

[Spice-devel] [PATCH] fix for not clearing the cursor ring when the primary surface is destroyed

2010-06-23 Thread Yonit Halperin
fixes a crash in qxl_soft_reset --- server/red_worker.c | 85 ++ 1 files changed, 71 insertions(+), 14 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index b9ada15..9bd551c 100644 --- a/server/red_worker.c +++ b/server/red_wor

[Spice-devel] [PATCH] windows client: add --include "common.h"-- for generated demarshallers

2010-06-23 Thread Yonit Halperin
--- client/windows/generate.bat |2 +- client/windows/generate1.bat |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/windows/generate.bat b/client/windows/generate.bat index 1bb62b4..6bd06d7 100644 --- a/client/windows/generate.bat +++ b/client/windows/generate

[Spice-devel] [PATCH 2/3] qxl abi: add Fill.

2010-06-23 Thread Gerd Hoffmann
Add QXLFill, also fix tyops (s/rop_decriptor/rop_descriptor/). --- spice/draw.h|2 +- spice/qxl_dev.h | 10 -- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/spice/draw.h b/spice/draw.h index e6fab5c..42cd025 100644 --- a/spice/draw.h +++ b/spice/draw.h @@ -106,7

[Spice-devel] [PATCH 3/3] qxl abi: add Opaque.

2010-06-23 Thread Gerd Hoffmann
Add QXLOpaque, also fix tyops (s/rop_decriptor/rop_descriptor/). --- spice/draw.h|2 +- spice/qxl_dev.h | 13 +++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/spice/draw.h b/spice/draw.h index 42cd025..3f277d8 100644 --- a/spice/draw.h +++ b/spice/draw.h @@ -

[Spice-devel] [PATCH 1/3] qxl abi: add AlphaBlnd.

2010-06-23 Thread Gerd Hoffmann
Add QXLAlphaBlnd and QXLCompatAlphaBlnd types. --- spice/qxl_dev.h | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 693348f..9d62905 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -303,6 +303,19 @@ typedef stru

[Spice-devel] [PATCH 0/3] qxl abi patches for spice-protocol.

2010-06-23 Thread Gerd Hoffmann
spice-protocol updates for the spice patch series just sent. Gerd Hoffmann (3): qxl abi: add AlphaBlnd. qxl abi: add Fill. qxl abi: add Opaque. spice/draw.h|4 ++-- spice/qxl_dev.h | 40 ++-- 2 files changed, 36 insertions(+), 8 deletions(-) _

[Spice-devel] [PATCH 1/6] qxl abi: parse QXLDrawable.

2010-06-23 Thread Gerd Hoffmann
--- server/Makefile.am |2 + server/red_parse_qxl.c | 88 + server/red_parse_qxl.h | 60 + server/red_worker.c| 325 4 files changed, 314 insertions(+), 161 deletions(-) create mode 100644 server/red_parse_qxl.c

[Spice-devel] [PATCH 4/6] qxl abi: parse QXLFill.

2010-06-23 Thread Gerd Hoffmann
Also adapt to tyops fix (s/rop_decriptor/rop_descriptor/). --- common/canvas_base.c |2 +- common/gl_canvas.c |2 +- server/red_parse_qxl.c | 12 ++-- server/red_worker.c|2 +- spice.proto|2 +- spice1.proto |2 +- 6 files changed, 15 i

[Spice-devel] [PATCH 6/6] qxl abi: add missing QXLCopyBits

2010-06-23 Thread Gerd Hoffmann
--- server/red_parse_qxl.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index 0620fcb..8590ec7 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -93,6 +93,9 @@ void red_get_drawable(RedMemSlotInfo *s

[Spice-devel] [PATCH 2/6] qxl abi: parse QXLCompatDrawable.

2010-06-23 Thread Gerd Hoffmann
--- server/red_parse_qxl.c | 53 server/red_parse_qxl.h |2 + server/red_worker.c|9 ++- 3 files changed, 62 insertions(+), 2 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index b22cb83..aafd75a 100644

[Spice-devel] [PATCH 5/6] qxl abi: parse QXLOpaque.

2010-06-23 Thread Gerd Hoffmann
Also adapt to tyops fix (s/rop_decriptor/rop_descriptor/). --- common/canvas_base.c |2 +- common/gl_canvas.c |4 ++-- server/red_parse_qxl.c | 23 +++ server/red_worker.c|2 +- spice.proto|2 +- spice1.proto |2 +- 6 files

[Spice-devel] [PATCH 0/6] initial qxl abi patches

2010-06-23 Thread Gerd Hoffmann
Hi, This is the start of the qxl -> spice abi translation code. It is really just a first step, but even at the current state it is good enougth to handle 0.4 spice guest drivers. Future plan is to cover all spice structs used by qxl that way. Once everything is covered no code except the qxl s

[Spice-devel] [PATCH 3/6] qxl abi: parse QXLAlphaBlnd (+Compat)

2010-06-23 Thread Gerd Hoffmann
--- server/red_parse_qxl.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index aafd75a..cbdbf72 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -20,6 +20,23 @@ #include "red_memsl

Re: [Spice-devel] [PATCH] fix use-after-free in spice_marshaller_reset

2010-06-23 Thread Alexander Larsson
On Wed, 2010-06-23 at 09:53 +0200, Gerd Hoffmann wrote: > --- > common/marshaller.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/common/marshaller.c b/common/marshaller.c > index 5844b89..ece4f48 100644 > --- a/common/marshaller.c > +++ b/common/marshaller.c >

[Spice-devel] New win32 binaries on spice-space.org

2010-06-23 Thread Alexander Larsson
I replaced the unstable win32 binaries set with a new one that includes zlib. If you want to build on win32 you'll need to update to this set. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc

[Spice-devel] [PATCH] fix use-after-free in spice_marshaller_reset

2010-06-23 Thread Gerd Hoffmann
--- common/marshaller.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/common/marshaller.c b/common/marshaller.c index 5844b89..ece4f48 100644 --- a/common/marshaller.c +++ b/common/marshaller.c @@ -157,13 +157,14 @@ static void free_items(SpiceMarshaller *m) void

[Spice-devel] [PATCH] drop bogous get_virt_delta calls

2010-06-23 Thread Gerd Hoffmann
--- server/red_worker.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 055dec7..3e0a623 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6463,10 +6463,7 @@ static int red_jpeg_compress_image(DisplayCha