[Spice-devel] [PATCH] client: handling SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST

2010-03-31 Thread Yonit Halperin
disconnecting from the current host and connecting to the target host. --- client/application.cpp | 42 +- client/application.h | 15 +++ client/red_client.cpp | 42 +++--- client/red_client.h|

Re: [Spice-devel] [PATCH] client: handling SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST

2010-03-31 Thread Yonit Halperin
On 03/31/2010 03:42 PM, Alexander Larsson wrote: On Sun, 2010-03-28 at 18:21 +0300, Yonit Halperin wrote: disconnecting from the current host and connecting to the target host. +SpiceMsgMainMigrationSwitchHost* migrate = (SpiceMsgMainMigrationSwitchHost*)message->data(); +char* host =

Re: [Spice-devel] [PATCH 0/3] spice interface redesign.

2010-03-31 Thread Alexander Larsson
On Wed, 2010-03-31 at 14:44 +0200, Gerd Hoffmann wrote: > > struct SpiceImplementation { > > SpiceBaseInterface *interface; > > }; > > > > struct SpiceKeyboard { > > SpiceImplementation parent; > > }; > > Those two are pretty simliar to SpiceInterfaceState and SpiceKbdState. > > >

Re: [Spice-devel] [PATCH 02/18] channel security cleanup

2010-03-31 Thread Alexander Larsson
On Wed, 2010-03-31 at 13:34 +0200, Gerd Hoffmann wrote: > Works for me. We could even drop > spice_server_set_default_channel_security() and use channel == NULL > for > "set default". Works for me! -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Lars

Re: [Spice-devel] [PATCH 0/3] spice interface redesign.

2010-03-31 Thread Gerd Hoffmann
struct SpiceImplementation { SpiceBaseInterface *interface; }; struct SpiceKeyboard { SpiceImplementation parent; }; Those two are pretty simliar to SpiceInterfaceState and SpiceKbdState. struct KeyboardInterface { SpiceBaseInterface base; void (*push_scan_freg)(Spi

Re: [Spice-devel] [PATCH] client: handling SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST

2010-03-31 Thread Alexander Larsson
On Sun, 2010-03-28 at 18:21 +0300, Yonit Halperin wrote: > disconnecting from the current host and connecting to the target host. +SpiceMsgMainMigrationSwitchHost* migrate = (SpiceMsgMainMigrationSwitchHost*)message->data(); +char* host = ((char*)migrate) + migrate->host_offset; +char

Re: [Spice-devel] [PATCH 0/3] spice interface redesign.

2010-03-31 Thread Alexander Larsson
On Tue, 2010-03-30 at 12:10 +0200, Gerd Hoffmann wrote: > Hi, > > This is a early, RfC patch series for a spice interface redesign. > For now only VDInterface, CoreInterface and KeyboardInterface are > touched. I'm sending them now to gather comments on the general > direction and design. Also,

Re: [Spice-devel] [PATCH 0/3] spice interface redesign.

2010-03-31 Thread Alexander Larsson
On Tue, 2010-03-30 at 12:10 +0200, Gerd Hoffmann wrote: > Hi, > > This is a early, RfC patch series for a spice interface redesign. > For now only VDInterface, CoreInterface and KeyboardInterface are > touched. I'm sending them now to gather comments on the general > direction and design. > > Th

Re: [Spice-devel] [PATCH 02/18] channel security cleanup

2010-03-31 Thread Gerd Hoffmann
On 03/31/10 11:31, Alexander Larsson wrote: On Mon, 2010-03-29 at 17:08 +0200, Gerd Hoffmann wrote: drop spice_channel_name_t enum, use spice-protocol defines instead. Hmm, i actually added the spice_channel_name_t enum when pushing this upstream for two reasons: 1) the other enum doesn't hav

Re: [Spice-devel] [PATCH 07/18] fix visibility

2010-03-31 Thread Alexander Larsson
On Mon, 2010-03-29 at 17:08 +0200, Gerd Hoffmann wrote: > diff --git a/server/spice.h b/server/spice.h > index 9ef9d1a..b61e957 100644 > --- a/server/spice.h > +++ b/server/spice.h > @@ -21,6 +21,8 @@ > #include > #include "vd_interface.h" > > +#define __visible__ __attribute__ ((visibility ("

Re: [Spice-devel] [PATCH 02/18] channel security cleanup

2010-03-31 Thread Alexander Larsson
On Mon, 2010-03-29 at 17:08 +0200, Gerd Hoffmann wrote: > drop spice_channel_name_t enum, use spice-protocol defines instead. Hmm, i actually added the spice_channel_name_t enum when pushing this upstream for two reasons: 1) the other enum doesn't have the ALL item. 2) I'm not sure we want to ha

Re: [Spice-devel] autoconf for slirp

2010-03-31 Thread Alexander Larsson
On Wed, 2010-03-31 at 08:52 +0300, Yonit Halperin wrote: > On 03/28/2010 02:30 PM, Alexander Larsson wrote: > > On Sun, 2010-03-28 at 09:03 +0300, Yonit Halperin wrote: > >> On 03/26/2010 11:45 AM, Alexander Larsson wrote: > >>> On Fri, 2010-03-26 at 10:25 +1000, Dave Airlie wrote: > this is q