Re: [Spice-devel] [PATCH 0/8] Refactoring canvas code

2010-03-08 Thread Alexander Larsson
On Mon, 2010-03-08 at 18:33 +0100, al...@redhat.com wrote: > From: Alexander Larsson > > This is a series of patches that clean up the "public" canvas API > by hiding all the internals of the canvas implementation behind > a single SpiceCanvas type with multiple constructors. It also removes > th

[Spice-devel] [PATCH 7/8] Move canvas_draw_stroke to canvas_base

2010-03-08 Thread alexl
From: Alexander Larsson --- common/cairo_canvas.c | 455 - common/canvas_base.c | 450 2 files changed, 450 insertions(+), 455 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canva

[Spice-devel] [PATCH 8/8] Move draw_rop3 to canvas_base

2010-03-08 Thread alexl
From: Alexander Larsson --- common/cairo_canvas.c | 96 - common/canvas_base.c | 94 +++ 2 files changed, 94 insertions(+), 96 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c

[Spice-devel] [PATCH 5/8] Move canvas_region and group_start/end to canvas_base

2010-03-08 Thread alexl
From: Alexander Larsson --- client/red_gdi_canvas.cpp |2 +- common/cairo_canvas.c | 37 + common/canvas_base.c | 41 - common/gdi_canvas.c |6 -- common/gdi_canvas.h |3 ++- comm

[Spice-devel] [PATCH 3/8] Make virt mapping an interface

2010-03-08 Thread alexl
From: Alexander Larsson --- common/cairo_canvas.c |9 ++--- common/cairo_canvas.h |3 +-- common/canvas_base.c | 21 +++-- common/canvas_base.h | 15 ++- common/gl_canvas.c|9 ++--- common/gl_canvas.h|3 +-- server/red_worker.c

[Spice-devel] [PATCH 2/8] Make glz_decoder non-optional canvas_base in canvas constructors

2010-03-08 Thread alexl
From: Alexander Larsson It can still be NULL, but we simplify the headers by always including it. There is no practical performance difference here. --- common/cairo_canvas.c |7 +-- common/cairo_canvas.h |2 -- common/canvas_base.c | 13 - common/gdi_canvas.c |8

[Spice-devel] [PATCH 1/8] Make canvas Glz decoder integration nicer

2010-03-08 Thread alexl
From: Alexander Larsson We use a dynamic interface similar to e.g. SpiceImageCache instead of passing both function and opaque --- client/canvas.cpp |7 --- client/canvas.h |1 - client/glz_decoder.cpp | 14 ++ client/glz_decoder.h|

[Spice-devel] [PATCH 0/8] Refactoring canvas code

2010-03-08 Thread alexl
From: Alexander Larsson This is a series of patches that clean up the "public" canvas API by hiding all the internals of the canvas implementation behind a single SpiceCanvas type with multiple constructors. It also removes the two canvas-type abstractions that existed before in server/ and in cl

Re: [Spice-devel] SPICE questions

2010-03-08 Thread Stefan Zintgraf
Thanks for the answer. The faq says: I built Spice server on a 32-bit machine and it failed. What can I do? I've read the FAQ but was not aware if it is impossible by design to get everything running on a single 32 Bit Linux. Dor said: I guess it was only tested on 64 bit host, other tha

Re: [Spice-devel] SPICE questions

2010-03-08 Thread Alexander Larsson
On Mon, 2010-03-08 at 15:34 +0100, Stefan Zintgraf wrote: > Thanks for the answer. > > > > The faq says: I built Spice server on a 32-bit machine and it failed. > What can I do? > > I've read the FAQ but was not aware if it is impossible by design to > get everything running on a single 32 Bit

Re: [Spice-devel] SPICE questions

2010-03-08 Thread Alexander Larsson
On Sun, 2010-03-07 at 22:16 +0100, Stefan Zintgraf wrote: > Hi, > > i have two questions regarding SPICE. > > a) 32-bit support > I want to run a Windows guest on a 32-Bit Ubuntu system (version 9.10). The > client shall also run on the same (32-Bit) machine. According the FAQ (and my > exper

Re: [Spice-devel] SPICE questions

2010-03-08 Thread Dor Laor
On 03/07/2010 11:16 PM, Stefan Zintgraf wrote: Hi, i have two questions regarding SPICE. a) 32-bit support I want to run a Windows guest on a 32-Bit Ubuntu system (version 9.10). The client shall also run on the same (32-Bit) machine. According the FAQ (and my experience...) i cannot build th

[Spice-devel] SPICE questions

2010-03-08 Thread Stefan Zintgraf
Hi, i have two questions regarding SPICE. a) 32-bit support I want to run a Windows guest on a 32-Bit Ubuntu system (version 9.10). The client shall also run on the same (32-Bit) machine. According the FAQ (and my experience...) i cannot build the server (libspice) on 32-Bit Ubuntu. As a resu