Re: CVS commit: src/distrib/amd64/liveimage/emuimage

2019-08-08 Thread maya
On Thu, Aug 08, 2019 at 08:22:21PM +0200, Martin Husemann wrote: > On Thu, Aug 08, 2019 at 09:13:37PM +0300, Andreas Gustafsson wrote: > > The image already has an empty /usr/libdata/debug. The increase in > > size when MKDEBUG is enabled is spread out over various other > > directories, notably /

Re: CVS commit: src/sys/sys

2019-08-10 Thread maya
On Sat, Aug 10, 2019 at 08:33:01PM +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Sat Aug 10 20:33:01 UTC 2019 > > Modified Files: > src/sys/sys: event.h > > Log Message: > Use common macro for _EV_SET() for integer types > > Deduplicate code. > >

Re: CVS commit: src/sys/sys

2019-08-11 Thread maya
On Sun, Aug 11, 2019 at 09:17:05AM +0200, Martin Husemann wrote: > On Sat, Aug 10, 2019 at 11:37:28PM +0200, Kamil Rytarowski wrote: > > > can we go back to the drawing board on this one and discuss the original > > > problem? > > > > > > > C++ and cast rules. > > The question is whether we real

Re: CVS commit: src

2019-08-26 Thread maya
On Sat, Aug 24, 2019 at 01:20:52PM +, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Sat Aug 24 13:20:52 UTC 2019 > > Modified Files: > src/lib/libnpf: Makefile > src/lib/npf: mod.mk > src/libexec/identd: Makefile > src/usr.sbin

Re: CVS commit: src

2019-08-27 Thread maya
These seem to be lowercase versions of the same names. We're going to have trouble with the people who use case insensitive filesystems and CVS. (Or maybe it's not so bad because they're files, not directories?) On Tue, Aug 27, 2019 at 12:45:04PM +, SAITOH Masanobu wrote: > Module Name: src

Re: CVS commit: src/external/gpl3/gcc/dist/gcc, vax crashes

2019-08-29 Thread maya
For future reference, proably by me: Reproducer for the crash without the local diff: #!/bin/sh cat << EOF > oacc.i int a, b; int e() { short *c = 0; char d = c[a + 1]; b = d; a += 2; } EOF vax--netbsdelf-gcc -O2 -c oacc.i This hits an assertion: emit-rtl.c:2310 gcc_assert (memory_addr

Re: CVS commit: src

2019-09-03 Thread maya
Well, this is the required diff, but my machine was fine anyway, please test with the new names, msaitoh! http://coypu.sdf.org/lowercase-to-new.diff

Re: CVS commit: src/sys/dev/pci

2019-11-17 Thread maya
> Modified files: > > Index: src/sys/dev/pci/if_mcx.c > diff -u src/sys/dev/pci/if_mcx.c:1.5 src/sys/dev/pci/if_mcx.c:1.6 > --- src/sys/dev/pci/if_mcx.c:1.5 Thu Oct 17 15:57:56 2019 > +++ src/sys/dev/pci/if_mcx.c Mon Nov 18 04:40:05 2019 > @@ -1,4 +1,4 @@ > -/* $NetBSD: if_mcx.c,v 1.5 2019

Re: CVS commit: src/sys/dev/pci

2019-11-17 Thread maya
On Mon, Nov 18, 2019 at 06:15:27AM +, m...@netbsd.org wrote: > > Modified files: > > > > Index: src/sys/dev/pci/if_mcx.c > > diff -u src/sys/dev/pci/if_mcx.c:1.5 src/sys/dev/pci/if_mcx.c:1.6 > > --- src/sys/dev/pci/if_mcx.c:1.5Thu Oct 17 15:57:56 2019 > > +++ src/sys/dev/pci/if_mcx.c

Re: CVS commit: src/external/apache2/llvm

2019-11-29 Thread maya
On Thu, Nov 28, 2019 at 11:01:22PM +, Joerg Sonnenberger wrote: > Log Message: > Use -fno-strict-aliasing unconditionally for the cross compiler. What's the context for that? Thanks!

Re: CVS commit: src/sys

2019-12-05 Thread maya
On Fri, Dec 06, 2019 at 07:27:07AM +, Maxime Villard wrote: > Log Message: > Minor changes, reported by the LGTM bot. Would be nice if the commit message was "address some integer overflows" or something. > @@ -2205,7 +2205,7 @@ m_verify_packet(struct mbuf *m) > > dat = n->m_d

Re: CVS commit: src/sys/dev/usb

2019-12-14 Thread maya
On Tue, Dec 03, 2019 at 05:01:45AM +, Taylor R Campbell wrote: > Module Name: src > Committed By: riastradh > Date: Tue Dec 3 05:01:45 UTC 2019 > > Modified Files: > src/sys/dev/usb: usbnet.c > > Log Message: > Fix order of nulling un->un_pri->unp_ec.ec_mii. > > Can't null it

Re: CVS commit: src

2019-12-18 Thread maya
On Wed, Dec 18, 2019 at 06:47:44AM -0500, Christos Zoulas wrote: > While there was no discussion, it is more efficient to have the discussion > whether we should put it back or not (instead of putting it back first and > having the discussion). Of course we should fix the build first since it seems

Re: CVS commit: src

2019-12-21 Thread maya
On Fri, Dec 20, 2019 at 06:34:31PM -0800, John Nemeth wrote: > I don't wish to get embroiled in this debate (even if I did > start it by requesting the reversion). I just want to point out > that there is a relatively simple way disable the autoloading of > a module. From module(9): > >

boottime

2020-01-04 Thread maya
- Forwarded message from Paul Goyette - Log Message: Resurrect boottime, but only in the compat_90 module (whether built-in or separately loaded). This will enable running of old vmstat(1) images on newer kernels. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/compa

Re: CVS commit: src/common/lib/libc/arch

2020-02-01 Thread maya
On Mon, Jan 27, 2020 at 10:09:21PM +, Andrew Doran wrote: > Module Name: src > Committed By: ad > Date: Mon Jan 27 22:09:21 UTC 2020 > > Removed Files: > src/common/lib/libc/arch/i386/string: memcmp.S > src/common/lib/libc/arch/x86_64/string: bcmp.S memcmp.S > > Log Messa

Re: CVS commit: src/share/man/man4

2020-04-10 Thread maya
On Fri, Apr 10, 2020 at 11:19:02AM +0900, SAITOH Masanobu wrote: > On 2020/04/10 2:42, David Young wrote: > > On Thu, Apr 09, 2020 at 03:25:32PM +0900, SAITOH Masanobu wrote: > > > On 2020/04/09 11:08, David Young wrote: > > > > On Wed, Apr 08, 2020 at 11:01:52PM +, Jaromir Dolecek wrote: > > >

Re: CVS commit: src/share/man/man4

2020-04-10 Thread maya
On Fri, Apr 10, 2020 at 07:16:24AM -0700, Jason Thorpe wrote: > > > On Apr 10, 2020, at 4:44 AM, m...@netbsd.org wrote: > > > > I had to stop using m_defrag because implementation details broke > > bwfm@pci. It can only handle a chain of length 1, and m_defrag gives > > a minimum of 2. > > Exac

Re: CVS commit: src/sys

2020-04-17 Thread maya
On Fri, Apr 17, 2020 at 05:01:15PM +0200, Manuel Bouyer wrote: > On Fri, Apr 17, 2020 at 07:52:53AM -0700, Jason Thorpe wrote: > > > > > On Apr 17, 2020, at 7:46 AM, Robert Elz wrote: > > > > > >Date:Fri, 17 Apr 2020 15:37:33 +0200 > > >From:Manuel Bouyer > > >Messag

Re: CVS commit: src/sys

2020-04-18 Thread maya
On Fri, Apr 17, 2020 at 11:39:01PM +0700, Robert Elz wrote: > Date:Fri, 17 Apr 2020 07:52:53 -0700 > From:Jason Thorpe > Message-ID: <7e54033f-9f14-4db3-a11a-01d63cd92...@me.com> > > | The New Hotness (which isn't particularly new, at this point) > | is to create

Re: CVS commit: src/sys/modules/compat_netbsd32

2020-04-19 Thread maya
Good news everyone. Does not affect any release at all. Also might not have been a security issue, because christos did a weird thing where it is compiled but somehow still disabled. On Sun, Apr 19, 2020 at 05:40:50PM +, Maya Rashish wrote: > Module Name: src > Committed By: maya

NO_KERNEL_RCSIDS

2020-04-22 Thread maya
On Wed, Apr 22, 2020 at 09:23:21AM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Wed Apr 22 09:23:21 UTC 2020 > > Modified Files: > src/sys/sys: cdefs.h > > Log Message: > For NO_KERNEL_RCSIDS, strip __RCSID() also for src/common/*. Since these live in t

Re: CVS commit: src/sys

2020-04-27 Thread maya
On Tue, Apr 28, 2020 at 05:33:45AM +1000, matthew green wrote: > i would just put it in types.h called __AUDIO_BLK_MS, > and leave a default used in the code if unset. Adding: please consider making the default assume a fast machine. This is the value that will also be used by newly added architec

__predict_false for non-default features

2020-04-27 Thread maya
On Mon, Apr 27, 2020 at 11:05:31PM +, Nathanial Sloss wrote: > Skip pfil_run_hooks if no packet filter configured in kernel. ... > @@ -398,6 +398,11 @@ pfil_run_hooks(pfil_head_t *ph, struct m > int ret = 0; > > KASSERT(dir == PFIL_IN || dir == PFIL_OUT); > + > + if (__predic

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-05-01 Thread maya
We can setup an equivalence: put as much effort into the SCTP removal proposal as there was for the SCTP introduction proposal. Since SCTP was just dropped in src without any prior discussion, I don't think we need any discussion for removing it.

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-05-02 Thread maya
On Fri, May 01, 2020 at 04:46:36PM +, m...@netbsd.org wrote: > We can setup an equivalence: put as much effort into the SCTP removal > proposal as there was for the SCTP introduction proposal. > > Since SCTP was just dropped in src without any prior discussion, I don't > think we need any disc

Re: CVS commit: src/sys/fs/tmpfs

2020-05-17 Thread maya
On Sun, May 17, 2020 at 07:39:15PM +, Andrew Doran wrote: > Module Name: src > Committed By: ad > Date: Sun May 17 19:39:15 UTC 2020 > > Modified Files: > src/sys/fs/tmpfs: tmpfs.h tmpfs_subr.c tmpfs_vnops.c > > Log Message: > PR kern/55268: tmpfs is slow > > tmpfs_getpages():

Re: CVS commit: src/sys/fs/tmpfs

2020-05-17 Thread maya
On Sun, May 17, 2020 at 09:47:50PM +, m...@netbsd.org wrote: > On Sun, May 17, 2020 at 07:39:15PM +, Andrew Doran wrote: > > Module Name:src > > Committed By: ad > > Date: Sun May 17 19:39:15 UTC 2020 > > > > Modified Files: > > src/sys/fs/tmpfs: tmpfs.h tmp

Re: CVS commit: src/sys/arch/aarch64

2020-05-23 Thread maya
On Sat, May 23, 2020 at 02:13:46PM -0700, Jason Thorpe wrote: > > > On May 23, 2020, at 11:08 AM, Ryo Shimizu wrote: > > > > Module Name:src > > Committed By: ryo > > Date: Sat May 23 18:08:59 UTC 2020 > > > > Modified Files: > > src/sys/arch/aarch64/aarch64: cpu

Re: CVS commit: src/lib/libedit (strncpy->strlcpy)

2020-06-01 Thread maya
On Sun, May 31, 2020 at 07:24:24PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun May 31 23:24:24 UTC 2020 > > Modified Files: > src/lib/libedit: terminal.c tty.c > > Log Message: > use strlcpy() instead of strncpy() for gcc happiness > ...

Re: CVS commit: src/tests/lib/libc/stdlib

2020-06-27 Thread maya
On Sat, Jun 27, 2020 at 10:19:43AM +, Jukka Ruohonen wrote: > Module Name: src > Committed By: jruoho > Date: Sat Jun 27 10:19:43 UTC 2020 > > Modified Files: > src/tests/lib/libc/stdlib: t_mbtowc.c > > Log Message: > Add the default TNF copyright (2005), cf. PR misc/55419. >

Re: CVS commit: src

2020-08-17 Thread maya
Why don't you fix your system instead of breaking other people's?

Re: CVS commit: src/external/mit/xorg/lib

2020-09-16 Thread maya
ATFORM \ > -DENABLE_SHADER_CACHE \ > > Index: src/external/mit/xorg/lib/libGL/Makefile > diff -u src/external/mit/xorg/lib/libGL/Makefile:1.29 > src/external/mit/xorg/lib/libGL/Makefile:1.30 > --- src/external/mit/xorg/lib/libGL/Makefile:1.29 Sun Mar 29 21:06:03 2020 >

Re: CVS commit: src/external/mit/xorg/lib

2020-09-20 Thread maya
On Wed, Sep 16, 2020 at 06:26:45PM +, m...@netbsd.org wrote: > Since the background for this is an issue nobody else is experiencing, > can you at least report a bug for how to reach it? hello? in the original proposal joerg already said it has a chance of making opengl not reentrant. the use

Re: CVS commit: [netbsd-8] src/external/bsd/pkg_install

2020-12-11 Thread maya
On Tue, Dec 08, 2020 at 06:48:59PM +, Martin Husemann wrote: > Module Name: src > Committed By: martin > Date: Tue Dec 8 18:48:59 UTC 2020 > > Modified Files: > src/external/bsd/pkg_install [netbsd-8]: Makefile.inc > src/external/bsd/pkg_install/dist/add [netbsd-8]: perfo

Re: CVS commit: src/external/mit/xorg/lib/libdrm

2017-03-06 Thread maya
On Mon, Mar 06, 2017 at 01:50:40PM +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Mon Mar 6 13:50:40 UTC 2017 > > Modified Files: > src/external/mit/xorg/lib/libdrm: Makefile.defines > > Log Message: > We do HAVE_NOUVEAU

Re: CVS commit: src/sys/ufs/lfs

2017-06-15 Thread maya
On Thu, Jun 15, 2017 at 02:37:31PM +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Thu Jun 15 14:37:31 UTC 2017 > > Modified Files: > src/sys/ufs/lfs: lfs_segment.c > > Log Message: > It isn't safe to drain dirops with

Re: CVS commit: [netbsd-8] src/sys/kern

2017-06-21 Thread maya
On Wed, Jun 21, 2017 at 06:12:40PM +, Soren Jacobsen wrote: > Module Name: src > Committed By: snj > Date: Wed Jun 21 18:12:40 UTC 2017 > > Modified Files: > src/sys/kern [netbsd-8]: exec_subr.c > > Log Message: > Pull up following revision(s) (requested by joerg in ticket #50)

Re: CVS commit: src/common/lib/libc/string

2017-07-15 Thread maya
On Thu, Oct 13, 2016 at 01:27:00AM +, Christos Zoulas wrote: > That would be gdb... I can revert, but then I will have to add more hacks > to gnu software... That wouldn't have been more hacks because gdb expects to buidl on more than just GNU/Linux and would have accepted your patch As a res

Re: CVS commit: src/distrib

2017-09-16 Thread maya
On Fri, Sep 08, 2017 at 09:50:45AM +, Martin Husemann wrote: > Introduce CDRELEASE_NODEBUG - if set, avoids putting debug sets in the > ISO image. > > Set this for sparc64 install CDs - many of the supported machines have > SCSI CD drives and it is impossible to get DVD replacements for those.

Re: CVS commit: src/lib/libc/gen (vax mentions moved to CAVEATs)

2017-09-27 Thread maya
On Wed, Sep 27, 2017 at 09:04:30AM +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Wed Sep 27 09:04:30 UTC 2017 > > Modified Files: > src/lib/libc/gen: isinf.3 > > Log Message: > Move VAX notes to CAVEATS, clarify that it jus

Re: CVS commit: [jdolecek-ncq] src/sys/arch/amiga/dev

2017-09-28 Thread maya
On Tue, Sep 26, 2017 at 09:06:24PM +, Jaromir Dolecek wrote: > need for DEV_BSIZE needed by atavar.h I pointed it out to someone as, I think we normally prefer to make headers standalone. but he said that using DEV_BSIZE at all might be a problem (but isn't replying himself). is that hard co

Re: CVS commit: src/lib/libm/man

2017-09-28 Thread maya
On Thu, Sep 28, 2017 at 03:52:00PM +0200, Joerg Sonnenberger wrote: > On Thu, Sep 28, 2017 at 11:09:05AM +0000, Maya Rashish wrote: > > Module Name:src > > Committed By: maya > > Date: Thu Sep 28 11:09:05 UTC 2017 > > > > Modifie

Re: CVS commit: src/lib/libpthread

2017-10-01 Thread maya
netbsd-8 needs a web browser too On Tue, Aug 01, 2017 at 12:31:45PM +, Martin Husemann wrote: > Module Name: src > Committed By: martin > Date: Tue Aug 1 12:31:45 UTC 2017 > > Modified Files: > src/lib/libpthread: pthread_attr.c > > Log Message: > pthread__attr_init_private:

smbfs

2017-10-03 Thread maya
We can rump mount a lot of those filesystems, it would be nice if that was be the default way too. A lot less risky

Re: CVS commit: src/sys/arch/x86/x86

2017-10-03 Thread maya
If pax mprotect is an example then maxv should just go around rm -rf'ing any parts of the tree he doesn't like without even checking that the kernel builds afterwards, since that's the way we do things around here. It was months until I could run meld again, even disabling it for just python was f

Re: CVS commit: src/external/gpl3/gcc.old

2017-10-06 Thread maya
So I'm supposed to never link C++ from pkgsrc GCC and C++ from netbsd GCC?

Re: CVS import: src/external/gpl3/gcc.old

2017-11-14 Thread maya
On Mon, Nov 13, 2017 at 07:47:45AM +, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Mon Nov 13 07:47:45 UTC 2017 > > Update of /cvsroot/src/external/gpl3/gcc.old > In directory ivanova.netbsd.org:/tmp/cvs-serv10854 > > Log Message: > import GCC 5.5 into gcc.old.

Re: CVS commit: src/bin/sh

2017-11-20 Thread maya
On Sun, Nov 19, 2017 at 03:23:02AM +, Robert Elz wrote: > Module Name: src > Committed By: kre > Date: Sun Nov 19 03:23:01 UTC 2017 > > Modified Files: > src/bin/sh: eval.c option.list options.c output.c output.h sh.1 var.c > > Log Message: > Implement the -X option - an appare

Re: CVS commit: src/bin/sh

2017-11-20 Thread maya
On Tue, Nov 21, 2017 at 03:27:11AM +, Christos Zoulas wrote: > The reason is that tsutsui@? added some binaries (sysctl? etc) back to > the ramdisk. We are working trying to fix it. I see, thanks. Going by the dmesg posted on dmesgd.nycbug.org, it looks like for rootdev we can use: cat /kern/

Re: CVS commit: src/bin/sh

2017-11-20 Thread maya
...now I see it's challenge mode scripting: sed only, no awk or grep. :-)

Re: CVS commit: src/sys/conf

2017-12-19 Thread maya
On Sun, Dec 03, 2017 at 11:36:05AM -0500, Christos Zoulas wrote: > + @ln -sf ../$S/external/gpl2/dts/dist/arch/${_arch}/boot/dts dts/${_arch} this is causing unclear failures in autobuilds (seems to make a link in src and doesn't work with ro src?), but strangely I can't reproduce this. Could

Re: CVS commit: src/sys

2017-12-24 Thread maya
On Tue, Dec 19, 2017 at 07:40:04PM +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Tue Dec 19 19:40:04 UTC 2017 > > Modified Files: > src/sys/compat/netbsd32: netbsd32_netbsd.c netbsd32_syscall.h > netbsd32_syscallargs.h netbsd32_syscalls.c

Re: CVS commit: src/sys/netinet

2017-12-24 Thread maya
On Fri, Dec 22, 2017 at 11:22:37AM +, Ryota Ozaki wrote: > Module Name: src > Committed By: ozaki-r > Date: Fri Dec 22 11:22:37 UTC 2017 > > Modified Files: > src/sys/netinet: ip_output.c > > Log Message: > Fix usage of curlwp_bind in ip_output > @@ -303,6 +303,10 @@ ip_outp

Re: CVS commit: src/sys/netinet

2017-12-24 Thread maya
Oops, I misread the code, never mind :-) still looking because there are some reports of hangs (kern/52858 with a backtrace on sparc64, current-users without one on amd64), and your change is the only recent change that looks like it could affect both.

Re: CVS commit: src

2018-01-05 Thread maya
> Register new weak symbol in libc for internal usage: atoi Why are we protecting libc from users who override standard C functions? I don't think you should be able to provide a wrong implementation of them, link to libc, and expect it to work.

Re: CVS commit: src/sys/compat/linux/common

2018-01-08 Thread maya
> + /* > + * XXX: Linux has 33 realtime signals, the go binary wants to > + * reset all of them; nothing else uses the last RT signal, so for > + * now ignore it. > + */ > + if (sig == LINUX__NSIG) { > + uprintf("%s: setting signal %d ignored\n", __func__, si

Re: CVS commit: src/sys/net

2018-01-08 Thread maya
This is causing PR kern/52914 (on netbsd-8, not current) On Fri, Dec 15, 2017 at 04:04:59AM +, Ryota Ozaki wrote: > Module Name: src > Committed By: ozaki-r > Date: Fri Dec 15 04:04:59 UTC 2017 > > Modified Files: > src/sys/net: if.c > > Log Message: > Remove IFNET_GLOBAL_LOCK

Re: CVS commit: src/sys/net

2018-01-08 Thread maya
On Tue, Jan 09, 2018 at 01:07:50AM +, m...@netbsd.org wrote: > This is causing PR kern/52914 (on netbsd-8, not current) Copied wrong number kern/52895 it's in -current but also -8

Re: CVS commit: src/sys/dev/pci

2018-01-16 Thread maya
Hi maxv, there is a similar code fragment in ic/bwfm.c:bwfm_scan_node. I am not sure what I'm looking at. Could it be wrong too? Thanks. On Tue, Jan 16, 2018 at 07:05:25AM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Tue Jan 16 07:05:25 UTC 2018 > > Modi

Re: CVS commit: src/sys/net80211

2018-01-16 Thread maya
On Tue, Jan 16, 2018 at 06:35:08PM -0600, David Young wrote: > I have said it before, that I do think the "concept architecture" of > 802.11 VAP is rather broken, but let's be honest: nobody, especially not > I, have had the time in 10+ years to independently implement anything > comparable. *shrug

Re: CVS commit: src/sys/net80211

2018-01-20 Thread maya
I don't think there is any objection, even if adopting the freebsd code results in kiling less important drivers. Note that freebsd has similar bugs to what maxv just fixed (I emailed security-officer@freebsd about the one I saw).

Re: CVS commit: src/external/bsd/pkg_install/dist/lib

2018-02-04 Thread maya
I'm intentionally verbose in the hopes that someone has a second look at it, it's important to get right. On Sun, Feb 04, 2018 at 09:00:51AM +, Maya Rashish wrote: > Fix OpenSSL 1.1.0 build > OpenSSL 1.1.0 makes xkusage and ex_flags opaque. > Use X509_check_ca rather than

Re: CVS commit: src/crypto/external/bsd/openssl.old/dist/crypto/hmac

2018-02-04 Thread maya
match new with malloc -> calloc please > +static inline HMAC_CTX *HMAC_CTX_new(void) > +{ > + HMAC_CTX *ctx = malloc(sizeof(*ctx)); > + if (ctx == NULL) > + return NULL; > + HMAC_CTX_init(ctx); > + return ctx; > +} > +

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2018-02-06 Thread maya
On Sun, Feb 04, 2018 at 07:13:50PM -0500, Christos Zoulas wrote: > - return BN_num_bits(k->rsa->n); > +#if OPENSSL_VERSION_NUMBER >= 0x1010UL > + return RSA_bits(k->rsa); > +#else > + return BN_num_bits(k->rsa->p); > +#endif > case KEY_DSA: > case

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2018-02-06 Thread maya
> + const BIGNUM *pub_key; > + if ((r = dh_gen_key(kex->dh, kex->we_need * 8)) != 0) > + goto out; > + DH_get0_key(kex->dh, &pub_key, NULL); > + if ((r = sshpkt_start(ssh, SSH2_MSG_KEX_DH_GEX_INIT)) != 0 || > + (r = sshpkt_put_bignum2(ssh, pub_key)) != 0 || > +

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2018-02-06 Thread maya
On Tue, Feb 06, 2018 at 01:26:41PM +, m...@netbsd.org wrote: > BN_clear_free will null deref on this error path I think oops, I"m relying on ctags and went into the heimdal BN_clear_free instead which does this, and not the openssl which does NULL test.

Re: CVS commit: src/share/man/man4

2018-02-07 Thread maya
Hi! Please give credit in the future. It can be very important for a new contributor, I used to show my friends, "look, I made this change, and it says I did it!" and it was very cool. Even though they were small contributions, they were my biggest contributions. (For example: Mention jumbo fra

IP6_EXTHDR_GET

2018-02-08 Thread maya
On Thu, Feb 08, 2018 at 08:06:21PM +, Maxime Villard wrote: > af = AF_INET; > iphlen = sizeof(struct ip); > - IP6_EXTHDR_GET(th, struct tcphdr *, m, toff, > - sizeof(struct tcphdr)); > - if (th == NULL) { > -

Re: CVS commit: src/sys

2018-02-08 Thread maya
On Thu, Feb 08, 2018 at 07:58:05PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Thu Feb 8 19:58:05 UTC 2018 > > Modified Files: > src/sys/netinet: tcp_input.c > src/sys/netinet6: raw_ip6.c udp6_usrreq.c > > Log Message: > Remove the IN6_IS_ADD

Re: CVS commit: src/sys/dev/sun

2018-02-08 Thread maya
> case 0x30: > #if NSYSMON_ENVSYS > - if (k->k_isconsole) > + if (k->k_isconsole) { > k->k_ev = KEY_UP(code) ? > PSWITCH_EVENT_RELEASED : >

IEEE1394

2018-02-13 Thread maya
On Tue, Feb 13, 2018 at 10:47:41AM +, Maxime Villard wrote: > + if (ntohs(ar->ar_hrd) == ARPHRD_IEEE1394) { > + goto out; > + } > + What makes IEEE-1394 so bad it needs a blacklist rather than a whitelist? there's some other really weird options for ar_hrd

Re: IEEE1394

2018-02-13 Thread maya
I'm reading the rest of the commits now :-) because it doesn't have ar_tha, ok!

regnsub, regasub

2018-02-26 Thread maya
Any chance we can remove this from libc before releasing 8.0? it has one user, and the implementation is very specific for a certain use-case. having a DIY one use case function in libc is actually harming the ability to upstream this, aside from the implementation choices.

Re: CVS commit: src/sys/rump/librump/rumpnet

2018-02-28 Thread maya
On Tue, Feb 27, 2018 at 02:45:43PM +, Maxime Villard wrote: > Oops, forgot this file; I just merged two IPsec functions, so adapt > the rump stubs accordingly. .. > __weak_alias(esp6_ctlinput,rumpnet_stub); > __weak_alias(ipsec4_output,rumpnet_stub); > __weak_alias(ipsec4_common_input,rumpne

Re: CVS commit: src/sys/dev

2018-02-28 Thread maya
On Wed, Feb 28, 2018 at 05:50:06AM +, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Wed Feb 28 05:50:06 UTC 2018 > > Modified Files: > src/sys/dev/acpi: acpi_mcfg.c > src/sys/dev/pci: pci_quirks.c pcivar.h > > Log Message: > - Add new PCI quirk

unused kernel functions (SHA3, etc.)

2018-03-01 Thread maya
On Thu, Nov 30, 2017 at 05:47:25AM +, Taylor R Campbell wrote: > Module Name: src > Committed By: riastradh > Date: Thu Nov 30 05:47:24 UTC 2017 > > Modified Files: > src/common/lib/libc: Makefile.inc > src/lib/libc/hash: Makefile.inc > src/lib/libc/include: namespac

Re: unused kernel functions (SHA3, etc.)

2018-03-01 Thread maya
never mind, this works instead (courtesy of phone) Index: sun2/conf/Makefile.sun2 === RCS file: /cvsroot/src/sys/arch/sun2/conf/Makefile.sun2,v retrieving revision 1.20 diff -u -r1.20 Makefile.sun2 --- sun2/conf/Makefile.sun2 21 J

Re: CVS commit: src/external/bsd/mdocml/include

2018-03-17 Thread maya
Hi, I'm not sure what the changes affect. Does this mean UTF-8 won't work either? that's sounds like a big price to pay. Also, the problem doesn't sound specific to mdocml. Is the problem: netbsd mishandles some locales it claims to support? On Sat, Mar 17, 2018 at 11:06:48AM +, Takeshi Naka

Re: CVS commit: src/sys/netinet

2018-03-29 Thread maya
On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Thu Mar 29 21:40:53 UTC 2018 > > Modified Files: > src/sys/netinet: tcp_input.c > > Log Message: > tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@). >

Re: CVS commit: xsrc/external/mit/xorg-server/dist/hw/xfree86/drivers/modesetting

2018-04-03 Thread maya
Can we please fix it before someone argues it's too late to make incompatible changes? :-)

Re: CVS commit: src/external

2018-04-08 Thread maya
On Sun, Apr 08, 2018 at 04:57:07PM +, Jared D. McNeill wrote: > @@ -82,6 +82,10 @@ The licenses currently used are: > mpl Mozilla Public license. > https://opensource.org/licenses/MPL-2.0 > > + nvidia-firmware NVIDIA firmware license permitting redi

Re: CVS commit: [pgoyette-compat] src/sys/compat

2018-04-15 Thread maya
__BEGIN_DECLS? was that accessible from userland? On Sun, Apr 15, 2018 at 06:23:32AM +, Paul Goyette wrote: > Module Name: src > Committed By: pgoyette > Date: Sun Apr 15 06:23:31 UTC 2018 > > Modified Files: > src/sys/compat/common [pgoyette-compat]: uipc_syscalls_40.c >

Re: CVS commit: src/share/mk

2018-04-18 Thread maya
On Sun, Apr 15, 2018 at 04:08:14PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Apr 15 20:08:13 UTC 2018 > > Modified Files: > src/share/mk: bsd.own.mk > > Log Message: > switch x86 to binutils-2.30 > > > To generate a diff of this commit:

Re: CVS commit: src/sys/kern

2018-05-01 Thread maya
hey, thanks for all the fixes! I'm trying to import a driver (while being very new to networking/driver stuff), and updating to -current fixed an issue I've had, most likely from this commit. Now my ported driver is close to working :-) On Sat, Apr 28, 2018 at 08:16:15AM +, Maxime Villard wr

Re: CVS commit: src/sys/dev

2018-05-11 Thread maya
initially I picked up the revisions one by one, but found out some of my changes were broken and undid them, and wanted to stick to minimal changes to a working driver. jared said that our driver is intentionally different too.

Re: CVS commit: src/sys/dev

2018-05-11 Thread maya
On Fri, May 11, 2018 at 04:29:22PM +, Christos Zoulas wrote: > In article , > Jason Thorpe wrote: > > > > > >> On May 11, 2018, at 12:41 AM, Maya Rashish wrote: > >> > >> Module Name: src > >> Committed By: may

Re: CVS commit: src/usr.bin/mail

2018-05-22 Thread maya
You don't get to sneak a controversial change by omitting a real commit message. On Tue, May 22, 2018 at 09:03:47PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Wed May 23 01:03:46 UTC 2018 > > Modified Files: > src/usr.bin/mail: Makefile mail.1

Re: CVS commit: src/sys/arch/x86/x86

2018-06-07 Thread maya
You've changed a default and selectively fixed the one driver that people noticed breaks from it. How do you know the rest aren't broken? On Thu, Jun 07, 2018 at 01:35:31PM +, Jason R Thorpe wrote: > Module Name: src > Committed By: thorpej > Date: Thu Jun 7 13:35:31 UTC 2018 > > Mo

Re: CVS commit: src/sys/arch/i386/stand/lib

2018-06-11 Thread maya
Hi christos! Could you explain what makes this necessary in the commit messages in the future? It isn't very obvious that it fixes a build failure with MKREPRO for future netbsd'ers, in case it isn't restructured. Ideally in every commit, so it appears in a 'cvs annotate'. Thanks. On Mon, Jun 11

Re: CVS commit: src/sys/arch/i386/stand/lib

2018-06-11 Thread maya
On Tue, Jun 12, 2018 at 03:25:31AM +, m...@netbsd.org wrote: > Hi christos! > > Could you explain what makes this necessary in the commit messages in > the future? It isn't very obvious that it fixes a build failure with > MKREPRO for future netbsd'ers, in case it isn't restructured. > Ideally

Re: CVS commit: src/share/mk

2018-06-22 Thread maya
On Fri, Jun 22, 2018 at 12:37:34PM +1000, matthew green wrote: > "Maya Rashish" writes: > > Module Name:src > > Committed By: maya > > Date: Wed Jun 20 02:15:13 UTC 2018 > > > > Modified Files: > > src/share/mk

Re: CVS commit: src/external/mit/xorg/bin

2018-07-04 Thread maya
On Wed, Jul 04, 2018 at 12:25:49PM +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Wed Jul 4 12:25:49 UTC 2018 > > Modified Files: > src/external/mit/xorg/bin/fc-cache: Makefile > src/external/mit/xorg/bin/fc-cat: Makefile >

Re: CVS commit: src/external/gpl3

2018-07-12 Thread maya
so, number of segments will be wrong if there is .interp but no .dynamic. why don't we ignore the conventrion set in this file and ++segs when adding those segments? On Thu, Jul 12, 2018 at 09:38:16PM +, Joerg Sonnenberger wrote: > Module Name: src > Committed By: joerg > Date: Thu J

Re: CVS commit: src/external/gpl3

2018-07-12 Thread maya
Never mind, I'm even losing track of what I'm reading.

Re: CVS commit: src/lib/csu/common

2018-07-13 Thread maya
ack. we should probably leave the build broken, anyone who tries out the resulting netbsd might have to spend some time figuring out how to boot without /sbin/init (it's boot -a and then pick /rescue/init). On Fri, Jul 13, 2018 at 01:00:17AM +, Robert Elz wrote: > Module Name: src > Committed

Re: CVS commit: src/lib/csu/common

2018-07-13 Thread maya
On Fri, Jul 13, 2018 at 04:48:32PM +0700, Robert Elz wrote: > Date:Fri, 13 Jul 2018 09:38:02 + > From:m...@netbsd.org > Message-ID: <20180713093802.ga20...@homeworld.netbsd.org> > > | ack. we should probably leave the build broken, anyone who tries out the > |

Re: CVS commit: src/external/gpl3

2018-07-13 Thread maya
On Thu, Jul 12, 2018 at 09:38:16PM +, Joerg Sonnenberger wrote: > @@ -4448,6 +4455,13 @@ _bfd_elf_map_sections_to_segments (bfd * >section. */ >s = bfd_get_section_by_name (abfd, ".interp"); >if (s != NULL && (s->flags & SEC_LOAD) != 0) > + s = NULL; perhaps that s

Re: CVS commit: src/sys/arch

2018-07-14 Thread maya
On Sat, Jul 14, 2018 at 03:09:41PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Sat Jul 14 15:09:41 UTC 2018 > > Modified Files: > src/sys/arch/bebox/conf: INSTALL > src/sys/arch/evbarm/conf: ARMADAXP ARMADILLO-IOT-G3 BCM5301X BCM56340 >

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread maya
On Fri, Aug 03, 2018 at 07:46:01PM +0100, Roy Marples wrote: > We could split the term, but merely storing the result of htons in it's own > variable creates a larger binary for no good reason as i see it. > I suspect that the compiler will generate the same code anyway when using a local variabl

  1   2   3   4   5   >