Re: CVS commit: src/sys/dev

2025-04-12 Thread Michael van Elst
On Sat, Apr 12, 2025 at 02:42:33AM -0700, Paul Goyette wrote: > Does this help kern/59153? It avoids data loss and corruption in similar cases. The exact condition in kern/59153 luckily didn't dump at all. Greetings, -- Michael van Elst Internet: mlel...@serpens.d

Re: kern/59153 crash doesn't dump (Was: CVS commit: src/sys/dev)

2025-04-12 Thread Rin Okuyama
Ah, yes, I'd just forgotten this PR! As mrg@ suggested, we should probably: (1) pullup mlelstv@'s fix to netbsd-10 and -9, then (2) commit something like my patch only for -current. (2) should fix the original problem, probably ;) Thanks, rin On 2025/04/12 18:44, Paul Goyette wrote: Is this r

Re: CVS commit: src/sys/dev

2025-04-12 Thread Michael van Elst
On Sat, Apr 12, 2025 at 06:24:44PM +0900, Rin Okuyama wrote: > Hi! > > I've made a draft patch to support dumping against > 2Gi blocks > for backends like nvme(4) or virtio(4). > > Does it look reasonable to you? Hi rin, > - if (blkno < 0 || blkno + nblk - 1 > INT_MAX) > + if (blkno

Re: CVS commit: src/sys/dev

2025-04-12 Thread Rin Okuyama
Hi! I've made a draft patch to support dumping against > 2Gi blocks for backends like nvme(4) or virtio(4). Does it look reasonable to you? Thanks, rin On 2025/04/12 16:30, Michael van Elst wrote: Module Name:src Committed By: mlelstv Date: Sat Apr 12 07:30:01 UTC 2025 Modifi

Re: CVS commit: src/sys/dev

2025-04-12 Thread Paul Goyette
Does this help kern/59153? On Sat, 12 Apr 2025, Michael van Elst wrote: Module Name:src Committed By: mlelstv Date: Sat Apr 12 07:30:01 UTC 2025 Modified Files: src/sys/dev: ld.c Log Message: ld sc_dump backend takes an 'int' as disk address, fail when the disk address

Re: CVS commit: src/sys/dev

2025-04-12 Thread Paul Goyette
Is this related to kern/59153? On Sat, 12 Apr 2025, Rin Okuyama wrote: Hi! I've made a draft patch to support dumping against > 2Gi blocks for backends like nvme(4) or virtio(4). Does it look reasonable to you? Thanks, rin On 2025/04/12 16:30, Michael van Elst wrote: Module Name:src Co

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-12 Thread Izumi Tsutsui
> Would you or isaki@ or martin@ like me to assign PR 13078 to either of you > and > I'll write a followup email to the binutils people stating that from now on > you'll handle all responsibilty for the correspondance with them and assign > either of you to the doc/HACKS note. Actually I had n

Re: CVS commit: src/sys/dev

2025-04-12 Thread Rin Okuyama
Hi Michael, thanks for kind review! On 2025/04/12 19:01, Michael van Elst wrote: On Sat, Apr 12, 2025 at 06:24:44PM +0900, Rin Okuyama wrote: Hi! I've made a draft patch to support dumping against > 2Gi blocks for backends like nvme(4) or virtio(4). Does it look reasonable to you? Hi rin,

Re: CVS commit: src/sys/dev

2025-04-12 Thread Michael van Elst
On Sat, Apr 12, 2025 at 08:14:28PM +0900, Rin Okuyama wrote: > Hi Michael, thanks for kind review! Hi rin, > PS > For ld_sdmmc.c, IIUC, check for ld_sdmmc_dump() yields > > ``` > if (blkno + blkcnt - 1 > sc->sc_sf->csd.capacity) > return EIO; capacity is the block count, not the last bl

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-12 Thread Nat Sloss
On Sun, 13 Apr 2025 08:28:04 Izumi Tsutsui wrote: > > Would you or isaki@ or martin@ like me to assign PR 13078 to either of > > you and I'll write a followup email to the binutils people stating that > > from now on you'll handle all responsibilty for the correspondance with > > them and assign ei

Re: CVS commit: src/sys/dev

2025-04-12 Thread Rin Okuyama
Hi Michael, On 2025/04/12 21:00, Michael van Elst wrote: On Sat, Apr 12, 2025 at 08:14:28PM +0900, Rin Okuyama wrote: Hi Michael, thanks for kind review! Hi rin, PS For ld_sdmmc.c, IIUC, check for ld_sdmmc_dump() yields ``` if (blkno + blkcnt - 1 > sc->sc_sf->csd.capacity) return

Re: CVS commit: src/sys

2025-04-12 Thread Thomas Klausner
On Sun, Apr 13, 2025 at 02:34:03AM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Sun Apr 13 02:34:03 UTC 2025 > > Modified Files: > src/sys/arch/usermode/dev: ld_thunkbus.c > src/sys/dev: ld.c ldvar.h > src/sys/dev/ata: ld_ataraid.c > src