Le 22/08/2018 à 14:14, Robert Elz a écrit :
Module Name:src
Committed By: kre
Date: Wed Aug 22 12:14:29 UTC 2018
Modified Files:
src/sys/sys: asan.h
Log Message:
Temporarily disable the dummy inline funcs, and replace them with
__nothing until maxv sorts out the type iss
On Wed, Aug 22, 2018 at 02:24:09PM +0200, Maxime Villard wrote:
> Shouldn't we make kern_malloc take a size_t? In the end it calls kmem_alloc
> which does take a size_t.
Lots of builds are broken, can we back it out untill we know what to do?
Martin
In article ,
Maxime Villard wrote:
>
>The reason we should not use __nothing is because it leaves unused
>variables, and causes warnings.
Yes, and depending on the compiler and optimization level also leaves
code behind, or might have side effects. This is why everywhere else
we use empty macro
In article <20180822124207.042c6f...@cvs.netbsd.org>,
Maxime Villard wrote:
>-=-=-=-=-=-
>
>Module Name: src
>Committed By: maxv
>Date: Wed Aug 22 12:42:06 UTC 2018
>
>Modified Files:
> src/sys/kern: kern_malloc.c
> src/sys/sys: asan.h
>
>Log Message:
>Add back the KASAN if
Maxime Villard writes:
| Shouldn't we make kern_malloc take a size_t? In the end it calls kmem_alloc
| which does take a size_t.
Someone else's decision, I am not sure of all of the ramifications.
| The reason we should not use __nothing is because it leaves unused
| variables, and cause
On Wed, Aug 22, 2018 at 02:35:15PM +, Christos Zoulas wrote:
> >Log Message:
> >Add back the KASAN ifdefs in kern_malloc until we sort out the type issue,
> >and fix sys/asan.h. Tested on i386, amd64 and amd64-kasan.
>
> But it was already fixed, why did you break it again?
Don't think it rea
Martin Husemann writes:
| On Wed, Aug 22, 2018 at 02:35:15PM +, Christos Zoulas wrote:
|> But it was already fixed, why did you break it again?
It was more or less put back to yesterday - what was in asan.h for the !KASAN
case is more or less irrelevant, as all the calls are #ifdef'd and n
On Aug 22, 4:45pm, mar...@duskware.de (Martin Husemann) wrote:
-- Subject: Re: CVS commit: src/sys
| On Wed, Aug 22, 2018 at 02:35:15PM +, Christos Zoulas wrote:
| > >Log Message:
| > >Add back the KASAN ifdefs in kern_malloc until we sort out the type issue,
| > >and fix sys/asan.h. Tested o
Christos Zoulas writes:
| I think that my commits are last now. So if it is broken, it is my fault!
I think your recent commit is more or less irrelevant right now. It
defines macros in the ! KSAN case that are (currently) only used #if KSAN
So if something is broken, it is probably something
On Aug 22, 11:31pm, k...@munnari.oz.au (Robert Elz) wrote:
-- Subject: Re: CVS commit: src/sys
| Christos Zoulas writes:
| | I think that my commits are last now. So if it is broken, it is my fault!
|
| I think your recent commit is more or less irrelevant right now. It
| defines macros in th
Christos Zoulas writes:
| Yes, I don't know if they caught the changes, but nevertheless I am running
| an evbarm build right now anyway..
The current buildbot build started 14:09, your changes were 14:11 and 14:12
(all UTC), so no ... (and the source time is rounded back to an even 10
mins,
On Aug 23, 12:07am, k...@munnari.oz.au (Robert Elz) wrote:
-- Subject: Re: CVS commit: src/sys
| Christos Zoulas writes:
|
| | Yes, I don't know if they caught the changes, but nevertheless I am running
| | an evbarm build right now anyway..
|
| The current buildbot build started 14:09, your c
12 matches
Mail list logo
