Re: CVS commit: src/usr.sbin/wake

2010-01-12 Thread Christos Zoulas
On Jan 12, 4:26am, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/usr.sbin/wake | On Mon, Jan 11, 2010 at 06:31:29PM -0500, Christos Zoulas wrote: | > | In the long run (as I've said before) we should replace our lint with | > | something

Re: CVS commit: src/usr.sbin/wake

2010-01-11 Thread David Holland
On Mon, Jan 11, 2010 at 06:31:29PM -0500, Christos Zoulas wrote: > | In the long run (as I've said before) we should replace our lint with > | something more modern... > > Once we get the llvm tools, I am fine with that. There's also splint, or sparse. -- David A. Holland dholl...@netbsd.or

Re: CVS commit: src/usr.sbin/wake

2010-01-11 Thread Christos Zoulas
On Jan 11, 8:44pm, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/usr.sbin/wake | On Sun, Jan 10, 2010 at 11:23:19PM +, Christos Zoulas wrote: | > Please explain to me how you propose we fix lint. | | Realistically, lint should be made to kno

Re: CVS commit: src/usr.sbin/wake

2010-01-11 Thread Mindaugas Rasiukevicius
chris...@astron.com (Christos Zoulas) wrote: > >Log Message: > >remove stupid casts. if lint complains about return values that are > >ignored, lint should fe fixed, and not code being cluttered. > > Please explain to me how you propose we fix lint. Or to be more precise, > how does the code conv

Re: CVS commit: src/usr.sbin/wake

2010-01-11 Thread David Holland
On Sun, Jan 10, 2010 at 11:23:19PM +, Christos Zoulas wrote: > Please explain to me how you propose we fix lint. Realistically, lint should be made to know a list of standard functions with usually-uninteresting return values. That would solve 95+% of the practical problem. In the long run (

Re: CVS commit: src/usr.sbin/wake

2010-01-10 Thread Christos Zoulas
In article <20100110194012.3693a17...@cvs.netbsd.org>, Marc Balmer wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: mbalmer >Date: Sun Jan 10 19:40:12 UTC 2010 > >Modified Files: > src/usr.sbin/wake: wake.c > >Log Message: >remove stupid casts. if lint complains about ret

Re: CVS commit: src/usr.sbin/wake

2009-06-27 Thread Perry E. Metzger
Simon Burge writes: > "wake" is a lot more generic term than "ssh" or "tcpdump". When I first > saw the subject "CVS commit: src/usr.sbin/wake" it wasn't in any way > obvious that this sent wake-on-lan packets to remote hosts. My first > guess was something that "woke up" processes blocked in t

Re: CVS commit: src/usr.sbin/wake

2009-06-27 Thread Perry E. Metzger
Christos Zoulas writes: > I think this utility should be renamed wakeonlan because wake is too > generic. Agreed -- it seems like a better name. Perry

Re: CVS commit: src/usr.sbin/wake

2009-06-27 Thread David Holland
On Sat, Jun 27, 2009 at 08:00:03AM +0900, Izumi Tsutsui wrote: > Now you see an example that discussion after commit is annoying ;-p Wake turbulence! -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/usr.sbin/wake

2009-06-27 Thread Thomas Klausner
On Fri, Jun 26, 2009 at 01:56:25PM -0500, David Young wrote: > On Fri, Jun 26, 2009 at 07:22:04PM +0100, David Laight wrote: > > On Fri, Jun 26, 2009 at 01:38:32PM -0400, Christos Zoulas wrote: > > > > > > I think this utility should be renamed wakeonlan because wake is too > > > generic. > > >

Re: CVS commit: src/usr.sbin/wake

2009-06-27 Thread Marc Balmer
Am 27.06.2009 um 05:27 schrieb Simon Burge: Marc Balmer wrote: Am 27.06.2009 um 00:08 schrieb Marc Balmer: Am 26.06.2009 um 20:22 schrieb David Laight: On Fri, Jun 26, 2009 at 01:38:32PM -0400, Christos Zoulas wrote: I think this utility should be renamed wakeonlan because wake is too

Re: CVS commit: src/usr.sbin/wake

2009-06-26 Thread Simon Burge
Marc Balmer wrote: > Am 27.06.2009 um 00:08 schrieb Marc Balmer: > > > > > Am 26.06.2009 um 20:22 schrieb David Laight: > > > >> On Fri, Jun 26, 2009 at 01:38:32PM -0400, Christos Zoulas wrote: > >>> > >>> I think this utility should be renamed wakeonlan because wake is > >>> too generic. > >>

Re: CVS commit: src/usr.sbin/wake

2009-06-26 Thread Izumi Tsutsui
m...@msys.ch wrote: > >>> I think this utility should be renamed wakeonlan because wake is > >>> too generic. > >> > >> FWIW I agree ... > > > > I disagree. Totally. > > > > and I forgot to mention why: the command name reflects what the > command does, > not how it does it. wakeonlan woul

Re: CVS commit: src/usr.sbin/wake

2009-06-26 Thread Marc Balmer
Am 27.06.2009 um 00:08 schrieb Marc Balmer: Am 26.06.2009 um 20:22 schrieb David Laight: On Fri, Jun 26, 2009 at 01:38:32PM -0400, Christos Zoulas wrote: I think this utility should be renamed wakeonlan because wake is too generic. FWIW I agree ... I disagree. Totally. and I forg

Re: CVS commit: src/usr.sbin/wake

2009-06-26 Thread Marc Balmer
Am 26.06.2009 um 20:22 schrieb David Laight: On Fri, Jun 26, 2009 at 01:38:32PM -0400, Christos Zoulas wrote: I think this utility should be renamed wakeonlan because wake is too generic. FWIW I agree ... I disagree. Totally.

Re: CVS commit: src/usr.sbin/wake

2009-06-26 Thread David Young
On Fri, Jun 26, 2009 at 07:22:04PM +0100, David Laight wrote: > On Fri, Jun 26, 2009 at 01:38:32PM -0400, Christos Zoulas wrote: > > > > I think this utility should be renamed wakeonlan because wake is too > > generic. > > FWIW I agree ... I think that wake is a good command: short, imperative,

Re: CVS commit: src/usr.sbin/wake

2009-06-26 Thread David Laight
On Fri, Jun 26, 2009 at 01:38:32PM -0400, Christos Zoulas wrote: > > I think this utility should be renamed wakeonlan because wake is too generic. FWIW I agree ... David -- David Laight: da...@l8s.co.uk