re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread matthew green
> On Wed, 10 Nov 2010, Christoph Badura wrote: > > On Tue, Nov 09, 2010 at 08:34:56PM +, Alan Barrett wrote: > > > Modified Files: > > > src/usr.bin/pathchk: pathchk.1 > > > > > > Log Message: > > > Change the ironically unafe "find . -print | xargs pathchk -p" to > > > the safe "find . -ex

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread Christos Zoulas
In article <20101110182232.ga19...@snowdrop.l8s.co.uk>, David Laight wrote: >On Wed, Nov 10, 2010 at 01:34:44PM +0200, Alan Barrett wrote: >> >> "-exec ... +" and "xargs" will both accumulate many args into each >> invocation of the child program, and will both fork the same number of >> times.

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread Alan Barrett
On Wed, 10 Nov 2010, David Holland wrote: > > Yes, I did not know about exec {} + > > Neither did I; when was it invented? Did the POSIX folks come up with > something good for a change? I don't know when it was invented, but it's in The Open Group Base Specifications Issue 6, a.k.a. IEEE Std 10

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread Jim Wise
David Laight writes: > On Wed, Nov 10, 2010 at 06:19:25PM +, David Holland wrote: >> On Wed, Nov 10, 2010 at 01:34:02PM +, Christos Zoulas wrote: >> > >Christos seems to have made the same mistake as you, confusing "-exec >> > >... \;" (which runs a separate child program for each file

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread David Laight
On Wed, Nov 10, 2010 at 06:19:25PM +, David Holland wrote: > On Wed, Nov 10, 2010 at 01:34:02PM +, Christos Zoulas wrote: > > >Christos seems to have made the same mistake as you, confusing "-exec > > >... \;" (which runs a separate child program for each file name) with > > >"-exec ...

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread David Holland
On Wed, Nov 10, 2010 at 01:34:02PM +, Christos Zoulas wrote: > >Christos seems to have made the same mistake as you, confusing "-exec > >... \;" (which runs a separate child program for each file name) with > >"-exec ... +" (which passes many file names to each invocation of the > >child pr

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread David Laight
On Wed, Nov 10, 2010 at 01:34:44PM +0200, Alan Barrett wrote: > > "-exec ... +" and "xargs" will both accumulate many args into each > invocation of the child program, and will both fork the same number of > times. The version using xargs is actually less efficient, because > there's one extra fo

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread Christos Zoulas
In article <20101110113444.ge...@apb-laptoy.apb.alt.za>, Alan Barrett wrote: >On Wed, 10 Nov 2010, Christoph Badura wrote: >> On Tue, Nov 09, 2010 at 08:34:56PM +, Alan Barrett wrote: >> > Modified Files: >> >src/usr.bin/pathchk: pathchk.1 >> > >> > Log Message: >> > Change the ironicall

Re: CVS commit: src/usr.bin/pathchk

2010-11-10 Thread Alan Barrett
On Wed, 10 Nov 2010, Christoph Badura wrote: > On Tue, Nov 09, 2010 at 08:34:56PM +, Alan Barrett wrote: > > Modified Files: > > src/usr.bin/pathchk: pathchk.1 > > > > Log Message: > > Change the ironically unafe "find . -print | xargs pathchk -p" to > > the safe "find . -exec pathchk -p \