Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread David Laight
On Thu, Sep 22, 2011 at 09:28:56PM +0200, Marc Balmer wrote: > > Am 22.09.2011 um 19:34 schrieb Christos Zoulas: > > > In article , > > Marc Balmer wrote: > >>> if (outfd == STDOUT_FILENO) > >>> return; > >>> > >>> - if (lseek(outfd, SEEK_SET, 0) < 0) > >>> + if (lseek(outfd, (off_

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread Marc Balmer
Am 22.09.2011 um 19:34 schrieb Christos Zoulas: > In article , > Marc Balmer wrote: >>> if (outfd == STDOUT_FILENO) >>> return; >>> >>> - if (lseek(outfd, SEEK_SET, 0) < 0) >>> + if (lseek(outfd, (off_t)0, SEEK_SET) == (off_t)-1) >>> err(1, "could not seek to st

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread Christos Zoulas
In article , Marc Balmer wrote: >> if (outfd == STDOUT_FILENO) >> return; >> >> -if (lseek(outfd, SEEK_SET, 0) < 0) >> +if (lseek(outfd, (off_t)0, SEEK_SET) == (off_t)-1) >> err(1, "could not seek to start of file for header rewrite"); > >Fwiw, this never c

Re: CVS commit: src/usr.bin/audio/record

2011-09-21 Thread Marc Balmer
Am 21.09.2011 um 16:32 schrieb Christos Zoulas: > Module Name: src > Committed By: christos > Date: Wed Sep 21 14:32:14 UTC 2011 > > Modified Files: > src/usr.bin/audio/record: record.c > > Log Message: > PR/45384: Henning Petersen: Swapped arguments in lseek > > > To generate