Re: CVS commit: src/sys/dev/rasops

2019-07-29 Thread Rin Okuyama
Thank you for rapid response. I was relieved to hear that. Let me apologize again for the breakage, and thank you very much for bisectioning the problem. rin On 2019/07/30 2:34, Ryo ONODERA wrote: Hi, Rin Okuyama writes: I committed a (possible) fix: http://mail-index.netbsd.org/source-chan

Re: CVS commit: src/sys/dev/rasops

2019-07-29 Thread Ryo ONODERA
Hi, Rin Okuyama writes: > I committed a (possible) fix: > http://mail-index.netbsd.org/source-changes/2019/07/29/msg107649.html > > Could you try rasops_putchar_width.h 1.8? With rasops_putchar_width.h 1.8, NetBSD/amd64-current on my laptop works fine again. Thanks for your quick fix. > Thank

Re: CVS commit: src/sys/dev/rasops

2019-07-29 Thread Rin Okuyama
I committed a (possible) fix: http://mail-index.netbsd.org/source-changes/2019/07/29/msg107649.html Could you try rasops_putchar_width.h 1.8? Thanks, rin On 2019/07/30 1:32, Ryo ONODERA wrote: Hi, "Rin Okuyama" writes: Module Name:src Committed By: rin Date: Mon Jul 29 03:0

Re: CVS commit: src/sys/dev/rasops

2019-07-29 Thread Rin Okuyama
Hi, Oops, sorry for breakage! Can you try the attached patch please? Thanks, rin On 2019/07/30 1:32, Ryo ONODERA wrote: Hi, "Rin Okuyama" writes: Module Name:src Committed By: rin Date: Mon Jul 29 03:01:09 UTC 2019 Modified Files: src/sys/dev/rasops: rasops2.c raso

Re: CVS commit: src/sys/dev/rasops

2019-07-29 Thread Ryo ONODERA
Hi, "Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Mon Jul 29 03:01:09 UTC 2019 > > Modified Files: > src/sys/dev/rasops: rasops2.c rasops4.c rasops_putchar_width.h > > Log Message: > Convert rasops2.c and rasops4.c to use rasops_putchar_width.h. > Style. > >

Re: CVS commit: src/sys/dev/rasops

2019-07-28 Thread Valery Ushakov
On Sun, Jul 28, 2019 at 02:18:14 -0400, Michael wrote: > On Sat, 27 Jul 2019 21:35:04 +0200 > Joerg Sonnenberger wrote: > > > On Fri, Jul 26, 2019 at 07:54:15AM -0300, Jared McNeill wrote: > > > On Fri, 26 Jul 2019, Rin Okuyama wrote: > > > > > > > Also, convert loop of byte-wise copy into me

Re: CVS commit: src/sys/dev/rasops

2019-07-27 Thread Michael
Hello, On Sat, 27 Jul 2019 21:35:04 +0200 Joerg Sonnenberger wrote: > On Fri, Jul 26, 2019 at 07:54:15AM -0300, Jared McNeill wrote: > > On Fri, 26 Jul 2019, Rin Okuyama wrote: > > > > > Also, convert loop of byte-wise copy into memset. > > > > I am a bit concerned about this change becaus

Re: CVS commit: src/sys/dev/rasops

2019-07-27 Thread Rin Okuyama
This part has already been reverted: http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/rasops/rasops.c#rev1.92 IMO, the fail-safe alternate is preferable over tiny optimization and simplification with possible dangers. Thanks, rin On 2019/07/28 4:35, Joerg Sonnenberger wrote: On Fri, Jul 26, 20

Re: CVS commit: src/sys/dev/rasops

2019-07-27 Thread Joerg Sonnenberger
On Fri, Jul 26, 2019 at 07:54:15AM -0300, Jared McNeill wrote: > On Fri, 26 Jul 2019, Rin Okuyama wrote: > > > Also, convert loop of byte-wise copy into memset. > > I am a bit concerned about this change because IIRC there are platforms > where memset etc. cannot be used on device memory. memset

Re: CVS commit: src/sys/dev/rasops

2019-07-26 Thread Rin Okuyama
Thank you for pointing it out! I didn't know that. I will revert this part soon. rin On 2019/07/26 19:54, Jared McNeill wrote: On Fri, 26 Jul 2019, Rin Okuyama wrote: Also, convert loop of byte-wise copy into memset. I am a bit concerned about this change because IIRC there are platforms wh

Re: CVS commit: src/sys/dev/rasops

2019-07-26 Thread Jared McNeill
On Fri, 26 Jul 2019, Rin Okuyama wrote: Also, convert loop of byte-wise copy into memset. I am a bit concerned about this change because IIRC there are platforms where memset etc. cannot be used on device memory.

Re: CVS commit: src/sys/dev/rasops

2011-12-26 Thread David Laight
On Sat, Dec 24, 2011 at 02:13:21AM +, Michael Lorenz wrote: > Module Name: src > Committed By: macallan > Date: Sat Dec 24 02:13:21 UTC 2011 > > Modified Files: > src/sys/dev/rasops: rasops32.c > > Log Message: > rename alpha variable to avoid conflict with a platform macro on