Re: CVS commit: src/sys/dev/fdt

2024-06-12 Thread Rin Okuyama
Thank you, too, for clarification! rin On 2024/06/13 5:10, Nick Hudson wrote: Thanks for the fix. The bug affects enable and disable in the all (-1) indexes case and references out of bounds data. Nick On 12/06/2024 08:36, Rin Okuyama wrote: Hmm, there was a confusion for my side. This bug

Re: CVS commit: src/sys/dev/fdt

2024-06-12 Thread Nick Hudson
Thanks for the fix. The bug affects enable and disable in the all (-1) indexes case and references out of bounds data. Nick On 12/06/2024 08:36, Rin Okuyama wrote: Hmm, there was a confusion for my side. This bug affected cases where (1) index >= 1 is explicitly specified for fdtbus_powerdom

Re: CVS commit: src/sys/dev/fdt

2024-06-12 Thread Rin Okuyama
Hmm, there was a confusion for my side. This bug affected cases where (1) index >= 1 is explicitly specified for fdtbus_powerdomain_enable_index(), as well as (2) all indices are implicitly specified by fdtbus_powerdomain_enable(). s/enable/disable/ functions were affected also. Thanks, rin

Re: CVS commit: src/sys/dev/fdt

2022-01-21 Thread Michael
Should fix PR 56650 > Module Name: src > Committed By: macallan > Date: Fri Jan 21 21:00:26 UTC 2022 > > Modified Files: > src/sys/dev/fdt: fdt_port.c > > Log Message: > when enumerating ports and endpoints treat missing 'reg' properties as zero > ok jmcneill: > Looking at Linux.

Re: CVS commit: src/sys/dev/fdt

2020-10-02 Thread Rin Okuyama
On 2020/10/02 22:42, Jonathan A. Kollasch wrote: On Sun, Jul 21, 2019 at 03:57:24PM +, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Sun Jul 21 15:57:24 UTC 2019 Modified Files: src/sys/dev/fdt: dw_apb_uart.c Log Message: The device cannot recognize bre

Re: CVS commit: src/sys/dev/fdt

2020-10-02 Thread Jonathan A. Kollasch
On Sun, Jul 21, 2019 at 03:57:24PM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Sun Jul 21 15:57:24 UTC 2019 > > Modified Files: > src/sys/dev/fdt: dw_apb_uart.c > > Log Message: > The device cannot recognize break signal. Use + (five plus signs) as

Re: CVS commit: src/sys/dev/fdt

2019-11-23 Thread Herbert J. Skuhra
On Sat, 23 Nov 2019 19:53:05 +0100, "Jared D. McNeill" wrote: > > Module Name: src > Committed By: jmcneill > Date: Sat Nov 23 18:53:05 UTC 2019 > > Modified Files: > src/sys/dev/fdt: fdt_port.c > > Log Message: > Use fdtbus_get_reg to read "reg" property Hi, this change breaks

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jason Thorpe
> On Jun 20, 2018, at 12:29 PM, Jared McNeill wrote: >> Sure, but where is the code for the brcm2835 platform that *processes* it? >> I see stuff for parsing console / fb options, but not for standard boot >> flags. > > Firmware puts the string in /chosen/bootargs and we pick it up here: >

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jared McNeill
> On Jun 20, 2018, at 4:25 PM, Jason Thorpe wrote: > >> On Jun 20, 2018, at 9:56 AM, Jared McNeill wrote: >> >> On Wed, 20 Jun 2018, Jason Thorpe wrote: >> >>> ofctl(8) is pretty useless for this purpose because it doesn't show you >>> which driver instance has attached to a given device tre

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jason Thorpe
> On Jun 20, 2018, at 9:56 AM, Jared McNeill wrote: > > On Wed, 20 Jun 2018, Jason Thorpe wrote: > >> ofctl(8) is pretty useless for this purpose because it doesn't show you >> which driver instance has attached to a given device tree node. As for >> passing generic boot args, it's not obv

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jared McNeill
On Wed, 20 Jun 2018, Jason Thorpe wrote: ofctl(8) is pretty useless for this purpose because it doesn't show you which driver instance has attached to a given device tree node. As for passing generic boot args, it's not obvious how one does that on the RPI (and I don't even see the hook that

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jason Thorpe
> On Jun 20, 2018, at 2:06 AM, Jared McNeill wrote: > > Not a fan of this, some of these paths can get fairly long (boot the > VEXPRESS_A15 kernel to see for yourself) and the path is only really useful > if you are debugging something. Sigh. > If you want to see the debugging information

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jared McNeill
Not a fan of this, some of these paths can get fairly long (boot the VEXPRESS_A15 kernel to see for yourself) and the path is only really useful if you are debugging something. If you want to see the debugging information we already have a way to do that with boot -x. You can also inspect the