Re: CVS commit: src/sys/dev/dkwedge

2023-04-13 Thread Taylor R Campbell
> Date: Tue, 11 Apr 2023 21:50:49 +0200 > From: Michael van Elst > > On Wed, Apr 12, 2023 at 01:10:40AM +0700, Robert Elz wrote: > > > > | In that state then decrementing dk_rawopens beyond zero will make > > | dklastclose do the right thing: nothing. > > > > Except that if that happens, dk

Re: CVS commit: src/sys/dev/dkwedge

2023-04-11 Thread Michael van Elst
On Wed, Apr 12, 2023 at 01:10:40AM +0700, Robert Elz wrote: > > | In that state then decrementing dk_rawopens beyond zero will make > | dklastclose do the right thing: nothing. > > Except that if that happens, dk_rawopens will be left == ~0 and the next > open attempt will then increment it,

Re: CVS commit: src/sys/dev/dkwedge

2023-04-11 Thread Robert Elz
Date:Tue, 11 Apr 2023 17:21:17 +0200 From:Michael van Elst Message-ID: | In that state then decrementing dk_rawopens beyond zero will make | dklastclose do the right thing: nothing. Except that if that happens, dk_rawopens will be left == ~0 and the next open at

Re: CVS commit: src/sys/dev/dkwedge

2023-04-11 Thread Michael van Elst
On Tue, Apr 11, 2023 at 09:07:49AM +, Taylor R Campbell wrote: > > (a) how we can legitimately enter a state where the assertions are > violated, and dklastclose is called when the close operation ends in no more openers. There is nothing that guarantees that any open was successful befor

Re: CVS commit: src/sys/dev/dkwedge

2023-04-11 Thread Taylor R Campbell
> Module Name:src > Committed By: mlelstv > Date: Tue Sep 27 17:04:52 UTC 2022 > > Modified Files: > src/sys/dev/dkwedge: dk.c > > Log Message: > Remove bogus assertions. > > @@ -1221,8 +1221,6 @@ dklastclose(struct dkwedge_softc *sc) > > KASSERT(mutex_owned(&sc

Re: CVS commit: src/sys/dev/dkwedge

2016-01-15 Thread Christos Zoulas
> >Log Message: >Allow dump to raidframe component which is a wedge. > >N.B. ordinary devices check the partition type only in the xxxsize routine. This is a little scary... christos

Re: CVS commit: src/sys/dev/dkwedge

2012-06-07 Thread David Laight
On Thu, Jun 07, 2012 at 04:15:32PM +, Michael van Elst wrote: > Module Name: src > Committed By: mlelstv > Date: Thu Jun 7 16:15:32 UTC 2012 > > Modified Files: > src/sys/dev/dkwedge: dkwedge_bsdlabel.c > > Log Message: > Use the label's packname to create wedge names instead