In article <20190206201922.ga8...@homeworld.netbsd.org>,
wrote:
>On Wed, Feb 06, 2019 at 12:56:57PM -0500, Christos Zoulas wrote:
>D.org>
>> @@ -66,7 +66,7 @@ crgetgroups(cred_t *cr)
>> {
>> static gid_t gids[NGROUPS_MAX];
>
>I feel uncomfortable seeing unnecessary use of static.
>(I find i
m...@netbsd.org writes:
> On Wed, Feb 06, 2019 at 12:56:57PM -0500, Christos Zoulas wrote:
> D.org>
> > @@ -66,7 +66,7 @@ crgetgroups(cred_t *cr)
> > {
> > static gid_t gids[NGROUPS_MAX];
>
> I feel uncomfortable seeing unnecessary use of static.
> (I find it too magical)
>
> What do others
On Wed, Feb 06, 2019 at 12:56:57PM -0500, Christos Zoulas wrote:
D.org>
> @@ -66,7 +66,7 @@ crgetgroups(cred_t *cr)
> {
> static gid_t gids[NGROUPS_MAX];
I feel uncomfortable seeing unnecessary use of static.
(I find it too magical)
What do others think?
>
> - memset(gids, 0, NGROUP
Hi,
"Chuck Silvers" writes:
> Committed By: chs
> [...]
> Log Message:
> tweak the osnet compat headers to allow building on MacOS and Linux hosts.
Thanks a lot. The tools build works for me under Linux now.
Regards,
Aymeric
In article <20171118185259.821e7f...@cvs.netbsd.org>,
Robert Elz wrote:
>-=-=-=-=-=-
>
>Module Name: src
>Committed By: kre
>Date: Sat Nov 18 18:52:59 UTC 2017
>
>Modified Files:
> src/external/cddl/osnet/sys/sys: kmem.h
>
>Log Message:
>Let's define symbols before using them.
T
On 11/17/17 18:18, Christos Zoulas wrote:
+ if (flags == 0)
+ flags |= KM_SLEEP;
+ return pool_cache_get(cache, flags);
PR_WAITOK? I know it matches, but it looks odd.
Nick
Nice catch!
Perhaps an entry in src/doc/HACKS would be appropriate?
Thanks,
Al
On 21 December 2015 at 05:28, Joerg Sonnenberger wrote:
> Module Name:src
> Committed By: joerg
> Date: Mon Dec 21 13:28:39 UTC 2015
>
> Modified Files:
> src/external/cddl/osnet/sys/sys: time
On 03.01.2013 17:59, David Laight wrote:
On Thu, Jan 03, 2013 at 04:42:55PM +, David Laight wrote:
Module Name:src
Committed By: dsl
Date: Thu Jan 3 16:42:55 UTC 2013
Modified Files:
src/external/cddl/osnet/sys/sys: random.h
Log Message:
Use cprgn_fast() not rnd_ex
On Thu, Jan 03, 2013 at 04:42:55PM +, David Laight wrote:
> Module Name: src
> Committed By: dsl
> Date: Thu Jan 3 16:42:55 UTC 2013
>
> Modified Files:
> src/external/cddl/osnet/sys/sys: random.h
>
> Log Message:
> Use cprgn_fast() not rnd_extract_data().
> The latter isn't i
