Re: CVS commit: src/bin/ls

2024-11-06 Thread Jan Schaumann
Robert Elz wrote: > | How about the attached diff? > > Yes, that all looks good. Ok, just committed that together with your other suggestions. Thanks for the feedback! -Jan

Re: CVS commit: src/bin/ls

2024-11-05 Thread Robert Elz
Date:Tue, 5 Nov 2024 16:50:06 -0500 From:Jan Schaumann Message-ID: | +In multi-column output | +.Pq Fl C No or Fl x , | +a total sum for all the file sizes is output on a line before the listing. should probably say (the first two lines there, and then): a

Re: CVS commit: src/bin/ls

2024-11-05 Thread Robert Elz
Date:Tue, 5 Nov 2024 16:50:06 -0500 From:Jan Schaumann Message-ID: That is, it looks good aside from this: | +.Ns ( Fl C | +or | +.Fl x Ns ), Ns as the first macro on a line makes no sense, there is nothing to have no space after, try instead .Pq Fl

Re: CVS commit: src/bin/ls

2024-11-05 Thread Robert Elz
Date:Tue, 5 Nov 2024 16:50:06 -0500 From:Jan Schaumann Message-ID: | How about the attached diff? Yes, that all looks good. I wasn't sure the change to printcol() would be that simple, but it looks good, the one to printacol() is exactly as I imagined it! kre

Re: CVS commit: src/bin/ls

2024-11-05 Thread Jan Schaumann
Robert Elz wrote: > Is is the output format which is chosen (by option, or by > using the rule to select the default) which affects what is > output. > > And I believe that the -x and -C variation depending upon how > many columns are output really is a bug, that should just be > fixed. How abo

Re: CVS commit: src/bin/ls

2024-11-05 Thread Robert Elz
Date:Tue, 5 Nov 2024 13:32:01 -0500 From:Jan Schaumann Message-ID: | "If the output is to a terminal and results in multiple | columns being printed, a total sum for all the file | sizes is output on a line before the listing." It actually has almost nothing t

Re: CVS commit: src/bin/ls

2024-11-05 Thread Jan Schaumann
Robert Elz wrote: > It is more complex than that Hmm. Maybe "If the output is to a terminal and results in multiple columns being printed, a total sum for all the file sizes is output on a line before the listing." ? (The fact that "total" is printed for '-l' whether or not output goes to a

Re: CVS commit: src/bin/ls

2024-11-05 Thread Robert Elz
Date:Tue, 5 Nov 2024 04:04:19 + From:"Jan Schaumann" Message-ID: <20241105040419.6c798f...@cvs.netbsd.org> | Note that when '-s' is combined with '-1', the 'total' is _not_ printed. It is more complex than that (though that is correct, and applies when the -1 i

Re: CVS commit: src/bin/ls

2014-02-21 Thread Hisashi T Fujinaka
On Sat, 22 Feb 2014, David Holland wrote: On Fri, Feb 21, 2014 at 06:23:43PM +, Christos Zoulas wrote: > >>Log Message: > >>Add -O (only leaf files) and -P (print full path), from tls@ > > > >Do any other ls implementations have such options? I like the > >idea of being able to run "ls -ROP

Re: CVS commit: src/bin/ls

2014-02-21 Thread David Holland
On Fri, Feb 21, 2014 at 06:23:43PM +, Christos Zoulas wrote: > >>Log Message: > >>Add -O (only leaf files) and -P (print full path), from tls@ > > > >Do any other ls implementations have such options? I like the > >idea of being able to run "ls -ROP1 ." instead of "find . type > >f -pr

Re: CVS commit: src/bin/ls

2014-02-21 Thread Christos Zoulas
In article <20140221065057.gm1...@apb-laptoy.apb.alt.za>, Alan Barrett wrote: >On Thu, 20 Feb 2014, Christos Zoulas wrote: >>Modified Files: >> src/bin/ls: ls.1 ls.c ls.h print.c >> >>Log Message: >>Add -O (only leaf files) and -P (print full path), from tls@ > >Do any other ls implementatio

Re: CVS commit: src/bin/ls

2014-02-20 Thread Alan Barrett
On Thu, 20 Feb 2014, Christos Zoulas wrote: Modified Files: src/bin/ls: ls.1 ls.c ls.h print.c Log Message: Add -O (only leaf files) and -P (print full path), from tls@ Do any other ls implementations have such options? I like the idea of being able to run "ls -ROP1 ." instead of "fi