Re: CVS commit: othersrc/zfs/external/cddl/osnet/dist

2009-03-26 Thread Andrew Doran
On Thu, Mar 26, 2009 at 10:21:49PM +, Andrew Doran wrote: > On Fri, Mar 27, 2009 at 09:14:40AM +1100, Simon Burge wrote: > > > +#ifdef __NetBSD__ > > +#include > > +#definebtop(x) ((x) * PAGE_SIZE) > > [ ... ] > > > > Isn't that working out "pages to bytes" and not "bytes t

Re: CVS commit: othersrc/zfs/external/cddl/osnet/dist

2009-03-26 Thread Andrew Doran
On Fri, Mar 27, 2009 at 09:14:40AM +1100, Simon Burge wrote: > +#ifdef __NetBSD__ > +#include > +#definebtop(x) ((x) * PAGE_SIZE) > [ ... ] > > Isn't that working out "pages to bytes" and not "bytes to pages" ? > > Unless btop() means something non-obvious in Solaris land...

Re: CVS commit: othersrc/zfs/external/cddl/osnet/dist

2009-03-26 Thread Simon Burge
Andrew Doran wrote: > Module Name: othersrc > Committed By: ad > Date: Thu Mar 26 21:50:47 UTC 2009 > > Modified Files: > > othersrc/zfs/external/cddl/osnet/dist/cmd/zpool: zpool_vdev.c > othersrc/zfs/external/cddl/osnet/dist/cmd/ztest: ztest.c > othersrc/zfs/external/