Re: CVS commit: src/sys/dev/nvmm/x86

2025-04-15 Thread Andrius V
nvmm_x86_svm.c has same typos. On Mon, Apr 14, 2025, 01:00 Taylor R Campbell wrote: > Module Name:src > Committed By: riastradh > Date: Sun Apr 13 22:00:43 UTC 2025 > > Modified Files: > src/sys/dev/nvmm/x86: nvmm_x86_vmx.c > > Log Message: > nvmm(4): Fix typos in commen

CVS commit: src/sys/dev/nvmm/x86

2025-03-09 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 9 19:16:47 UTC 2025 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: nvmm(4): Add comments explaining unknown CPUID behaviour. Sprinkle some more comments about the CPUID ranges too. N

CVS commit: src/sys/dev/nvmm/x86

2025-03-09 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 9 19:16:47 UTC 2025 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: nvmm(4): Add comments explaining unknown CPUID behaviour. Sprinkle some more comments about the CPUID ranges too. N

CVS commit: src/sys/dev/nvmm/x86

2023-11-06 Thread Rin Okuyama
Module Name:src Committed By: rin Date: Mon Nov 6 17:02:17 UTC 2023 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: nvmm_x86_vmx: vmx_vmptrst: Sprinkle __diagused to fix clang !DIAGNOSTIC build To generate a diff of this commit: cvs rdiff -u -r1.85 -r1

CVS commit: src/sys/dev/nvmm/x86

2023-11-06 Thread Rin Okuyama
Module Name:src Committed By: rin Date: Mon Nov 6 17:02:17 UTC 2023 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: nvmm_x86_vmx: vmx_vmptrst: Sprinkle __diagused to fix clang !DIAGNOSTIC build To generate a diff of this commit: cvs rdiff -u -r1.85 -r1

CVS commit: src/sys/dev/nvmm/x86

2023-02-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Feb 23 02:54:02 UTC 2023 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: nvmm: Filter CR4 bits on x86 SVM (AMD). In particular, prohibit PKE, Protection Key Enable, which requires some additional manageme

CVS commit: src/sys/dev/nvmm/x86

2023-02-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Feb 23 02:54:02 UTC 2023 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: nvmm: Filter CR4 bits on x86 SVM (AMD). In particular, prohibit PKE, Protection Key Enable, which requires some additional manageme

Re: CVS commit: src/sys/dev/nvmm

2022-09-15 Thread Reinoud Zandijk
Hi Taylor, Thanks for updating NVMM! Would it be a good idea to sync our code with DragonBSDs? AFAICS they kept the code compiling for NetBSD too. To have a common code base? With regards, Reinoud On Tue, Sep 13, 2022 at 08:10:04PM +, Taylor R Campbell wrote: > Module Name: src > Committed

CVS commit: src/sys/dev/nvmm

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 20:10:04 UTC 2022 Modified Files: src/sys/dev/nvmm: nvmm.c nvmm_internal.h src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: nvmm(4): Add suspend/resume support. New MD nvmm_impl callbacks: - .suspend_inter

CVS commit: src/sys/dev/nvmm

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 20:10:04 UTC 2022 Modified Files: src/sys/dev/nvmm: nvmm.c nvmm_internal.h src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: nvmm(4): Add suspend/resume support. New MD nvmm_impl callbacks: - .suspend_inter

CVS commit: src/sys/dev/nvmm

2022-07-07 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Jul 7 23:50:34 UTC 2022 Modified Files: src/sys/dev/nvmm: nvmm.c Log Message: Only detach the cfdriver if we just attached it. Report errno in message when fail to attach cdevsw To generate a diff of this commit: cvs rdi

CVS commit: src/sys/dev/nvmm

2022-07-07 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Jul 7 23:50:34 UTC 2022 Modified Files: src/sys/dev/nvmm: nvmm.c Log Message: Only detach the cfdriver if we just attached it. Report errno in message when fail to attach cdevsw To generate a diff of this commit: cvs rdi

CVS commit: src/sys/dev/nvmm

2022-07-06 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 6 13:10:49 UTC 2022 Modified Files: src/sys/dev/nvmm: nvmm.c Log Message: nvmm(4): Fix typo in previous. Didn't trip over this in my test build because nvmm is a module, oops. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/nvmm

2022-07-06 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 6 13:10:49 UTC 2022 Modified Files: src/sys/dev/nvmm: nvmm.c Log Message: nvmm(4): Fix typo in previous. Didn't trip over this in my test build because nvmm is a module, oops. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/nvmm/x86

2022-05-13 Thread Tobias Nygren
Module Name:src Committed By: tnn Date: Fri May 13 19:34:47 UTC 2022 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: nvmm_x86_vmx.c: remove an #ifdef DIAGNOSTIC, it is wrong since r1.66 To generate a diff of this commit: cvs rdiff -u -r1.82 -r1.83 src/s

CVS commit: src/sys/dev/nvmm/x86

2022-05-13 Thread Tobias Nygren
Module Name:src Committed By: tnn Date: Fri May 13 19:34:47 UTC 2022 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: nvmm_x86_vmx.c: remove an #ifdef DIAGNOSTIC, it is wrong since r1.66 To generate a diff of this commit: cvs rdiff -u -r1.82 -r1.83 src/s

CVS commit: src/sys/dev/nvmm/x86

2019-11-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 20 10:26:56 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Hide XSAVES-specific stuff and the masked extended states. To generate a diff of this commit: cvs rdiff -u -r1.53 -r1.54

CVS commit: src/sys/dev/nvmm/x86

2019-11-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 20 10:26:56 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Hide XSAVES-specific stuff and the masked extended states. To generate a diff of this commit: cvs rdiff -u -r1.53 -r1.54

CVS commit: src/sys/dev/nvmm/x86

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 17:53:46 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86.c Log Message: Don't report MWAITX by default. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/nvmm/x86/nvmm_x86.c Please note th

CVS commit: src/sys/dev/nvmm/x86

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 17:53:46 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86.c Log Message: Don't report MWAITX by default. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/nvmm/x86/nvmm_x86.c Please note th

CVS commit: src/sys/dev/nvmm

2019-10-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Oct 28 09:00:08 UTC 2019 Modified Files: src/sys/dev/nvmm: nvmm.c nvmm_ioctl.h Log Message: Add nram in struct nvmm_ctl_mach_info. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/dev/nvmm/nvmm.c cvs rdiff

CVS commit: src/sys/dev/nvmm

2019-10-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Oct 28 09:00:08 UTC 2019 Modified Files: src/sys/dev/nvmm: nvmm.c nvmm_ioctl.h Log Message: Add nram in struct nvmm_ctl_mach_info. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/dev/nvmm/nvmm.c cvs rdiff

CVS commit: src/sys/dev/nvmm/x86

2019-10-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Oct 27 18:26:54 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Add PCID support in the guests. This speeds up most 64bit guests, because since Meltdown, everybody uses PCID (including NetBSD). To ge

CVS commit: src/sys/dev/nvmm/x86

2019-10-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Oct 27 18:26:54 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Add PCID support in the guests. This speeds up most 64bit guests, because since Meltdown, everybody uses PCID (including NetBSD). To ge

CVS commit: src/sys/dev/nvmm/x86

2019-10-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Oct 27 11:11:09 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Mask CPUID leaf 0x0A on Intel, because we don't want the guest to try (and fail) to probe the PMC MSRs. This avoids "Unexpected WRMSR" wa

CVS commit: src/sys/dev/nvmm/x86

2019-10-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Oct 27 11:11:09 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Mask CPUID leaf 0x0A on Intel, because we don't want the guest to try (and fail) to probe the PMC MSRs. This avoids "Unexpected WRMSR" wa

CVS commit: src/sys/dev/nvmm/x86

2019-10-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Oct 4 12:17:05 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Switch to the new PTE naming. To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/nvmm/x86/nvmm_x8

CVS commit: src/sys/dev/nvmm/x86

2019-10-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Oct 4 12:17:05 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Switch to the new PTE naming. To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/nvmm/x86/nvmm_x8

CVS commit: src/sys/dev/nvmm/x86

2019-10-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Oct 4 12:15:21 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: Fix definition for MWAIT. It should be bit 11, not 12; 12 is the armed version. To generate a diff of this commit: cvs rdiff -u -r1.47

CVS commit: src/sys/dev/nvmm/x86

2019-10-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Oct 4 12:15:21 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: Fix definition for MWAIT. It should be bit 11, not 12; 12 is the armed version. To generate a diff of this commit: cvs rdiff -u -r1.47

CVS commit: src/sys/dev/nvmm/x86

2019-10-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Oct 4 12:11:38 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: Add definitions for RDPRU, MCOMMIT, GMET and VTE. To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47 src/sys/dev/nvmm/x86/nv

CVS commit: src/sys/dev/nvmm/x86

2019-10-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Oct 4 12:11:38 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: Add definitions for RDPRU, MCOMMIT, GMET and VTE. To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47 src/sys/dev/nvmm/x86/nv

CVS commit: src/sys/dev/nvmm/x86

2019-09-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Sep 13 14:19:13 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Always set hwcode on error. Useful for debugging. To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37 src/sys/dev/nvmm/x86/nv

CVS commit: src/sys/dev/nvmm/x86

2019-09-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Sep 13 14:19:13 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Always set hwcode on error. Useful for debugging. To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37 src/sys/dev/nvmm/x86/nv

CVS commit: src/sys/dev/nvmm

2019-07-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jul 6 05:13:11 UTC 2019 Modified Files: src/sys/dev/nvmm: nvmm.c nvmm_internal.h Log Message: Localify two functions that are no longer used outside. Also return the error from the *_vcpu_run() functions, now that we commit the

CVS commit: src/sys/dev/nvmm

2019-07-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jul 6 05:13:11 UTC 2019 Modified Files: src/sys/dev/nvmm: nvmm.c nvmm_internal.h Log Message: Localify two functions that are no longer used outside. Also return the error from the *_vcpu_run() functions, now that we commit the

CVS commit: src/sys/dev/nvmm/x86

2019-06-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 16 18:30:31 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Make sure VMX-outside-SMX is allowed. It may not be if the BIOS decided to disable VMX. Seen on an HP laptop, where NVMM would panic beca

CVS commit: src/sys/dev/nvmm/x86

2019-06-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 16 18:30:31 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Make sure VMX-outside-SMX is allowed. It may not be if the BIOS decided to disable VMX. Seen on an HP laptop, where NVMM would panic beca

CVS commit: src/sys/dev/nvmm/x86

2019-05-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 18 08:55:59 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Now that SVS cannot be disabled at run time, MSR_LSTAR is static, so no need to save it on each VM enter. To generate a diff of this co

CVS commit: src/sys/dev/nvmm/x86

2019-05-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 18 08:55:59 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Now that SVS cannot be disabled at run time, MSR_LSTAR is static, so no need to save it on each VM enter. To generate a diff of this co

CVS commit: src/sys/dev/nvmm/x86

2019-05-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed May 15 04:39:52 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86.c Log Message: NVMM: Expose MD_CLEAR to the guests. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/nvmm/x86/nvmm_x86.c Please no

CVS commit: src/sys/dev/nvmm/x86

2019-05-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed May 15 04:39:52 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86.c Log Message: NVMM: Expose MD_CLEAR to the guests. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/nvmm/x86/nvmm_x86.c Please no

Re: CVS commit: src/sys/dev/nvmm

2019-04-08 Thread Maxime Villard
Le 08/04/2019 à 09:57, Paul Goyette a écrit : On Mon, 8 Apr 2019, Maxime Villard wrote: The reason I use MODULE_CLASS_ANY in both NVMM and KCOV is because this class is invoked late in the boot process (init_main.c). Eg NVMM will use allocators/xcalls which are not yet initialized in MODULE_CLA

Re: CVS commit: src/sys/dev/nvmm

2019-04-08 Thread Paul Goyette
On Mon, 8 Apr 2019, Maxime Villard wrote: The reason I use MODULE_CLASS_ANY in both NVMM and KCOV is because this class is invoked late in the boot process (init_main.c). Eg NVMM will use allocators/xcalls which are not yet initialized in MODULE_CLASS_DRIVER, but are in MODULE_CLASS_ANY. No, a

Re: CVS commit: src/sys/dev/nvmm

2019-04-07 Thread Maxime Villard
Le 07/04/2019 à 22:58, Paul Goyette a écrit : On Sun, 7 Apr 2019, Maxime Villard wrote: Module Name:    src Committed By:    maxv Date:    Sun Apr  7 14:05:15 UTC 2019 Modified Files: src/sys/dev/nvmm: nvmm.c Log Message: Don't allow unloading when there are still VMs registered, and

Re: CVS commit: src/sys/dev/nvmm

2019-04-07 Thread Paul Goyette
On Sun, 7 Apr 2019, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Sun Apr 7 14:05:15 UTC 2019 Modified Files: src/sys/dev/nvmm: nvmm.c Log Message: Don't allow unloading when there are still VMs registered, and don't allow auto-unloading at all. Not a