CVS commit: src/sys/dev/ieee1394

2022-08-20 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sat Aug 20 19:01:32 UTC 2022 Modified Files: src/sys/dev/ieee1394: if_fwip.c Log Message: fwip_async_output(): Replace "IF_DEQUEUE() -> IF_PREPEND() on failure" with "IF_POLL() -> IF_DEQUEUE() on success". To generate a diff of

CVS commit: src/sys/dev/ieee1394

2022-08-20 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sat Aug 20 19:01:32 UTC 2022 Modified Files: src/sys/dev/ieee1394: if_fwip.c Log Message: fwip_async_output(): Replace "IF_DEQUEUE() -> IF_PREPEND() on failure" with "IF_POLL() -> IF_DEQUEUE() on success". To generate a diff of

CVS commit: src/sys/dev/ieee1394

2021-12-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Dec 20 19:56:42 UTC 2021 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: ieee1394: Need kernel lock around config_found. To generate a diff of this commit: cvs rdiff -u -r1.53 -r1.54 src/sys/dev/ieee1394/fir

CVS commit: src/sys/dev/ieee1394

2021-12-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Dec 20 19:56:42 UTC 2021 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: ieee1394: Need kernel lock around config_found. To generate a diff of this commit: cvs rdiff -u -r1.53 -r1.54 src/sys/dev/ieee1394/fir

CVS commit: src/sys/dev/ieee1394

2021-12-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Sun Dec 5 08:17:21 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: s/transcat/transact/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.148 -r1.149 src/sys/dev/ieee1394/fwohci.c Please not

CVS commit: src/sys/dev/ieee1394

2021-12-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Sun Dec 5 08:17:21 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: s/transcat/transact/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.148 -r1.149 src/sys/dev/ieee1394/fwohci.c Please not

CVS commit: src/sys/dev/ieee1394

2021-11-10 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Nov 10 16:08:17 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: s/avaliable/available/ To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/ieee1394/fwdev.c Please note that diffs a

CVS commit: src/sys/dev/ieee1394

2021-11-10 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Nov 10 16:08:17 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: s/avaliable/available/ To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/ieee1394/fwdev.c Please note that diffs a

CVS commit: src/sys/dev/ieee1394

2019-10-15 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Oct 15 18:21:47 UTC 2019 Modified Files: src/sys/dev/ieee1394: firewire.c fwohci.c fwohcireg.h Log Message: Use unsigned to avoid undefined behavior. Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.48

CVS commit: src/sys/dev/ieee1394

2019-10-15 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Oct 15 18:21:47 UTC 2019 Modified Files: src/sys/dev/ieee1394: firewire.c fwohci.c fwohcireg.h Log Message: Use unsigned to avoid undefined behavior. Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.48

CVS commit: src/sys/dev/ieee1394

2019-09-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Sep 23 06:56:20 UTC 2019 Modified Files: src/sys/dev/ieee1394: sbp.c Log Message: Remove unused assignment. Found by the lgtm bot. To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/sys/dev/ieee1394/sbp.c Pleas

CVS commit: src/sys/dev/ieee1394

2019-09-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Sep 23 06:56:20 UTC 2019 Modified Files: src/sys/dev/ieee1394: sbp.c Log Message: Remove unused assignment. Found by the lgtm bot. To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/sys/dev/ieee1394/sbp.c Pleas

Converting to condvar(9) [Was: Re: CVS commit: src/sys/dev/ieee1394]

2010-09-05 Thread Mindaugas Rasiukevicius
Christoph Egger wrote: > >> Log Message: > >> don't call tsleep() with any mutexes hold > >> > >> > >> To generate a diff of this commit: > >> cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ieee1394/fwdev.c > > > > The right fix would be to use condvar(9). Generally, tsleep(9) should > > be replaced and

Re: CVS commit: src/sys/dev/ieee1394

2010-08-31 Thread Adam Hoka
On Tue, 31 Aug 2010 08:31:27 +0200 Christoph Egger wrote: > On 26.08.10 16:31, Mindaugas Rasiukevicius wrote: > >> Module Name:src > >> Committed By: cegger > >> Date: Thu Aug 26 12:48:19 UTC 2010 > >> > >> Modified Files: > >> src/sys/dev/ieee1394: fwdev.c > >> > >> Log M

Re: CVS commit: src/sys/dev/ieee1394

2010-08-30 Thread Christoph Egger
On 26.08.10 16:31, Mindaugas Rasiukevicius wrote: >> Module Name:src >> Committed By: cegger >> Date: Thu Aug 26 12:48:19 UTC 2010 >> >> Modified Files: >> src/sys/dev/ieee1394: fwdev.c >> >> Log Message: >> don't call tsleep() with any mutexes hold >> >> >> To generate a di

Re: CVS commit: src/sys/dev/ieee1394

2010-08-26 Thread Mindaugas Rasiukevicius
> Module Name:src > Committed By: cegger > Date: Thu Aug 26 12:48:19 UTC 2010 > > Modified Files: > src/sys/dev/ieee1394: fwdev.c > > Log Message: > don't call tsleep() with any mutexes hold > > > To generate a diff of this commit: > cvs rdiff -u -r1.23 -r1.24 src/sys/de

Re: CVS commit: src/sys/dev/ieee1394

2010-05-25 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: > | Yes. It knows I was broken, too. However, it worked on my ofppc and > | it booted my amd64. > > Try booting with DIAGNOSTIC. If you make any changes to the kernel you > should be really compiling with DIAGNOSTIC. It should be tested both with DEBUG

Re: CVS commit: src/sys/dev/ieee1394

2010-05-25 Thread Christos Zoulas
On May 25, 4:33pm, j...@soum.co.jp (Jun Ebihara) wrote: -- Subject: Re: CVS commit: src/sys/dev/ieee1394 | Hello Christos! | | From: chris...@zoulas.com (Christos Zoulas) | Subject: Re: CVS commit: src/sys/dev/ieee1394 | Date: Mon, 24 May 2010 10:36:49 -0400 | | > | In many cases, there i

Re: CVS commit: src/sys/dev/ieee1394

2010-05-25 Thread Jun Ebihara
Hello Christos! From: chris...@zoulas.com (Christos Zoulas) Subject: Re: CVS commit: src/sys/dev/ieee1394 Date: Mon, 24 May 2010 10:36:49 -0400 > | In many cases, there is a case that cannot be fixed in several days. For > | instance, MIPS cannot be booted since merge mips64. > This is

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Christos Zoulas
On May 24, 10:32pm, kiyoh...@kk.iij4u.or.jp (KIYOHARA Takashi) wrote: -- Subject: Re: CVS commit: src/sys/dev/ieee1394 | Hi! | | | From: Izumi Tsutsui | Date: Mon, 24 May 2010 22:08:21 +0900 | | > > Why you revert it all? | > | > Wasn't it broken? | | Yes. It knows

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Izumi Tsutsui
> In many cases, there is a case that cannot be fixed in several days. For In any case you should revert your changes first if you know you broke the tree and you can't fix it soon. --- Izumi Tsutsui

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread KIYOHARA Takashi
Hi! From: Izumi Tsutsui Date: Mon, 24 May 2010 22:08:21 +0900 > > Why you revert it all? > > Wasn't it broken? Yes. It knows I was broken, too. However, it worked on my ofppc and it booted my amd64. > > I had been investigating the problem of kmem since last week. Was not > > There is no

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Izumi Tsutsui
> Why you revert it all? Wasn't it broken? > I had been investigating the problem of kmem since last week. Was not There is no reason to leave kernels broken even if you have some idea for proper fixes. You can put them even after you (or other guys) revert the previous changes, can't you? ---

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Christos Zoulas
On May 24, 2:23pm, kiyoh...@kk.iij4u.or.jp (KIYOHARA Takashi) wrote: -- Subject: Re: CVS commit: src/sys/dev/ieee1394 | Hi! Christos, | | | From: Christos Zoulas | Date: Sun, 23 May 2010 14:56:59 -0400 | | > Module Name:src | > Committed By: christos | > Date:

Re: CVS commit: src/sys/dev/ieee1394

2010-05-23 Thread KIYOHARA Takashi
Hi! Christos, From: Christos Zoulas Date: Sun, 23 May 2010 14:56:59 -0400 > Module Name: src > Committed By: christos > Date: Sun May 23 18:56:59 UTC 2010 > > Modified Files: > src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwdma.c fwmem.c > fwohci.c fwohcivar.

Re: CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Hi! From: Adam Hoka Date: Thu, 29 Apr 2010 09:38:31 +0200 > On Thu, 29 Apr 2010 06:56:00 + > KIYOHARA Takashi wrote: > > > Module Name:src > > Committed By: kiyohara > > Date: Thu Apr 29 06:56:00 UTC 2010 > > > > Modified Files: > > src/sys/dev/ieee1394: f

Re: CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread Adam Hoka
On Thu, 29 Apr 2010 06:56:00 + KIYOHARA Takashi wrote: > Module Name: src > Committed By: kiyohara > Date: Thu Apr 29 06:56:00 UTC 2010 > > Modified Files: > src/sys/dev/ieee1394: fwdma.c > > Log Message: > Call malloc(M_ZERO) instead of malloc() and memset(). Why not kmem_z