Yet again forgot to add: reviewed and approved by riastradh and bad. Thank you!
Also tested on the multiple VIA V-RAID devices (removing disks, mixing
different RAID arrays, two RAID controllers at the same motherboard
(both setup in ataraid(4) and disks removed or swapped), etc).
On Sun, Mar 16,
Module Name:src
Committed By: andvar
Date: Sun Mar 16 12:27:50 UTC 2025
Modified Files:
src/sys/dev/ata: ata_raid_subr.c ld_ataraid.c
Log Message:
ataraid(4), ld(4): ensure RAID disk status is set before resolving vnode.
Given a RAID array disk is missing (due to removal,
Module Name:src
Committed By: andvar
Date: Sun Mar 16 12:27:50 UTC 2025
Modified Files:
src/sys/dev/ata: ata_raid_subr.c ld_ataraid.c
Log Message:
ataraid(4), ld(4): ensure RAID disk status is set before resolving vnode.
Given a RAID array disk is missing (due to removal,
Should have mentioned in commit message that reviewed by bad and
riastradh. Sorry about that.
On Tue, Mar 11, 2025 at 6:51 PM Andrius Varanavicius wrote:
>
> Module Name:src
> Committed By: andvar
> Date: Tue Mar 11 16:51:31 UTC 2025
>
> Modified Files:
> src/sys/dev/ata:
Module Name:src
Committed By: andvar
Date: Tue Mar 11 16:51:31 UTC 2025
Modified Files:
src/sys/dev/ata: ata_raid_via.c
Log Message:
ataraid(4): obtain VIA V-RAID drive index from configuration blocks.
The original logic resolved disk index based on the drive channel it w
Module Name:src
Committed By: andvar
Date: Tue Mar 11 16:51:31 UTC 2025
Modified Files:
src/sys/dev/ata: ata_raid_via.c
Log Message:
ataraid(4): obtain VIA V-RAID drive index from configuration blocks.
The original logic resolved disk index based on the drive channel it w
Module Name:src
Committed By: jakllsch
Date: Thu Feb 27 01:34:44 UTC 2025
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Ensure dsa_firstaligned returned from DIOCGSECTORALIGN is actually the first
To generate a diff of this commit:
cvs rdiff -u -r1.472 -r1.473 src/s
Module Name:src
Committed By: jakllsch
Date: Thu Feb 27 01:34:44 UTC 2025
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Ensure dsa_firstaligned returned from DIOCGSECTORALIGN is actually the first
To generate a diff of this commit:
cvs rdiff -u -r1.472 -r1.473 src/s
Module Name:src
Committed By: jakllsch
Date: Sun Feb 23 02:07:35 UTC 2025
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
atap_logical_align is already what we want, we don't have to subtract it
from the logical blocks per physical block number.
To generate a diff of
Module Name:src
Committed By: jakllsch
Date: Sun Feb 23 02:07:35 UTC 2025
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
atap_logical_align is already what we want, we don't have to subtract it
from the logical blocks per physical block number.
To generate a diff of
Module Name:src
Committed By: jakllsch
Date: Mon Feb 17 18:45:01 UTC 2025
Modified Files:
src/sys/dev/ata: ata.c wd.c
Log Message:
Fix aprint_error_dev() abuse
To generate a diff of this commit:
cvs rdiff -u -r1.169 -r1.170 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.470 -r1.
Module Name:src
Committed By: jakllsch
Date: Mon Feb 17 18:45:01 UTC 2025
Modified Files:
src/sys/dev/ata: ata.c wd.c
Log Message:
Fix aprint_error_dev() abuse
To generate a diff of this commit:
cvs rdiff -u -r1.169 -r1.170 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.470 -r1.
Module Name:src
Committed By: uwe
Date: Sun Sep 22 17:37:08 UTC 2024
Modified Files:
src/sys/dev/ata: files.ata
Log Message:
files.ata: defparam ATADEBUG_WD_MASK
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/sys/dev/ata/files.ata
Please note that dif
Module Name:src
Committed By: uwe
Date: Sun Sep 22 17:37:08 UTC 2024
Modified Files:
src/sys/dev/ata: files.ata
Log Message:
files.ata: defparam ATADEBUG_WD_MASK
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/sys/dev/ata/files.ata
Please note that dif
Module Name:src
Committed By: uwe
Date: Sun Sep 22 17:31:43 UTC 2024
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
wd.c: consistent whitespace within one #define group
To generate a diff of this commit:
cvs rdiff -u -r1.469 -r1.470 src/sys/dev/ata/wd.c
Please note
Module Name:src
Committed By: uwe
Date: Sun Sep 22 17:31:43 UTC 2024
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
wd.c: consistent whitespace within one #define group
To generate a diff of this commit:
cvs rdiff -u -r1.469 -r1.470 src/sys/dev/ata/wd.c
Please note
Module Name:src
Committed By: riastradh
Date: Mon Jul 17 21:12:19 UTC 2023
Modified Files:
src/sys/dev/ata: files.ata
Log Message:
ata(4): Add ATA_DOWNGRADE_MODE to opt_ata.h.
This way adding it to kernel config will trigger recompilation.
To generate a diff of this com
Module Name:src
Committed By: riastradh
Date: Mon Jul 17 21:12:19 UTC 2023
Modified Files:
src/sys/dev/ata: files.ata
Log Message:
ata(4): Add ATA_DOWNGRADE_MODE to opt_ata.h.
This way adding it to kernel config will trigger recompilation.
To generate a diff of this com
Module Name:src
Committed By: mlelstv
Date: Tue Jan 24 08:34:18 UTC 2023
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Sanitize capacity values.
To generate a diff of this commit:
cvs rdiff -u -r1.467 -r1.468 src/sys/dev/ata/wd.c
Please note that diffs are not publ
Module Name:src
Committed By: mlelstv
Date: Tue Jan 24 08:34:18 UTC 2023
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Sanitize capacity values.
To generate a diff of this commit:
cvs rdiff -u -r1.467 -r1.468 src/sys/dev/ata/wd.c
Please note that diffs are not publ
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:39:37 UTC 2022
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
wd(4): Use d_cfdriver/devtounit to avoid open/detach races.
To generate a diff of this commit:
cvs rdiff -u -r1.466 -r1.467 src/sys/dev/ata/wd.c
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:39:37 UTC 2022
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
wd(4): Use d_cfdriver/devtounit to avoid open/detach races.
To generate a diff of this commit:
cvs rdiff -u -r1.466 -r1.467 src/sys/dev/ata/wd.c
Module Name:src
Committed By: hannken
Date: Sat Mar 19 13:51:01 UTC 2022
Modified Files:
src/sys/dev/ata: ata_raid_adaptec.c ata_raid_intel.c ata_raid_jmicron.c
ata_raid_nvidia.c ata_raid_promise.c ata_raid_subr.c ata_raid_via.c
Log Message:
Lock vnode across V
Module Name:src
Committed By: hannken
Date: Sat Mar 19 13:51:01 UTC 2022
Modified Files:
src/sys/dev/ata: ata_raid_adaptec.c ata_raid_intel.c ata_raid_jmicron.c
ata_raid_nvidia.c ata_raid_promise.c ata_raid_subr.c ata_raid_via.c
Log Message:
Lock vnode across V
Module Name:src
Committed By: perseant
Date: Mon Mar 14 22:15:51 UTC 2022
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Avoid an unaccounted extra channel freeze, if a reset is requested
more than once before the thread services the request. Closes PR#56745.
To ge
Module Name:src
Committed By: perseant
Date: Mon Mar 14 22:15:51 UTC 2022
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Avoid an unaccounted extra channel freeze, if a reset is requested
more than once before the thread services the request. Closes PR#56745.
To ge
Module Name:src
Committed By: riastradh
Date: Tue Dec 28 13:27:32 UTC 2021
Modified Files:
src/sys/dev/ata: wd.c wdvar.h
Log Message:
wd(4): Fix bugs in softbadsect handling.
- Don't copyout kernel virtual addresses (of SLIST entries) that
userland won't use anyway.
=
Module Name:src
Committed By: riastradh
Date: Tue Dec 28 13:27:32 UTC 2021
Modified Files:
src/sys/dev/ata: wd.c wdvar.h
Log Message:
wd(4): Fix bugs in softbadsect handling.
- Don't copyout kernel virtual addresses (of SLIST entries) that
userland won't use anyway.
=
Module Name:src
Committed By: skrll
Date: Fri Nov 12 06:53:49 UTC 2021
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Trailing whitespace
To generate a diff of this commit:
cvs rdiff -u -r1.164 -r1.165 src/sys/dev/ata/ata.c
Please note that diffs are not public dom
Module Name:src
Committed By: skrll
Date: Fri Nov 12 06:53:49 UTC 2021
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Trailing whitespace
To generate a diff of this commit:
cvs rdiff -u -r1.164 -r1.165 src/sys/dev/ata/ata.c
Please note that diffs are not public dom
Module Name:src
Committed By: rin
Date: Sun Aug 29 23:49:32 UTC 2021
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Output missing '\n' for capability list when DMA support is not compiled in.
To generate a diff of this commit:
cvs rdiff -u -r1.162 -r1.163 src/sys/d
Module Name:src
Committed By: rin
Date: Sun Aug 29 23:49:32 UTC 2021
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Output missing '\n' for capability list when DMA support is not compiled in.
To generate a diff of this commit:
cvs rdiff -u -r1.162 -r1.163 src/sys/d
On Sat, 2 May 2020, 20:10 Jason Thorpe, wrote:
>
> > On May 1, 2020, at 1:07 PM, Ryo ONODERA wrote:
> >
> > Hi,
> >
> > Have you missed this thread?
> >
> > If the problem requires more time to investigate,
> > could you consider to revert ata change for a while?
> >
> > Thank you.
>
> I backed
> On May 1, 2020, at 1:07 PM, Ryo ONODERA wrote:
>
> Hi,
>
> Have you missed this thread?
>
> If the problem requires more time to investigate,
> could you consider to revert ata change for a while?
>
> Thank you.
I backed it out, but would appreciate some help tracking down the issue becau
Hi,
Have you missed this thread?
If the problem requires more time to investigate,
could you consider to revert ata change for a while?
Thank you.
Alexander Nasonov writes:
> David Brownlee wrote:
>> Just another data point - seeing this same panic on a T480 with the
>> latest kernel from nyf
Plus to confirm reverting just this commit from today's github copy of
current (d5b32e03eac8b05d38a143ee0ec615efb2233201) boots fine on the
T480
Thanks
On Thu, 30 Apr 2020 at 00:12, Alexander Nasonov wrote:
>
> David Brownlee wrote:
> > Just another data point - seeing this same panic on a T480
David Brownlee wrote:
> Just another data point - seeing this same panic on a T480 with the
> latest kernel from nyftp
Same problem on T470.
--
Alex
Just another data point - seeing this same panic on a T480 with the
latest kernel from nyftp
Ryo ONODERA writes:
> Hi,
>
> After this commit, NetBSD/amd64-current on my HP Spectre x360
> freezes after acpiacad0 detection (before ld0 detection).
> Reverting this commit in latest tree fixes my freeze problem.
>
> Could you take a look at my problem?
>
> Thank you.
>
> === === ===
> cpu7: C
Hi,
After this commit, NetBSD/amd64-current on my HP Spectre x360
freezes after acpiacad0 detection (before ld0 detection).
Reverting this commit in latest tree fixes my freeze problem.
Could you take a look at my problem?
Thank you.
=== === ===
cpu7: CPU max freq 40 Hz
cpu7: TSC freq 1
Module Name:src
Committed By: christos
Date: Mon Oct 21 18:58:57 UTC 2019
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
chuq does not like insomniac allocations so unlock-alloc-lock instead.
To generate a diff of this commit:
cvs rdiff -u -r1.152 -r1.153 src/sys/de
Module Name:src
Committed By: christos
Date: Mon Oct 21 18:58:57 UTC 2019
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
chuq does not like insomniac allocations so unlock-alloc-lock instead.
To generate a diff of this commit:
cvs rdiff -u -r1.152 -r1.153 src/sys/de
Module Name:src
Committed By: christos
Date: Mon Oct 21 18:37:47 UTC 2019
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Fix assert_sleepable() panic by allocating with NOSLEEP. The alternative is
to unlock and relock the channel, but seems more dangerous to do so.
Module Name:src
Committed By: christos
Date: Mon Oct 21 18:37:47 UTC 2019
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Fix assert_sleepable() panic by allocating with NOSLEEP. The alternative is
to unlock and relock the channel, but seems more dangerous to do so.
Module Name:src
Committed By: mrg
Date: Fri Oct 4 12:24:32 UTC 2019
Modified Files:
src/sys/dev/ata: ata_raid_intel.c
Log Message:
use memmove() not memcpy() for overlapping regions.
To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/ata/ata_raid_i
Module Name:src
Committed By: mrg
Date: Fri Oct 4 12:24:32 UTC 2019
Modified Files:
src/sys/dev/ata: ata_raid_intel.c
Log Message:
use memmove() not memcpy() for overlapping regions.
To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/ata/ata_raid_i
Module Name:src
Committed By: gson
Date: Thu Aug 15 09:00:23 UTC 2019
Modified Files:
src/sys/dev/ata: satafis_subr.c
Log Message:
Set the ATAPI "BYTE COUNT LIMIT" field in the SATA case like we
already do in the ATA case, to make NetBSD work with the virtual
SATA CD-ROM o
Module Name:src
Committed By: gson
Date: Thu Aug 15 09:00:23 UTC 2019
Modified Files:
src/sys/dev/ata: satafis_subr.c
Log Message:
Set the ATAPI "BYTE COUNT LIMIT" field in the SATA case like we
already do in the ATA case, to make NetBSD work with the virtual
SATA CD-ROM o
Module Name:src
Committed By: mlelstv
Date: Thu Jun 6 20:55:43 UTC 2019
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Take channel lock for calling reset_drive.
Should fix PR 54217.
To generate a diff of this commit:
cvs rdiff -u -r1.451 -r1.452 src/sys/dev/ata/wd.
Module Name:src
Committed By: mlelstv
Date: Thu Jun 6 20:55:43 UTC 2019
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Take channel lock for calling reset_drive.
Should fix PR 54217.
To generate a diff of this commit:
cvs rdiff -u -r1.451 -r1.452 src/sys/dev/ata/wd.
Module Name:src
Committed By: mlelstv
Date: Thu Jun 6 20:41:04 UTC 2019
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Count only the initial start of a transfer, not the retries.
Should fix kern/54166.
Thanks to macallan@ for spotting the issue.
To generate a diff
Module Name:src
Committed By: mlelstv
Date: Thu Jun 6 20:41:04 UTC 2019
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Count only the initial start of a transfer, not the retries.
Should fix kern/54166.
Thanks to macallan@ for spotting the issue.
To generate a diff
Module Name:src
Committed By: christos
Date: Sat May 25 16:30:18 UTC 2019
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
use PR_ZERO
To generate a diff of this commit:
cvs rdiff -u -r1.148 -r1.149 src/sys/dev/ata/ata.c
Please note that diffs are not public domain;
Module Name:src
Committed By: christos
Date: Sat May 25 16:30:18 UTC 2019
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
use PR_ZERO
To generate a diff of this commit:
cvs rdiff -u -r1.148 -r1.149 src/sys/dev/ata/ata.c
Please note that diffs are not public domain;
Module Name:src
Committed By: mlelstv
Date: Fri May 24 06:01:06 UTC 2019
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Also schedule timeouts when all openings are in use.
To generate a diff of this commit:
cvs rdiff -u -r1.449 -r1.450 src/sys/dev/ata/wd.c
Please n
Module Name:src
Committed By: mlelstv
Date: Fri May 24 06:01:06 UTC 2019
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Also schedule timeouts when all openings are in use.
To generate a diff of this commit:
cvs rdiff -u -r1.449 -r1.450 src/sys/dev/ata/wd.c
Please n
On Fri, 25 Jul 2014, David A. Holland wrote:
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
Drop the old discard/trim ioctls from wd.c.
- case DIOCGDISCARDPARAMS: {
- case DIOCDISCARD: {
These never appeared in a release, so I suppose there's no need to
implement the
On Oct 16, 2011, at 9:25 PM, John Nemeth wrote:
> On Feb 25, 1:28pm, Wolfgang Solfrank wrote:
> } Jonathan A. Kollasch schrieb:
> } > On Wed, Oct 05, 2011 at 10:25:52AM +0200, Manuel Bouyer wrote:
> } >> On Wed, Oct 05, 2011 at 03:40:18AM +, Jonathan A. Kollasch wrote:
> } >>> Module Name:
On Feb 25, 1:28pm, Wolfgang Solfrank wrote:
} Jonathan A. Kollasch schrieb:
} > On Wed, Oct 05, 2011 at 10:25:52AM +0200, Manuel Bouyer wrote:
} >> On Wed, Oct 05, 2011 at 03:40:18AM +, Jonathan A. Kollasch wrote:
} >>> Module Name: src
} >>> Committed By: jakllsch
} >>> Date:
On Wed, Oct 05, 2011 at 06:52:37PM +0200, Wolfgang Solfrank wrote:
> ... You would tell the controller the cylinder/head/sector
> of the first sector you wanted to read, and when multiple sectors were
> requested, the controller would increment only the sector number.
> Since the controller wouldn
Hi,
Jonathan A. Kollasch schrieb:
On Wed, Oct 05, 2011 at 10:25:52AM +0200, Manuel Bouyer wrote:
On Wed, Oct 05, 2011 at 03:40:18AM +, Jonathan A. Kollasch wrote:
Module Name:src
Committed By: jakllsch
Date: Wed Oct 5 03:40:18 UTC 2011
Modified Files:
src/sys/dev/
On Wed, Oct 05, 2011 at 10:25:52AM +0200, Manuel Bouyer wrote:
> On Wed, Oct 05, 2011 at 03:40:18AM +, Jonathan A. Kollasch wrote:
> > Module Name:src
> > Committed By: jakllsch
> > Date: Wed Oct 5 03:40:18 UTC 2011
> >
> > Modified Files:
> > src/sys/dev/ata:
On Wed, Oct 05, 2011 at 03:40:18AM +, Jonathan A. Kollasch wrote:
> Module Name: src
> Committed By: jakllsch
> Date: Wed Oct 5 03:40:18 UTC 2011
>
> Modified Files:
> src/sys/dev/ata: wd.c
>
> Log Message:
> Limit wd(4) transfers to 128 (512-byte) logical sectors, as the trad
On Thu, 5 May 2011, Jonathan A. Kollasch wrote:
Hmmm, not sure this is working:
{135} ident /netbsd | grep ' ata.c'
$NetBSD: ata.c,v 1.115 2011/04/30 00:34:03 jakllsch Exp $
{136} drvctl -r atabus2
drvctl: DRVRESCANBUS: Invalid argument
{137} dmesg | grep atabus3
atabus3 at ahcisata0 chann
On Thu, May 05, 2011 at 07:42:35AM -0700, Paul Goyette wrote:
> >Module Name:src
> >Committed By: jakllsch
> >Date: Sat Apr 30 00:34:03 UTC 2011
> >
> >Modified Files:
> >src/sys/dev/ata: ata.c atavar.h
> >
> >Log Message:
> >Add simplistic atabus(4) rescan support.
>
>
>
Module Name:src
Committed By: jakllsch
Date: Sat Apr 30 00:34:03 UTC 2011
Modified Files:
src/sys/dev/ata: ata.c atavar.h
Log Message:
Add simplistic atabus(4) rescan support.
Hmmm, not sure this is working:
{135} ident /netbsd | grep ' ata.c'
$NetBSD: ata.c,v 1.
Module Name:src
Committed By: jakllsch
Date: Mon Jan 25 00:39:52 UTC 2010
Modified Files:
src/sys/dev/ata: atareg.h
Log Message:
Add some more elements to struct ataparams.
These mostly concern the new Long Physical Sectors
and Long Logical Sectors feature sets.
Informat
Module Name:src
Committed By: bouyer
Date: Sat Jan 23 18:54:53 UTC 2010
Modified Files:
src/sys/dev/ata: wd.c
Log Message:
struct buf::b_iodone is not called at splbio() any more.
Make sure non-MPsafe iodone callbacks raise the SPL as appropriate.
To generate a diff of t
Module Name:src
Committed By: jakllsch
Date: Fri Jan 22 01:22:01 UTC 2010
Modified Files:
src/sys/dev/ata: atareg.h
Log Message:
Correct an error in previous commit.
To generate a diff of this commit:
cvs rdiff -u -r1.36 -r1.37 src/sys/dev/ata/atareg.h
Please note that
Module Name:src
Committed By: jakllsch
Date: Thu Jan 21 23:26:58 UTC 2010
Modified Files:
src/sys/dev/ata: atareg.h
Log Message:
Convert to C99 types. Make whitespace more consistent.
To generate a diff of this commit:
cvs rdiff -u -r1.35 -r1.36 src/sys/dev/ata/atareg.h
Module Name:src
Committed By: dyoung
Date: Thu Jan 21 02:53:51 UTC 2010
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Cosmetic: join some lines. Get out early on errors, change
switch (...) {
...
error = ...;
Module Name:src
Committed By: tsutsui
Date: Sun Jan 10 16:04:25 UTC 2010
Modified Files:
src/sys/dev/ata: atareg.h
Log Message:
Provide atacmd_to48() in case of #if defined(_STANDALONE) too
because standalone wdc driver in cobalt bootloader requires it
for LBA48 support.
Module Name:src
Committed By: dyoung
Date: Fri Jan 8 19:48:12 UTC 2010
Modified Files:
src/sys/dev/ata: ata.c wd.c
Log Message:
Expand PMF_FN_* macros.
To generate a diff of this commit:
cvs rdiff -u -r1.109 -r1.110 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.380 -r1.381 src
73 matches
Mail list logo
