Module Name:src
Committed By: riastradh
Date: Thu Nov 21 19:46:29 UTC 2024
Added Files:
src/lib/libcrypt: crypt.expsym
Log Message:
libcrypt: Add expected symbols list.
PR lib/58838: shared libraries in base should all have expsym lists
To generate a diff of this commit
Module Name:src
Committed By: riastradh
Date: Thu Nov 21 19:46:29 UTC 2024
Added Files:
src/lib/libcrypt: crypt.expsym
Log Message:
libcrypt: Add expected symbols list.
PR lib/58838: shared libraries in base should all have expsym lists
To generate a diff of this commit
Module Name:src
Committed By: riastradh
Date: Tue Jul 23 22:37:11 UTC 2024
Modified Files:
src/lib/libcrypt: crypt-argon2.c crypt-sha1.c crypt.c hmac.c md5crypt.c
pw_gensalt.c
Log Message:
libcrypt: Nix trailing whitespace.
No functional change intended.
Prom
Module Name:src
Committed By: riastradh
Date: Tue Jul 23 22:37:11 UTC 2024
Modified Files:
src/lib/libcrypt: crypt-argon2.c crypt-sha1.c crypt.c hmac.c md5crypt.c
pw_gensalt.c
Log Message:
libcrypt: Nix trailing whitespace.
No functional change intended.
Prom
Module Name:src
Committed By: riastradh
Date: Tue Jul 23 22:32:22 UTC 2024
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
libcrypt/crypt-argon2.c: Add RCS id.
Noted in PR lib/57895.
To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/lib/lib
Module Name:src
Committed By: riastradh
Date: Tue Jul 23 22:32:22 UTC 2024
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
libcrypt/crypt-argon2.c: Add RCS id.
Noted in PR lib/57895.
To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/lib/lib
Module Name:src
Committed By: mlelstv
Date: Sat Mar 9 13:48:50 UTC 2024
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Don't use uninitialized variable.
Fixes PR 57895.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/lib/libcrypt/crypt-a
Module Name:src
Committed By: mlelstv
Date: Sat Mar 9 13:48:50 UTC 2024
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Don't use uninitialized variable.
Fixes PR 57895.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/lib/libcrypt/crypt-a
Module Name:src
Committed By: mrg
Date: Mon Sep 4 23:00:48 UTC 2023
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
apply ${CC_WNO_STRINGOP_OVERFLOW} for crypt.c.
init_perm() takes a larger array than IE3264[] is, but it doesn't use more
for this instance.
To g
Module Name:src
Committed By: mrg
Date: Mon Sep 4 23:00:48 UTC 2023
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
apply ${CC_WNO_STRINGOP_OVERFLOW} for crypt.c.
init_perm() takes a larger array than IE3264[] is, but it doesn't use more
for this instance.
To g
Module Name:src
Committed By: rin
Date: Mon Aug 14 02:22:35 UTC 2023
Modified Files:
src/lib/libcrypt: crypt.c
Log Message:
libcrypt: trailing white space
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 src/lib/libcrypt/crypt.c
Please note that diffs are n
Module Name:src
Committed By: rin
Date: Mon Aug 14 02:22:35 UTC 2023
Modified Files:
src/lib/libcrypt: crypt.c
Log Message:
libcrypt: trailing white space
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 src/lib/libcrypt/crypt.c
Please note that diffs are n
Module Name:src
Committed By: uwe
Date: Tue Jan 17 14:27:11 UTC 2023
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt(3): Minor markup tweaks
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/lib/libcrypt/crypt.3
Please note that diffs are no
Module Name:src
Committed By: uwe
Date: Tue Jan 17 14:27:11 UTC 2023
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt(3): Minor markup tweaks
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/lib/libcrypt/crypt.3
Please note that diffs are no
Module Name:src
Committed By: riastradh
Date: Tue Jan 17 01:56:43 UTC 2023
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt(3): Call it password hashing, not `encrypting'.
Tidy up some of the markup while here, and be consistent about
calling the neatly format
Module Name:src
Committed By: riastradh
Date: Tue Jan 17 01:56:43 UTC 2023
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt(3): Call it password hashing, not `encrypting'.
Tidy up some of the markup while here, and be consistent about
calling the neatly format
Module Name:src
Committed By: martin
Date: Sun May 29 12:15:00 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Make it compile again
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/lib/libcrypt/crypt-argon2.c
Please note that dif
Module Name:src
Committed By: martin
Date: Sun May 29 12:15:00 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Make it compile again
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/lib/libcrypt/crypt-argon2.c
Please note that dif
Module Name:src
Committed By: abs
Date: Sun May 29 10:58:09 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Avoid null SEGV if libargon passed string with too few $
Seen on netbsd-9 built xscreensaver running on a current system.
Whatever triggered
Module Name:src
Committed By: abs
Date: Sun May 29 10:58:09 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Avoid null SEGV if libargon passed string with too few $
Seen on netbsd-9 built xscreensaver running on a current system.
Whatever triggered
Module Name:src
Committed By: abs
Date: Sun May 29 10:51:41 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Free strdup'd value in libargon decode_option error paths
If its worth freeing in the success path, its worth freeing in the
error path... (g
Module Name:src
Committed By: abs
Date: Sun May 29 10:51:41 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Free strdup'd value in libargon decode_option error paths
If its worth freeing in the success path, its worth freeing in the
error path... (g
Module Name:src
Committed By: christos
Date: Sun May 15 16:25:09 UTC 2022
Modified Files:
src/lib/libcrypt: Makefile
Added Files:
src/lib/libcrypt: namespace.h
Log Message:
PR/56838: David A. Holland: namespace pollution in static libcrypt
To generate a diff of t
Module Name:src
Committed By: christos
Date: Sun May 15 16:25:09 UTC 2022
Modified Files:
src/lib/libcrypt: Makefile
Added Files:
src/lib/libcrypt: namespace.h
Log Message:
PR/56838: David A. Holland: namespace pollution in static libcrypt
To generate a diff of t
Module Name:src
Committed By: christos
Date: Sun Feb 13 13:32:03 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
remove dup assignments (RVP)
To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/lib/libcrypt/crypt-argon2.c
Please note
Module Name:src
Committed By: christos
Date: Sun Feb 13 13:32:03 UTC 2022
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
remove dup assignments (RVP)
To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/lib/libcrypt/crypt-argon2.c
Please note
Module Name:src
Committed By: nia
Date: Mon Nov 22 14:30:25 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): document some of the memory units we're dealing with
To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/lib/libcryp
Module Name:src
Committed By: nia
Date: Mon Nov 22 14:30:25 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): document some of the memory units we're dealing with
To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/lib/libcryp
Module Name:src
Committed By: nia
Date: Sun Oct 31 09:16:08 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: Compile with USE_FORT, for this is cryptographic software.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/lib/libcryp
Module Name:src
Committed By: nia
Date: Sun Oct 31 09:16:08 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: Compile with USE_FORT, for this is cryptographic software.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/lib/libcryp
Module Name:src
Committed By: nia
Date: Fri Oct 29 13:22:08 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-sha1.c
Log Message:
libcrypt: Fix a floating point exception when a low number of HMAC-SHA1
iterations are specified.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: nia
Date: Fri Oct 29 13:22:08 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-sha1.c
Log Message:
libcrypt: Fix a floating point exception when a low number of HMAC-SHA1
iterations are specified.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: nia
Date: Tue Oct 26 20:37:18 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: Make Werror-disables for external Argon2 library per-file.
Requested by rin.
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1
Module Name:src
Committed By: nia
Date: Tue Oct 26 20:37:18 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: Make Werror-disables for external Argon2 library per-file.
Requested by rin.
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1
Module Name:src
Committed By: nia
Date: Tue Oct 26 07:51:23 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: fine-grained warnings for argon2, requested by rin
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/lib/libcrypt/Makefi
Module Name:src
Committed By: nia
Date: Tue Oct 26 07:51:23 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: fine-grained warnings for argon2, requested by rin
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/lib/libcrypt/Makefi
Module Name:src
Committed By: nia
Date: Wed Oct 20 20:29:33 UTC 2021
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt.3: add a reference for Argon2
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/lib/libcrypt/crypt.3
Please note that diffs
Module Name:src
Committed By: nia
Date: Wed Oct 20 20:29:33 UTC 2021
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt.3: add a reference for Argon2
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/lib/libcrypt/crypt.3
Please note that diffs
Module Name:src
Committed By: nia
Date: Wed Oct 20 20:21:44 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Be a little bit more eager to let Argon2 use memory.
To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/lib/libcrypt/crypt-ar
Module Name:src
Committed By: nia
Date: Wed Oct 20 20:21:44 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
Be a little bit more eager to let Argon2 use memory.
To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/lib/libcrypt/crypt-ar
Module Name:src
Committed By: nia
Date: Wed Oct 20 16:46:34 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): For argon2, default to time=3.
Good enough for a 50MHz SPARC, a shark, and the spec.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: nia
Date: Wed Oct 20 16:46:34 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): For argon2, default to time=3.
Good enough for a 50MHz SPARC, a shark, and the spec.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: nia
Date: Wed Oct 20 15:35:42 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): return 0 -> return NULL for function returning char *
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/lib/libcry
Module Name:src
Committed By: nia
Date: Wed Oct 20 15:35:42 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): return 0 -> return NULL for function returning char *
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/lib/libcry
Module Name:src
Committed By: nia
Date: Wed Oct 20 13:03:29 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c pw_gensalt.c
Log Message:
crypt(3): Adapt default Argon2 parameters to system performance
If the parameters are unspecified:
- Set the default memory con
Module Name:src
Committed By: nia
Date: Wed Oct 20 13:03:29 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c pw_gensalt.c
Log Message:
crypt(3): Adapt default Argon2 parameters to system performance
If the parameters are unspecified:
- Set the default memory con
Module Name:src
Committed By: nia
Date: Sat Oct 16 10:53:34 UTC 2021
Modified Files:
src/lib/libcrypt: bcrypt.c crypt-argon2.c crypt-sha1.c crypt.h hmac.c
md5crypt.c pw_gensalt.c
Log Message:
libcrypt: Hide more private symbols by default. Fix style.
To gener
Module Name:src
Committed By: nia
Date: Sat Oct 16 10:53:34 UTC 2021
Modified Files:
src/lib/libcrypt: bcrypt.c crypt-argon2.c crypt-sha1.c crypt.h hmac.c
md5crypt.c pw_gensalt.c
Log Message:
libcrypt: Hide more private symbols by default. Fix style.
To gener
Module Name:src
Committed By: nia
Date: Wed Oct 13 14:28:32 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: work around compiler bugs to get MKARGON2 working on vax
To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/lib/libcrypt/
Module Name:src
Committed By: nia
Date: Wed Oct 13 14:28:32 UTC 2021
Modified Files:
src/lib/libcrypt: Makefile
Log Message:
libcrypt: work around compiler bugs to get MKARGON2 working on vax
To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/lib/libcrypt/
Module Name:src
Committed By: wiz
Date: Tue Oct 12 21:41:13 UTC 2021
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
Capitalize word.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/lib/libcrypt/crypt.3
Please note that diffs are not public doma
Module Name:src
Committed By: wiz
Date: Tue Oct 12 21:41:13 UTC 2021
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
Capitalize word.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/lib/libcrypt/crypt.3
Please note that diffs are not public doma
Module Name:src
Committed By: nia
Date: Tue Oct 12 17:27:26 UTC 2021
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt.3: note parallelism caveats
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/lib/libcrypt/crypt.3
Please note that diffs ar
Module Name:src
Committed By: nia
Date: Tue Oct 12 17:27:26 UTC 2021
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
crypt.3: note parallelism caveats
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/lib/libcrypt/crypt.3
Please note that diffs ar
Module Name:src
Committed By: jhigh
Date: Tue Oct 12 15:55:31 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
added missing copyright header. pointed out by nia. no functional change
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/l
Module Name:src
Committed By: jhigh
Date: Tue Oct 12 15:55:31 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
added missing copyright header. pointed out by nia. no functional change
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/l
Module Name:src
Committed By: nia
Date: Tue Oct 12 15:27:41 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): clean up some leftover debug goo
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/lib/libcrypt/crypt-argon2.c
Plea
Module Name:src
Committed By: nia
Date: Tue Oct 12 15:27:41 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt(3): clean up some leftover debug goo
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/lib/libcrypt/crypt-argon2.c
Plea
Module Name:src
Committed By: nia
Date: Tue Oct 12 15:25:39 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c crypt.h pw_gensalt.c util.c
Log Message:
crypt(3): match the Argon2 reference implementation's Base64 exactly
There are too many minor variations regardin
Module Name:src
Committed By: nia
Date: Tue Oct 12 15:25:39 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c crypt.h pw_gensalt.c util.c
Log Message:
crypt(3): match the Argon2 reference implementation's Base64 exactly
There are too many minor variations regardin
Module Name:src
Committed By: nia
Date: Tue Oct 12 12:11:04 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
paranoia: use explicit_memset
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/lib/libcrypt/crypt-argon2.c
Please note that
Module Name:src
Committed By: nia
Date: Tue Oct 12 12:11:04 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
paranoia: use explicit_memset
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/lib/libcrypt/crypt-argon2.c
Please note that
Module Name:src
Committed By: nia
Date: Tue Oct 12 12:03:47 UTC 2021
Modified Files:
src/lib/libcrypt: pw_gensalt.3
Log Message:
pw_gensalt.3: add argon2 bits
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/lib/libcrypt/pw_gensalt.3
Please note that diff
Module Name:src
Committed By: nia
Date: Tue Oct 12 12:03:47 UTC 2021
Modified Files:
src/lib/libcrypt: pw_gensalt.3
Log Message:
pw_gensalt.3: add argon2 bits
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/lib/libcrypt/pw_gensalt.3
Please note that diff
Module Name:src
Committed By: nia
Date: Tue Oct 12 10:51:33 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt-argon2: Properly honor user's version number.
Follow upstream by defaulting to 0x10 if it's not specified.
To generate a diff of this
Module Name:src
Committed By: nia
Date: Tue Oct 12 10:51:33 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt-argon2: Properly honor user's version number.
Follow upstream by defaulting to 0x10 if it's not specified.
To generate a diff of this
Module Name:src
Committed By: nia
Date: Tue Oct 12 09:40:39 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt-argon2: improve resilience of the parser.
Allow the version number to be unspecified as in the argon2 upstream
test suite, properly def
Module Name:src
Committed By: nia
Date: Tue Oct 12 09:40:39 UTC 2021
Modified Files:
src/lib/libcrypt: crypt-argon2.c
Log Message:
crypt-argon2: improve resilience of the parser.
Allow the version number to be unspecified as in the argon2 upstream
test suite, properly def
Module Name:src
Committed By: wiz
Date: Mon Oct 21 05:16:51 UTC 2019
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
Mark up argon2 description. Restore removed lines/text from previous
commit.
To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/lib/
Module Name:src
Committed By: wiz
Date: Mon Oct 21 05:16:51 UTC 2019
Modified Files:
src/lib/libcrypt: crypt.3
Log Message:
Mark up argon2 description. Restore removed lines/text from previous
commit.
To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/lib/
On Thu, Dec 01, 2011 at 05:45:25PM +, David Laight wrote:
> On Tue, Nov 29, 2011 at 09:23:20PM +0100, Joerg Sonnenberger wrote:
> > On Tue, Nov 29, 2011 at 09:09:38PM +0100, Matthias Drochner wrote:
> > > Anyway, here is a first cut on an "explicit_bzero" function
> > > which doesn't get optimi
On Thu, Dec 01, 2011 at 05:45:25PM +, David Laight wrote:
> > > Anyway, here is a first cut on an "explicit_bzero" function
> > > which doesn't get optimized away. I've put it to src/common
> > > because the same thing makes sense in the kernel too.
> > > Comments?
> >
> > Just make it a
On Tue, Nov 29, 2011 at 09:23:20PM +0100, Joerg Sonnenberger wrote:
> On Tue, Nov 29, 2011 at 09:09:38PM +0100, Matthias Drochner wrote:
> > Anyway, here is a first cut on an "explicit_bzero" function
> > which doesn't get optimized away. I've put it to src/common
> > because the same thing makes s
On Tue, Nov 29, 2011 at 09:09:38PM +0100, Matthias Drochner wrote:
> Anyway, here is a first cut on an "explicit_bzero" function
> which doesn't get optimized away. I've put it to src/common
> because the same thing makes sense in the kernel too.
> Comments?
Just make it an alias on memset. That's
dholland-sourcechan...@netbsd.org said:
> You also want to take steps to make sure that the zeroed cache line is
> flushed out.
This would be good, but it is a bit hard on x86 from userland
because wbinv is a privileged instruction. Would need a system
call.
Anyway, here is a first cut on an "exp
m.droch...@fz-juelich.de said:
> a disassembly of MD5Final() on i386 shows that the final zeroing is
> present in the binary
OK, this is no surprise. At this point the compiler can't know that
it is a dead store.
best regards
Matthias
--
On Tue, Nov 29, 2011 at 07:14:38PM +0100, Matthias Drochner wrote:
> > the memset() is likely to get optimized away by the compiler anyway.
> > It's a dead store after all.
>
> It might be by luck, but a disassembly of MD5Final() on i386
> shows that the final zeroing is present in the binary
jo...@britannica.bec.de said:
> the memset() is likely to get optimized away by the compiler anyway.
> It's a dead store after all.
It might be by luck, but a disassembly of MD5Final() on i386
shows that the final zeroing is present in the binary.
Generally I agree that we should make this kind o
On Tue, Nov 29, 2011 at 06:40:17PM +0100, Matthias Drochner wrote:
>
> jo...@britannica.bec.de said:
> > Well, the way it is done, it won't help.
>
> What do you mean - a duplication of efforts?
No, just that the memset() is likely to get optimized away by the
compiler anyway. It's a dead store
jo...@britannica.bec.de said:
> Well, the way it is done, it won't help.
What do you mean - a duplication of efforts?
Just noticed this myself... I'm not sure it is a good idea to
do this in MD5Final because it might be unnecessary if the
hash is just used for indexing or so. In addition, this is
On Tue, Nov 29, 2011 at 01:18:52PM +, Matthias Drochner wrote:
> Module Name: src
> Committed By: drochner
> Date: Tue Nov 29 13:18:52 UTC 2011
>
> Modified Files:
> src/lib/libcrypt: md5crypt.c
>
> Log Message:
> zero out hash context after use, to avoid traces in RAM
> (hint
81 matches
Mail list logo
