Re: CVS commit: src/sys/dev/usb

2025-04-06 Thread Hans Rosenfeld
Hi, On Tue, Mar 25, 2025 at 08:28:10PM +, Taylor R Campbell wrote: > Thanks for taking a look at this! This change is not quite enough, > though. There are two issues: > > 1. `#ifdef DIAGNOSTIC printf(...)' is almost always wrong. Generally, >either: > >(a) the condition should be

Re: CVS commit: src/lib/librumpuser

2025-04-06 Thread Martin Husemann
On Sun, Apr 06, 2025 at 03:27:23AM +, Taylor R Campbell wrote: > FYI, this was not an accidental local change; I deliberately committed > this so that it would run on the releng testbed because I was unable > to reproduce the problem locally. But it broke the build, so the testbed could not ru