Re: CVS commit: src/sys/dev/pci

2018-11-30 Thread Nick Hudson
On 30/11/2018 17:47, Jaromir Dolecek wrote: Module Name:src Committed By: jdolecek Date: Fri Nov 30 17:47:54 UTC 2018 Modified Files: src/sys/dev/pci: ahcisata_pci.c xhci_pci.c Log Message: simplify intr establish code - rely on pci_intr_alloc() to allow also MSI-X, and

Re: CVS commit: src/sys

2018-11-30 Thread Valery Ushakov
On Fri, Nov 30, 2018 at 13:59:11 +0100, Martin Husemann wrote: > On Fri, Nov 30, 2018 at 07:47:38AM -0500, Christos Zoulas wrote: > > We need to see if the spec says so. I am not sure if we can depend > > that an implementation does it. > > The spec only talks about members not named in the list

Re: CVS commit: src/sys

2018-11-30 Thread Martin Husemann
On Fri, Nov 30, 2018 at 07:47:38AM -0500, Christos Zoulas wrote: > We need to see if the spec says so. I am not sure if we can depend > that an implementation does it. The spec only talks about members not named in the list - I can't see any hints about padding. Might be worth to ask some std gu

Re: CVS commit: src/sys

2018-11-30 Thread Christos Zoulas
On Nov 30, 9:09am, mar...@duskware.de (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/sys | On Thu, Nov 29, 2018 at 10:07:11PM +, Christos Zoulas wrote: | > >The pool is just called three times, so it's not a big deal. | > | > I don't know, from reading the manual page using the poo

Re: CVS commit: src/sys

2018-11-30 Thread Martin Husemann
On Thu, Nov 29, 2018 at 10:07:11PM +, Christos Zoulas wrote: > >The pool is just called three times, so it's not a big deal. > > I don't know, from reading the manual page using the pool_cache_ api seems > to be the preferred way... Plus I don't think that a language deficiency > should be vis