Re: CVS commit: src/sys/fs/sysvbfs

2015-01-02 Thread Christos Zoulas
In article <20150102165102.d42c...@cvs.netbsd.org>, Juergen Hannken-Illjes wrote: > >@@ -336,6 +336,7 @@ sysvbfs_loadvnode(struct mount *mp, stru > } > > bnode = pool_get(&sysvbfs_node_pool, PR_WAITOK); >+ memset(bnode, 0, sizeof(*bnode)); Why don't we have PR_ZERO? christos

re: CVS commit: src/sys

2015-01-02 Thread Christos Zoulas
On Jan 3, 7:52am, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/sys | this seems strange to me. | | we have a published userland interface and you chose that | one to change? so userland apps must be fixed. it seems | much saner to me to fix the other in-kernel user

re: CVS commit: src/sys

2015-01-02 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Fri Jan 2 19:42:07 UTC 2015 > > Modified Files: [ ... ] > > Log Message: > We have three sets of DTYPE_ constants in the kernel: > altqDropType > disklabel Disk

Re: CVS commit: src

2015-01-02 Thread Alan Barrett
On Fri, 02 Jan 2015, Christos Zoulas wrote: Log Message: Implement DIOCGMEDIASIZE and DIOCGSECTORSIZE from FreeBSD. This needs compat32 handling, at least for the u_int arg to DIOCGSECTORSIZE. Why not make it a fixed size, like uint32_t, so compat32 handling will not be needed? I think it wa

Re: CVS commit: src

2015-01-02 Thread Christos Zoulas
In article <20150102092310.gp2...@apb-laptoy.apb.alt.za>, Alan Barrett wrote: >On Mon, 29 Dec 2014, Michael van Elst wrote: >>Log Message: >>Implement DIOCGMEDIASIZE and DIOCGSECTORSIZE from FreeBSD. > >This needs compat32 handling, at least for the u_int arg to >DIOCGSECTORSIZE. > >Why not make

Re: CVS commit: [netbsd-7] src/sys/dev

2015-01-02 Thread Jonathan A. Kollasch
On Fri, Jan 02, 2015 at 08:09:51AM +, John Klos wrote: > Module Name: src > Committed By: jklos > Date: Fri Jan 2 08:09:51 UTC 2015 > > Modified Files: > src/sys/dev/dec [netbsd-7]: dzkbd.c lk201_ws.c lk201var.h > src/sys/dev/tc [netbsd-7]: zskbd.c > > Log Message: > Pat

Re: CVS commit: src

2015-01-02 Thread Alan Barrett
On Mon, 29 Dec 2014, Michael van Elst wrote: Log Message: Implement DIOCGMEDIASIZE and DIOCGSECTORSIZE from FreeBSD. This needs compat32 handling, at least for the u_int arg to DIOCGSECTORSIZE. Why not make it a fixed size, like uint32_t, so compat32 handling will not be needed? --apb (Alan B