Re: CVS commit: src/sys/external/bsd/drm/dist/shared-core

2014-09-06 Thread Matt Thomas
On Sep 6, 2014, at 12:28 PM, Cherry G. Mathew wrote: > Hi Matt, > > This doesn't fix drm2 i915 breakage. Could you revisit this please, since > it's in external/ ? > > Thanks, > If I revert, it still won't build. So no. i915 shouldn't be using enum pipe since it conflicts with struct pipe

Re: CVS commit: src/common/lib/libprop

2014-09-06 Thread David Holland
On Fri, Sep 05, 2014 at 05:19:25AM +, Matt Thomas wrote: > Modified Files: > src/common/lib/libprop: prop_ingest.c prop_number.c > > Log Message: > Eliminate use of C++ keywords and don't nest struct definitions. Why do we care if proppropliblib compiles in a C++ compiler? It is C c

Re: CVS commit: src/sys/dev

2014-09-06 Thread Martin Husemann
On Sat, Sep 06, 2014 at 11:42:14AM -0700, Paul Goyette wrote: > >+i = year / 100; > >+days += i * DAYS100YEARS; > >+year -= i * 100; > > Shouldn't this one be > > days -= i * DAYS100YEARS; > > ? We are converting years to days, starting days wit

Re: CVS commit: src/sys/dev

2014-09-06 Thread Paul Goyette
+ i = year / 100; + days += i * DAYS100YEARS; + year -= i * 100; Shouldn't this one be days -= i * DAYS100YEARS; ? On Sat, 6 Sep 2014, Martin Husemann wrote: Module Name:src Committed By: martin Date: Sat Sep 6 18: