Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Valery Ushakov wrote: > In that case a local rump header plays that role (either including > cdefs.h or providing the necessary definition). Yes, I believe that rumpuser_port.h includes . > The conditional is a separate issue and yes it shoud be gc'ed. I agree but I wanted to be consistent with

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Alexander Nasonov wrote: > I'm following a common practice of calling __clear_cache for JIT code > except that I wrap it as a hypercall. As pointed out a while back by justin@, icache sync is a hypercall under Xen (though, I'm not sure which of the cache related ops on that page is icache sync -

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Valery Ushakov
On Tue, Jun 17, 2014 at 16:20:57 +0200, Joerg Sonnenberger wrote: > On Tue, Jun 17, 2014 at 06:43:21AM +, Alexander Nasonov wrote: > > Module Name:src > > Committed By: alnsn > > Date: Tue Jun 17 06:43:21 UTC 2014 > > > > Modified Files: > > src/lib/librumpuser

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Joerg Sonnenberger
On Tue, Jun 17, 2014 at 06:43:21AM +, Alexander Nasonov wrote: > Module Name: src > Committed By: alnsn > Date: Tue Jun 17 06:43:21 UTC 2014 > > Modified Files: > src/lib/librumpuser: rumpuser_pth_dummy.c > > Log Message: > For consistency with other files in the same directory

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: > Ok, one more try, this time with an example: > > * fact: interface will be used to say "I have loaded code here, please > arrange things so that it can be executed" > * fact: you want to call the interface "sync icache" and possess those > semantics > > the example: > Let's

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Antti Kantee
On 17/06/14 11:52, Alexander Nasonov wrote: That's one more indication that "sync icache" is the wrong level of problem to represent at the interface level. Existence of __clear_cache is an indication of the opposite. Let's be thankful we're not discussing implementing a compiler. If it wer

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Antti Kantee
On 17/06/14 11:23, Alexander Nasonov wrote: If you don't have time to wait for discussion or coordination, do everything in the privacy of the sljit component. Please teach me how to create a private component. Use RUMPCOMP_USER_SRCS, several examples under src/sys/rump I'm not saying that

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: > Use RUMPCOMP_USER_SRCS, several examples under src/sys/rump Thanks for the pointer, will do. > That's one more indication that "sync icache" is the wrong level of problem > to represent at the interface level. Existence of __clear_cache is an indication of the opposite. I'm

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: > I think that will be overengineering it, but if you want to come up with a > concrete proposal patch, please. I'd simply use discussion and not rushing > commits to avoid issues here. The code is in the tree already. I don't need anything else for sljit. The sljit library do

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Antti Kantee
On 17/06/14 09:46, Alexander Nasonov wrote: Antti Kantee wrote: To be clear: the objection was to modifying a stable interface without coordination. The hypercall interface is implemented in multiple places outside of the NetBSD tree, including by 3rd parties. Stable interface in -current? Ho

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: > To be clear: the objection was to modifying a stable interface > without coordination. The hypercall interface is implemented in > multiple places outside of the NetBSD tree, including by 3rd parties. Stable interface in -current? How are you supposed to make any significant

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Antti Kantee
On Tue, Jun 17, 2014 at 08:42:35AM +, Alexander Nasonov wrote: > Module Name: src > Committed By: alnsn > Date: Tue Jun 17 08:42:35 UTC 2014 > > Modified Files: > src/lib/librumpuser: Makefile > > Log Message: > Antti objected to including rumpuser_sync_icache. Exclude it from