Re: CVS commit: src/sys/coda

2013-11-23 Thread Christos Zoulas
In article <20131123234556.1b4ac14a...@mail.netbsd.org>, Mindaugas Rasiukevicius wrote: >chris...@zoulas.com (Christos Zoulas) wrote: >> On Nov 23, 11:24pm, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: >> -- Subject: Re: CVS commit: src/sys/coda >> >> | mp = mp == TAILQ_END(&mountlist) ? NU

Re: CVS commit: src/sys/coda

2013-11-23 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: > On Nov 23, 11:24pm, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: > -- Subject: Re: CVS commit: src/sys/coda > > | mp = mp == TAILQ_END(&mountlist) ? NULL : mp; > | > | Over: > | > | return mp; > | > | Everybody understood NULL, so why obfuscat

Re: CVS commit: src/sys/coda

2013-11-23 Thread Christos Zoulas
On Nov 23, 11:24pm, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: -- Subject: Re: CVS commit: src/sys/coda | mp = mp == TAILQ_END(&mountlist) ? NULL : mp; | | Over: | | return mp; | | Everybody understood NULL, so why obfuscate the code? The point (as I understand it) is so that if you wan

Re: CVS commit: src/sys/coda

2013-11-23 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: > On Nov 23, 6:14pm, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: > -- Subject: Re: CVS commit: src/sys/coda > > | Although this is correct, TAILQ_END(&mountlist) *suggests* access of > | mountlist. If it would be true, it would be unlocked and b

Re: CVS commit: src/sys/coda

2013-11-23 Thread Christos Zoulas
On Nov 23, 6:14pm, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: -- Subject: Re: CVS commit: src/sys/coda | Although this is correct, TAILQ_END(&mountlist) *suggests* access of | mountlist. If it would be true, it would be unlocked and buggy access. | Why not just "return mp;" ? | | It seem

Re: CVS commit: src/sys/coda

2013-11-23 Thread Mindaugas Rasiukevicius
"Christos Zoulas" wrote: > Module Name: src > Committed By: christos > Date: Sat Nov 23 17:57:23 UTC 2013 > > Modified Files: > src/sys/coda: coda_vfsops.c > > Log Message: > replace open-coded scan with macro; fix locking > -/* mount structure wasn't found */ -return(NU

Re: CVS commit: src/sys/arch/i386/conf

2013-11-23 Thread Jeff Rizzo
On 11/23/13 4:50 AM, Marc Balmer wrote: Zitat von Jeff Rizzo : Module Name:src Committed By:riz Date:Fri Nov 22 18:58:01 UTC 2013 Modified Files: src/sys/arch/i386/conf: ALL Log Message: Comment out npf for now, as we can't have both NPF and PF in the same kernel - rmind h

Re: CVS commit: src/sys/arch/i386/conf

2013-11-23 Thread Marc Balmer
Zitat von Jeff Rizzo : Module Name:src Committed By: riz Date: Fri Nov 22 18:58:01 UTC 2013 Modified Files: src/sys/arch/i386/conf: ALL Log Message: Comment out npf for now, as we can't have both NPF and PF in the same kernel - rmind has said he'll address this eventual